Right, we need to update alma-sbom
too. And yes, I'd imagine that we might keep this as a classmethod
.
Yeah, let's just keep it as it is now. We can do the move later.
Shall we rename it to VCNWrapper? This would also involve updating the project name, git repo name, etc. Not sure, what do you think? ????
Left a couple of comments, but other than that, it looks good to me. Also, shall we also bring almalinux/cas_wrapper#3 back?
Left minor style-related comments. Other than that, LGTM
Just a personal taste for readability, I'd move if
into the next line
Left a few minor comments. But overall it looks good to me. Just one question, why using a personal repo rather than a communiy one?
Not sure if we want to add a timestamp or the like to both the diff and log files. As my previous comment, anything against merging this as it is
It's rare, but security advisories can also be RHBAs or RHEAs. Up to you if want to add this to the logic, nothing against merging this as it is now.