Javier Hernández jhernandez
  • Brussels, Belgium
  • Joined on 2022-08-12
jhernandez suggested changes for danfimov/immudb_wrapper#1 2023-07-28 09:09:12 +00:00
Initial immudb_wrapper implementation

LGTM, although I haven't tested yet.

jhernandez commented on pull request almalinux/cas_wrapper#7 2023-06-13 09:10:43 +00:00
ALBS-1122: Replace notarization interface from CAS to VCN

Right, we need to update alma-sbom too. And yes, I'd imagine that we might keep this as a classmethod.

jhernandez commented on pull request almalinux/cas_wrapper#7 2023-06-13 09:07:28 +00:00
ALBS-1122: Replace notarization interface from CAS to VCN

Yeah, let's just keep it as it is now. We can do the move later.

jhernandez commented on pull request almalinux/cas_wrapper#7 2023-06-08 16:01:21 +00:00
ALBS-1122: Replace notarization interface from CAS to VCN

Shall we rename it to VCNWrapper? This would also involve updating the project name, git repo name, etc. Not sure, what do you think? 🤔

jhernandez commented on pull request almalinux/cas_wrapper#7 2023-06-08 16:01:21 +00:00
ALBS-1122: Replace notarization interface from CAS to VCN

Left a couple of comments, but other than that, it looks good to me. Also, shall we also bring almalinux/cas_wrapper#3 back?

jhernandez commented on pull request almalinux/pungi#14 2023-03-20 12:01:51 +00:00
ALBS-1030: Generate Devel section in packages.json

extra empty line

jhernandez approved almalinux/pungi#14 2023-03-20 11:46:27 +00:00
ALBS-1030: Generate Devel section in packages.json

Left minor style-related comments. Other than that, LGTM

jhernandez commented on pull request almalinux/pungi#14 2023-03-20 11:45:29 +00:00
ALBS-1030: Generate Devel section in packages.json

same as above

jhernandez commented on pull request almalinux/pungi#14 2023-03-20 11:45:21 +00:00
ALBS-1030: Generate Devel section in packages.json

on purpose empty line?

jhernandez commented on pull request almalinux/pungi#14 2023-03-20 11:38:17 +00:00
ALBS-1030: Generate Devel section in packages.json

Just a personal taste for readability, I'd move if into the next line

jhernandez commented on pull request kzhukov/albs-oval-errata-diff#1 2023-01-10 21:20:23 +00:00
ALBS-901: New service albs-oval-errata-dif

Oh okay, I see there's a timestamp in the report 👍

jhernandez commented on pull request kzhukov/albs-oval-errata-diff#1 2023-01-10 11:31:00 +00:00
ALBS-901: New service albs-oval-errata-dif

As a tip, [RH

jhernandez approved kzhukov/albs-oval-errata-diff#1 2023-01-09 18:08:59 +00:00
ALBS-901: New service albs-oval-errata-dif

Left a few minor comments. But overall it looks good to me. Just one question, why using a personal repo rather than a communiy one?

jhernandez commented on pull request kzhukov/albs-oval-errata-diff#1 2023-01-09 18:05:37 +00:00
ALBS-901: New service albs-oval-errata-dif

Not sure if we want to add a timestamp or the like to both the diff and log files. As my previous comment, anything against merging this as it is

jhernandez commented on pull request kzhukov/albs-oval-errata-diff#1 2023-01-09 18:02:59 +00:00
ALBS-901: New service albs-oval-errata-dif

It's rare, but security advisories can also be RHBAs or RHEAs. Up to you if want to add this to the logic, nothing against merging this as it is now.

jhernandez commented on pull request kzhukov/albs-oval-errata-diff#1 2023-01-09 18:00:00 +00:00
ALBS-901: New service albs-oval-errata-dif

Extra whitespaces between start and services

jhernandez pushed tag 0.0.6 to almalinux/cas_wrapper 2022-11-10 10:17:57 +00:00