kzhukov/albs-oval-errata-diff
1
0
Fork 0
Code Issues Pull Requests Releases Activity

ALBS-901: New service albs-oval-errata-dif #1

Merged
kzhukov merged 11 commits from ALBS-901 into main 2023-01-11 10:43:42 +00:00
Conversation 1 Commits 11 Files Changed 12 +685
kzhukov commented 2022-12-29 16:12:29 +00:00
Owner
Copy Link
No description provided.
kzhukov added 7 commits 2022-12-29 16:12:29 +00:00 
- fixed typo in package name
kzhukov added 1 commit 2022-12-29 16:18:14 +00:00
kzhukov added 1 commit 2022-12-30 08:50:53 +00:00
kzhukov added 1 commit 2022-12-30 15:29:58 +00:00
kzhukov added 1 commit 2023-01-04 10:16:38 +00:00 
bugfix: false positive of SA with missing packages
Korulag approved these changes 2023-01-09 10:50:40 +00:00
jhernandez reviewed 2023-01-09 17:59:59 +00:00
README.md
@ -0,0 +30,4 @@
```bash
$ pip install -r requirements.txt
```
4. Create config file using [config.default.yml](config.default.yml) and start service with _albs_oval_errata_diff.py_ script
jhernandez commented 2023-01-09 17:59:59 +00:00
First-time contributor
Copy Link

Extra whitespaces between start and services

Extra whitespaces between `start` and `services`
👍 1
jhernandez reviewed 2023-01-09 18:02:59 +00:00
albs_oval_errata_diff/comparer.py
@ -0,0 +77,4 @@
issued_dt = datetime.datetime.strptime(issued, "%Y-%m-%d")
# we are only interesed in Security advisories after RHEL 8.3
if ('RHSA' not in title and 'ALSA' not in title) or issued_dt < not_before:
jhernandez commented 2023-01-09 18:02:59 +00:00
First-time contributor
Copy Link

It's rare, but security advisories can also be RHBAs or RHEAs. Up to you if want to add this to the logic, nothing against merging this as it is now.

It's rare, but security advisories can also be RHBAs or RHEAs. Up to you if want to add this to the logic, nothing against merging this as it is now.
jhernandez commented 2023-01-10 11:31:00 +00:00
First-time contributor
Copy Link

As a tip, [RH|AL]BAs and [RH|AL]EAs that became security advisories must have the severity field set to any of the valid values, these are: Low, Moderate, Important or Critical. You can check them here https://access.redhat.com/security/updates/classification

As a tip, [RH|AL]BAs and [RH|AL]EAs that became security advisories must have the severity field set to any of the valid values, these are: Low, Moderate, Important or Critical. You can check them here https://access.redhat.com/security/updates/classification
👍 1
kzhukov commented 2023-01-11 10:42:34 +00:00
Author
Owner
Copy Link

Thanks for heads up
I created task for adding support of BA/EA in https://cloudlinux.atlassian.net/browse/ALBS-915

I will work on this feature in separate branch. This one I will merge

Thanks for heads up I created task for adding support of BA/EA in https://cloudlinux.atlassian.net/browse/ALBS-915 I will work on this feature in separate branch. This one I will merge
kzhukov marked this conversation as resolved
jhernandez reviewed 2023-01-09 18:05:37 +00:00
albs_oval_errata_diff/config.py
@ -0,0 +12,4 @@
# DEFAULTS
DIFF_FILE = Path('/tmp/albs-oval-errata-diff.json')
jhernandez commented 2023-01-09 18:05:37 +00:00
First-time contributor
Copy Link

Not sure if we want to add a timestamp or the like to both the diff and log files. As my previous comment, anything against merging this as it is

Not sure if we want to add a timestamp or the like to both the diff and log files. As my previous comment, anything against merging this as it is
kzhukov commented 2023-01-10 11:06:29 +00:00
Author
Owner
Copy Link

Not sure what you mean. There are no timestamps in diff file. Only timestamps of report generation date and timestamp of oldest SA we are looking for


}[boggart@buildsys-grafana tmp]$ tail -n 10 albs-oval-errata-diff.json 
                "diff": "SA is missing in errata"
            }
        ],
        "rhel_oval_url": "https://www.redhat.com/security/data/oval/v2/RHEL9/rhel-9.oval.xml.bz2",
        "alma_oval_url": "https://repo.almalinux.org/security/oval/org.almalinux.alsa-9.xml.bz2",
        "alma_errata_url": "https://errata.almalinux.org/9/errata.full.json"
    },
    "report_generated": 1673347589764.741,
    "sa_not_before": 1652832000000.0
Not sure what you mean. There are no timestamps in diff file. Only timestamps of report generation date and timestamp of oldest SA we are looking for ``` }[boggart@buildsys-grafana tmp]$ tail -n 10 albs-oval-errata-diff.json "diff": "SA is missing in errata" } ], "rhel_oval_url": "https://www.redhat.com/security/data/oval/v2/RHEL9/rhel-9.oval.xml.bz2", "alma_oval_url": "https://repo.almalinux.org/security/oval/org.almalinux.alsa-9.xml.bz2", "alma_errata_url": "https://errata.almalinux.org/9/errata.full.json" }, "report_generated": 1673347589764.741, "sa_not_before": 1652832000000.0 ```
jhernandez commented 2023-01-10 21:20:23 +00:00
First-time contributor
Copy Link

Oh okay, I see there's a timestamp in the report ????

Oh okay, I see there's a timestamp in the report ????
kzhukov marked this conversation as resolved
jhernandez approved these changes 2023-01-09 18:08:59 +00:00
jhernandez left a comment
First-time contributor
Copy Link

Left a few minor comments. But overall it looks good to me. Just one question, why using a personal repo rather than a communiy one?

Left a few minor comments. But overall it looks good to me. Just one question, why using a personal repo rather than a communiy one?
kzhukov commented 2023-01-10 12:44:31 +00:00
Author
Owner
Copy Link

Left a few minor comments. But overall it looks good to me. Just one question, why using a personal repo rather than a communiy one?

We discussed this at the end of the year, and desided not to publish this due to political reasons)
@Korulag am I right?

> Left a few minor comments. But overall it looks good to me. Just one question, why using a personal repo rather than a communiy one? We discussed this at the end of the year, and desided not to publish this due to political reasons) @Korulag am I right?
kzhukov merged commit 5e3e2168d8 into main 2023-01-11 10:43:42 +00:00
kzhukov deleted branch ALBS-901 2023-01-11 10:44:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Korulag
jhernandez
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kzhukov/albs-oval-errata-diff#1
No description provided.
Delete Branch "ALBS-901"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?