danfimov/immudb_wrapper
1
0
Fork 0
Code Issues Pull Requests Releases Activity

Initial immudb_wrapper implementation #1

Closed
danfimov wants to merge 2 commits from init into master
pull from: init
merge into: danfimov:master
Conversation 1 Commits 2 Files Changed 5 +1066 -1
danfimov commented 2023-07-24 09:58:07 +00:00
Owner
Copy Link
No description provided.
danfimov force-pushed init from eb8d52f0ca to f784296f0f 2023-07-24 17:32:50 +00:00 Compare
danfimov force-pushed init from f784296f0f to 60587fbcbf 2023-07-24 18:05:39 +00:00 Compare
danfimov force-pushed init from 60587fbcbf to f1940f4725 2023-07-24 18:21:21 +00:00 Compare
soksanichenko reviewed 2023-07-28 08:46:54 +00:00
immudb_wrapper.py
@ -0,0 +104,4 @@
) -> str:
"""
Scale bytes to its proper byte format
e.g:
soksanichenko commented 2023-07-28 08:43:18 +00:00
First-time contributor
Copy Link

I guess better to move the list of keys to a separate var and use them in the loop

I guess better to move the list of keys to a separate var and use them in the loop
immudb_wrapper.py
@ -0,0 +130,4 @@
checksum_type : str
Checksum type (e.g. sha1, sha256).
Returns
soksanichenko commented 2023-07-28 08:45:02 +00:00
First-time contributor
Copy Link

For the future
https://pypi.org/project/humanize/

For the future https://pypi.org/project/humanize/
immudb_wrapper.py
@ -0,0 +192,4 @@
hasher.update(content)
return hasher.hexdigest()
@staticmethod
soksanichenko commented 2023-07-28 08:45:35 +00:00
First-time contributor
Copy Link

Why didn't you use utf-8?

Why didn't you use utf-8?
jhernandez requested changes 2023-07-28 09:09:12 +00:00
jhernandez left a comment
First-time contributor
Copy Link

LGTM, although I haven't tested yet.
Can you please provide a small README file that, roughly, includes:

  • Small description/purpose of the repo
  • Dependencies and setup - would be great if including how to setup an immudb instance or pointing to a place where we can go and check
  • Small description of what this code can do/features/etc, and small code snippets using it
  • How to contribute
    Also, please do add a LICENSE file
LGTM, although I haven't tested yet. Can you please provide a small README file that, roughly, includes: * Small description/purpose of the repo * Dependencies and setup - would be great if including how to setup an immudb instance or pointing to a place where we can go and check * Small description of what this code can do/features/etc, and small code snippets using it * How to contribute Also, please do add a LICENSE file
Korulag approved these changes 2023-08-03 09:16:24 +00:00
jhernandez approved these changes 2023-08-03 09:28:28 +00:00
danfimov force-pushed init from 2dc25feb44 to 53ec2daab2 2023-08-03 15:31:15 +00:00 Compare
danfimov commented 2023-08-07 11:22:21 +00:00
Author
Owner
Copy Link

This PR moved to github.
https://github.com/AlmaLinux/immudb-wrapper/pull/1

This PR moved to github. https://github.com/AlmaLinux/immudb-wrapper/pull/1
danfimov closed this pull request 2023-08-07 11:22:22 +00:00
danfimov deleted branch init 2023-08-07 11:22:30 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Korulag
jhernandez
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: danfimov/immudb_wrapper#1
No description provided.
Delete Branch "init"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?