almalinux/cas_wrapper
14
0
Fork 2
Code Issues Pull requests Releases Activity

ALBS-1122: Replace notarization interface from CAS to VCN #7

Merged
danfimov merged 3 commits from danfimov/cas_wrapper:albs-1122 into master 2023-06-20 14:43:28 +00:00
Conversation 2 Commits 3 Files changed 3 +117 -92
danfimov commented 2023-06-07 14:32:48 +00:00
Member
Copy link
No description provided.
jhernandez reviewed 2023-06-08 16:01:20 +00:00
jhernandez left a comment
Copy link

Left a couple of comments, but other than that, it looks good to me. Also, shall we also bring #3 back?

Left a couple of comments, but other than that, it looks good to me. Also, shall we also bring https://git.almalinux.org/almalinux/cas_wrapper/pulls/3 back?
cas_wrapper.py Outdated
@ -6,3 +24,4 @@
return wrapper
class CasWrapper:
jhernandez commented 2023-06-08 15:58:54 +00:00
Member
Copy link

Shall we rename it to VCNWrapper? This would also involve updating the project name, git repo name, etc. Not sure, what do you think? 🤔

Shall we rename it to VCNWrapper? This would also involve updating the project name, git repo name, etc. Not sure, what do you think? 🤔
danfimov commented 2023-06-12 09:08:13 +00:00
Author
Member
Copy link

I haven't renamed to VCNWrapper because of these things, probably we can to rename it in more abstract like style, i.e. CodeNotaryWrapper or something like this

I haven't renamed to `VCNWrapper` because of these things, probably we can to rename it in more abstract like style, i.e. `CodeNotaryWrapper` or something like this
jhernandez commented 2023-06-13 09:07:28 +00:00
Member
Copy link

Yeah, let's just keep it as it is now. We can do the move later.

Yeah, let's just keep it as it is now. We can do the move later.
danfimov marked this conversation as resolved
cas_wrapper.py
@ -39,3 +60,1 @@
cls._is_binary_present()
command = local['cas']['--version']
version = command().split()[-1].split('v')[1]
def get_version(self):
jhernandez commented 2023-06-08 15:57:33 +00:00
Member
Copy link

This breaks https://github.com/AlmaLinux/alma-sbom/blob/main/libsbom/cyclonedx.py#L30

This breaks https://github.com/AlmaLinux/alma-sbom/blob/main/libsbom/cyclonedx.py#L30
danfimov commented 2023-06-12 09:04:59 +00:00
Author
Member
Copy link

yes, but we need to make changes in alma-sbom repository anyway, because CasWrapper expect different values for initialization
also maybe there is a point, to left this method as classmethod

yes, but we need to make changes in `alma-sbom` repository anyway, because `CasWrapper` expect different values for initialization also maybe there is a point, to left this method as `classmethod`
jhernandez commented 2023-06-13 09:10:43 +00:00
Member
Copy link

Right, we need to update alma-sbom too. And yes, I'd imagine that we might keep this as a classmethod.

Right, we need to update `alma-sbom` too. And yes, I'd imagine that we might keep this as a `classmethod`.
danfimov marked this conversation as resolved
jhernandez approved these changes 2023-06-19 11:31:18 +00:00
danfimov merged commit d68685bf72 into master 2023-06-20 14:43:28 +00:00
danfimov deleted branch albs-1122 2023-06-20 14:43:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jhernandez
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
almalinux/cas_wrapper!7
No description provided.