AvoidMe

AvoidMe pushed to add_bom_argument at almalinux/cas_wrapper

2022-07-18 09:31:02 +00:00

2cd795d876 Add debug info

AvoidMe created branch add_bom_argument in almalinux/cas_wrapper

2022-07-18 08:48:13 +00:00

AvoidMe pushed to add_bom_argument at almalinux/cas_wrapper

2022-07-18 08:48:13 +00:00

1650724326 Add --bom argument to all commands

AvoidMe pushed to ALBS-444 at almalinux/cas_wrapper

2022-06-29 16:50:59 +00:00

b6dfd39655 Add return_json option to notarize_artifact

AvoidMe commented on pull request almalinux/cas_wrapper#2

2022-06-29 16:06:27 +00:00

ALBS-444

Instead of with self I would prefer self.ensure_loggin() or something, because you didn't use exit

AvoidMe commented on pull request almalinux/cas_wrapper#2

2022-06-29 16:04:37 +00:00

ALBS-444

It's bad practice to mutate arguments like this, can you return all artifacts with the respected hashes instead?

AvoidMe commented on pull request almalinux/cas_wrapper#1

2022-06-21 11:14:18 +00:00

yes

AvoidMe commented on pull request almalinux/cas_wrapper#1

2022-06-21 08:38:24 +00:00

I feel uncomfortable with login() in __init__, can't we do it in __enter__ and __exit__?

AvoidMe commented on pull request almalinux/pungi#1

2022-03-03 11:33:47 +00:00

btw, Are you sure python3-dataclasess rpm package is the same as python upstream library?

AvoidMe approved almalinux/pungi#1

2022-03-03 11:32:39 +00:00

lgtm