ALBS-443: Integrate CodeNotary with git updater tool

Conversation 0 Commits 10 Files Changed 2

soksanichenko commented

Owner

Add cas wrapper

soksanichenko added 1 commit

5a4382088b Add 'cas_wrapper.py'

Add cas wrapper

soksanichenko added 1 commit

037aa1ad5e Update 'cas_wrapper.py'

soksanichenko added 1 commit

1fcbac41b1 Update 'cas_wrapper.py'

soksanichenko added 1 commit

85764ae655 ALBS-443: Integrate CodeNotary with git updater tool

- Additional metadata for notarizing

soksanichenko added 1 commit

e25c5070b0 ALBS-443: Integrate CodeNotary with git updater tool

- Additional metadata for notarizing

soksanichenko added 1 commit

f46eef7df9 ALBS-443: Integrate CodeNotary with git updater tool

- Additional metadata for notarizing

soksanichenko added 1 commit

646b984d89 ALBS-443: Integrate CodeNotary with git updater tool

- Env vars with credentials

anfimovdm approved these changes

anfimovdm left a comment

Collaborator

lgtm

AvoidMe reviewed

cas_wrapper.py

													
				@ -0,0 +28,4 @@

				                SIGNER_ID=self._cas_signer_id

				        ):

				            self._cas = local['cas']

				            self._cas['login']()

AvoidMe commented

Collaborator

I feel uncomfortable with login() in __init__, can't we do it in __enter__ and __exit__?

I feel uncomfortable with `login()` in `__init__`, can't we do it in `__enter__` and `__exit__`?

soksanichenko commented

Poster

Owner

Do you suggest convert it to context manager?

AvoidMe commented

Collaborator

yes

soksanichenko marked this conversation as resolved

soksanichenko added 1 commit

576b7e0185 ALBS-443: Integrate CodeNotary with git updater tool

- setup.py

soksanichenko added 1 commit

78c68f7a5d ALBS-443: Integrate CodeNotary with git updater tool

- setup.py

soksanichenko added 1 commit

a2ee1427fa ALBS-443: Integrate CodeNotary with git updater tool

- setup.py

soksanichenko merged commit bd5686e9e4 into master 1 year ago

soksanichenko referenced this issue from a commit

Merge pull request 'ALBS-443: Integrate CodeNotary with git updater tool' (#1) from ALBS-443 into master

Reviewers

anfimovdm approved these changes

The pull request has been merged as bd5686e9e4.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b ALBS-443 master

git pull origin ALBS-443

Step 2:

Merge the changes and update on Gitea.

git checkout master

git merge --no-ff ALBS-443

git push origin master

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

ALBS-443: Integrate CodeNotary with git updater tool #1

Reviewers

Step 1:

Step 2: