almalinux
/
cas_wrapper
14
0
Fork 2
Code Issues Pull Requests Releases Activity

ALBS-443: Integrate CodeNotary with git updater tool #1

Merged
soksanichenko merged 10 commits from ALBS-443 into master 2022-06-22 11:07:24 +00:00
Conversation 0 Commits 10 Files Changed 2 +121
soksanichenko commented 2022-06-20 10:20:21 +00:00
Owner
Copy Link

Add cas wrapper

Add cas wrapper
soksanichenko added 1 commit 2022-06-20 10:20:22 +00:00
soksanichenko added 1 commit 2022-06-20 10:22:54 +00:00
soksanichenko added 1 commit 2022-06-21 06:41:46 +00:00
soksanichenko added 1 commit 2022-06-21 06:57:04 +00:00
soksanichenko added 1 commit 2022-06-21 06:57:34 +00:00
soksanichenko added 1 commit 2022-06-21 06:59:48 +00:00
soksanichenko added 1 commit 2022-06-21 08:04:37 +00:00
anfimovdm approved these changes 2022-06-21 08:19:20 +00:00
anfimovdm left a comment
Member
Copy Link

lgtm

lgtm
AvoidMe reviewed 2022-06-21 08:38:24 +00:00
cas_wrapper.py
@ -0,0 +28,4 @@
SIGNER_ID=self._cas_signer_id
):
self._cas = local['cas']
self._cas['login']()
AvoidMe commented 2022-06-21 08:38:24 +00:00
Member
Copy Link

I feel uncomfortable with login() in __init__, can't we do it in __enter__ and __exit__?

I feel uncomfortable with `login()` in `__init__`, can't we do it in `__enter__` and `__exit__`?
soksanichenko commented 2022-06-21 10:46:18 +00:00
Author
Owner
Copy Link

Do you suggest convert it to context manager?

Do you suggest convert it to context manager?
AvoidMe commented 2022-06-21 11:14:18 +00:00
Member
Copy Link

yes

yes
soksanichenko marked this conversation as resolved
soksanichenko added 1 commit 2022-06-21 10:40:23 +00:00
soksanichenko added 1 commit 2022-06-21 10:41:32 +00:00
soksanichenko added 1 commit 2022-06-21 10:41:53 +00:00
soksanichenko merged commit bd5686e9e4 into master 2022-06-22 11:07:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
anfimovdm
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: almalinux/cas_wrapper#1
No description provided.
Delete Branch "ALBS-443"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?