@ -96,0 +174,4 @@
self._logger.exception('Cannot notarize artifact:')
all_artifacts_is_notarized = False
artifact.cas_hash = cas_artifact_hash
It's bad practice to mutate arguments like this, can you return all artifacts with the respected hashes instead?
@ -96,0 +144,4 @@
use_hash: bool = False,
) -> bool:
is_authenticated = False
with self as cas:
Instead of with self I would prefer self.ensure_login() or something, because you didn't use exit
Add docstring to the new functions
@ -96,0 +121,4 @@
# it should return 0 for authenticated and trusted commits
is_authenticated = not bool(
commit_cas_hash = result_json.get('hash')
You don't get hash because use_hash equals to Fasle by default
I can get hash here, because when I use return_json flag, self.authenticate returns full JSON response
@ -96,0 +145,4 @@
# we can fall with ProcessExecutionError,
# because source can be not notarized
self._logger.exception('Cannot authenticate %s:', local_path)
I guess colon is not needed in the logging message or it's in wrong place of the message
@ -96,0 +166,4 @@
cas_artifact_hash = future.result()
Add name of an artifact to the logging message
No due date set.
No dependencies set.
Deleting a branch is permanent. It CANNOT be undone. Continue?