Most GNOME apps now have a standardized About screen with links
(not buttons) for credits, website and links. Lukas called these
'selectors', which I like - but inconsistently; as well as
generic gnome_selector_foo needles, we have some app-specific
needles, and some with 'button' in the name.
Let's always call these 'selectors', always use generic needle
names (since the same needles should match for almost all apps),
and have the one remaining case where we have a 'button' (the
credits button in Evince) be the variant case, handled by putting
'button' in the needle name, but using the same tag as other
needles.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
We've seen some failures of the weather test at the start of
weather_report, where the test expects to be at the hourly view,
and instead it seems to be at a sort of broken state:
https://openqa.fedoraproject.org/tests/1505080#step/weather_report/3
I'm guessing this may be because currently aaa_setup clicks the
city name then is immediately complete, so it will immediately
snapshot. I guess this can result in things being stuck in a kind
of intermediate state on snapshot restore. So, to try and avoid
this, let's assert that we reach the hourly view after clicking
the city name, then wait_still_screen for a few seconds to make
sure things are settled down, before we complete and snapshot.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
