Not quite sure what changed (probably GTK?) but somehow all the
smiley renderings changed a little bit.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
It now includes a better explanation of *why* fifloader exists,
and the fundamental design difference between fifloader and both
upstream formats. But to compensate, the other bits are made more
concise, hopefully without losing any useful information.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
I've always hated the magic group name derivation in fifloader,
and it prevents it being used by anyone but Fedora. This fixes
that by requiring group_name to be set in the Products. This is
an executive decision, but it makes sense at least with how
Fedora uses openQA. If other users who might want to adopt
fifloader *don't* have a 100% assocation from products to job
groups, we can introduce more ways to set it in future, I guess.
I made it compulsory because it feels weird to have job templates
that aren't in groups...I don't even know how those get shown in
the web UI. But if there's a real use case for this we can make
it optional.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
It is required with podman 5.5.0 for the "podman run --device-read-bps"
test. If we don't load it the test will be skipped and we loose some
coverage.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This reduces another chunk of duplication in the templates by
using ProfileGroups. It should produce *mostly* the same results
as before, but some inconsistencies are intentionally fixed (like
some desktop tests not running on
fedora-Workstation-upgrade-x86_64-*-64bit), and several priorities
change. It's not really possible to make all priorities match
exactly, so I took the chance to make some more consistent with
our original intent all those years ago: tests related to Basic
criteria should be 20 on blocking images, Beta criteria are 30,
and Final criteria are 40.
We're also consistent about running all the same tests on osbuild
and non-osbuild lives.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
OK, this is getting kinda close to over-engineering, but what
the heck. With this, a profile group can contain another profile
group. There is no infinite recursion protection yet.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Any of the four might not exist. At least *one* of the four has
to exist, but we can't rely on any particular one existing, so we
have to be very defensive. The only rule is that at least one
out of profiles and groups has to exist after merge.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This test suite replaces the Evince test suite and
adds altered scripts and needles to go with the
Papers applications. At the same time, it provides
the same level of functionality and testability
as the original evince test.
Fixes: https://pagure.io/fedora-qa/os-autoinst-distri-fedora/issue/377
This is another new convenience feature. Groups of profiles let
us avoid repeating commonly-used sets. A test suite can specify
a group of profiles, with a base priority. The priority value
for each profile within the ProfileGroup is added to the base
priority in the test suite.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
They're both using a new PatternFly, so lots of stuff changed.
This is just the update test, we'll have to update a few more
needles for the compose later.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This adds another new fifloader-only top-level concept,
ProductDefaults. This just contains default values for all
products (on a per-file basis; these are applied *before* file
merge happens).
Signed-off-by: Adam Williamson <awilliam@redhat.com>
I noticed that products with the same flavor often repeat the
same settings. Let's use our intermediate format to reduce this
repetition. We'll add a top-level dict for Flavors which allows
them to have settings, then in reverse_qol, for each product,
merge in the flavor's settings. Conflicts are resolved in favor
of the product.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
I saw a case where line 1 had a cursor visible so the match
failed. Instead of having two needles for cursor / no cursor,
let's just match on lines 2 and 3 instead so it's not a problem.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
We will fix that test upstream but for now skip it to prevent false
positives on all future kernel updates.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This is a change in the image viewer app, or maybe fallout from
the menu_launch_type change, not sure. Anyhow, it's not really
a problem if the image viewer opens in a small window rather than
maximized, so let's just have a needle for it.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This is how the test did it before the big menu_launch_type
commit, and we use 'kwallet' in another test. Doing this needs an
additional needle or needle tag, which is pointless, let's just
be consistent that it's 'kwallet'.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
We have enhanced the menu_launch_type to allow for
start checking and maximizing applications.
This PR uses the new functions wherever it seems
logical.
If special logic was used for certain cases,
we have not touched these to preserve the
exact behaviour.
The crash workaround for the Fonts flatpak is dropped because it
no longer seems to be needed with the latest version of the
flatpak, and dropping it simplifies this migration.
Fixes: https://pagure.io/fedora-qa/os-autoinst-distri-fedora/issue/358
It seems like 480 is a bit low for our oldest, slowest x86_64
worker hosts on the lab instance (worker03 and worker05), they
frequently hit this and fail. Let's bump it.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Fedora Rawhide (to be 43) has new applications that replace
the older ones, namely Papers replacing Evince and Showtime
replacing the Totem.
We are adding a condition to run correct applications on Rawhide
while retaining the older applications for a while until the change
has been made in whole.
Fixes: https://pagure.io/fedora-qa/os-autoinst-distri-fedora/issue/375