Be consistent about credits, website and legal selectors

Most GNOME apps now have a standardized About screen with links
(not buttons) for credits, website and links. Lukas called these
'selectors', which I like - but inconsistently; as well as
generic gnome_selector_foo needles, we have some app-specific
needles, and some with 'button' in the name.

Let's always call these 'selectors', always use generic needle
names (since the same needles should match for almost all apps),
and have the one remaining case where we have a 'button' (the
credits button in Evince) be the variant case, handled by putting
'button' in the needle name, but using the same tag as other
needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

needles/gnome/apps/maps/maps_button_credits-20240425.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "width": 54,
-      "xpos": 355,
-      "ypos": 581,
-      "type": "match",
-      "height": 24
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "maps_button_credits"
-  ]
-}

needles/gnome/apps/maps/maps_button_credits-20250319.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 356,
-      "ypos": 580,
-      "width": 54,
-      "height": 24,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "maps_button_credits"
-  ]
-}

needles/gnome/apps/maps/maps_button_credits.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 355,
-      "ypos": 582,
-      "width": 54,
-      "height": 24,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "maps_button_credits"
-  ]
-}

needles/gnome/gnome_selector_credits-20240424.json

@@ -10,6 +10,6 @@
   ],
   "properties": [],
   "tags": [
-    "gnome_button_credits"
+    "gnome_selector_credits"
   ]
-}
+}

needles/gnome/gnome_selector_credits-20250319.json

@@ -10,6 +10,6 @@
   ],
   "properties": [],
   "tags": [
-    "gnome_button_credits"
+    "gnome_selector_credits"
   ]
-}
+}

needles/gnome/gnome_selector_credits-button.json

@@ -10,6 +10,6 @@
   ],
   "properties": [],
   "tags": [
-    "gnome_button_credits"
+    "gnome_selector_credits"
   ]
 }

needles/gnome/gnome_selector_credits-libadwaita-20220818.json

@@ -10,6 +10,6 @@
   ],
   "properties": [],
   "tags": [
-    "gnome_button_credits"
+    "gnome_selector_credits"
   ]
-}
+}

tests/applications/calculator/about.pm

@@ -17,9 +17,9 @@ sub run {
     # Check that it is shown.
     assert_screen("calc_about_shown");
     # Click on the Credits button and check that it shows.
-    unless (check_screen("gnome_button_credits", 30)) {
+    unless (check_screen("gnome_selector_credits", 30)) {
         send_key("pgdn");
-        assert_screen("gnome_button_credits", 15);
+        assert_screen("gnome_selector_credits", 15);
         record_soft_failure("https://gitlab.gnome.org/GNOME/gnome-calculator/-/issues/419");
     }
     click_lastmatch;

tests/applications/clocks/about.pm

@@ -14,7 +14,7 @@ sub run {
     # Click on About Clocks to see the About info.
     assert_and_click("clocks_menu_about");
     assert_screen("clocks_about_displayed");
-    assert_and_click("gnome_button_credits");
+    assert_and_click("gnome_selector_credits");
     assert_screen("clocks_credits_shown");
 
 }

tests/applications/contacts/about.pm

@@ -18,7 +18,7 @@ sub run {
     assert_screen("contacts_about_shown");
     # Click on Credits to move to credits and check we
     # have moved.
-    assert_and_click("gnome_button_credits");
+    assert_and_click("gnome_selector_credits");
     assert_screen("contacts_credits_shown");
 }
 

tests/applications/disks/about.pm

@@ -17,7 +17,7 @@ sub run {
     assert_screen("disks_about_shown");
 
     # Click on the Credits button.
-    assert_and_click("gnome_button_credits");
+    assert_and_click("gnome_selector_credits");
 
     # Check that Credits are shown.
     assert_screen("disks_credits_shown");

tests/applications/evince/about.pm

@@ -19,7 +19,7 @@ sub run {
     assert_screen("evince_about_shown");
 
     # Click on Credits button to see the second part of the dialogue.
-    assert_and_click("gnome_button_credits", button => "left", timeout => 30);
+    assert_and_click("gnome_selector_credits", button => "left", timeout => 30);
 
     # Check that Credits are accessible and visible, too.
     assert_screen("evince_credits_shown");

tests/applications/fonts/about.pm

@@ -13,7 +13,7 @@ sub run {
     # Check that the correct font is shown.
     assert_screen("fonts_about_shown");
     # Click on Credits to see them.
-    assert_and_click("gnome_button_credits");
+    assert_and_click("gnome_selector_credits");
 
     # Check that Credits are shown
     assert_screen("fonts_credits_shown");
@@ -21,14 +21,14 @@ sub run {
     send_key("esc");
 
     # Click on Legal to see legal info.
-    assert_and_click("gnome_button_legal");
+    assert_and_click("gnome_selector_legal");
     # Check that Credits are shown
     assert_screen("fonts_legal_shown");
     # Return to previous screen
     send_key("esc");
 
     # Check that a project website can be reached.
-    assert_and_click("gnome_button_website");
+    assert_and_click("gnome_selector_website");
     # Check that the website has been opened
     assert_screen("fonts_website_opened");
 }

tests/applications/gnome-text-editor/about.pm

@@ -19,7 +19,7 @@ sub run {
     assert_screen "gte_about_shown";
 
     # Click on Credits to move to another screen.
-    assert_and_click "gnome_button_credits";
+    assert_and_click "gnome_selector_credits";
     wait_still_screen(2);
 
     # Check that Credits were shown.

tests/applications/maps/about.pm

@@ -18,7 +18,7 @@ sub run {
     assert_screen("maps_about_shown");
 
     # Check that you can visit application webpages
-    assert_and_click("maps_link_website");
+    assert_and_click("gnome_selector_website");
     assert_screen("maps_website_opened");
 
     # Close the web browser
@@ -32,12 +32,12 @@ sub run {
     send_key("alt-f4");
 
     # Check that credits are shown.
-    assert_and_click("maps_button_credits");
+    assert_and_click("gnome_selector_credits");
     assert_screen("maps_credits_shown");
     send_key("esc");
 
     # Check that legal info is shown.
-    assert_and_click("maps_button_legal");
+    assert_and_click("gnome_selector_legal");
     assert_screen("maps_legal_shown");
     send_key("esc");
 }

tests/applications/nautilus/about.pm

@@ -19,7 +19,7 @@ sub run {
     assert_screen("nautilus_about_show");
 
     # Click on Credits button to see the second part of the dialogue.
-    assert_and_click("gnome_button_credits", button => "left", timeout => 30);
+    assert_and_click("gnome_selector_credits", button => "left", timeout => 30);
 
     # Check that Credits are accessible and visible, too.
     assert_screen("nautilus_credits_shown");

tests/applications/sysmon/about.pm

@@ -12,7 +12,7 @@ sub run {
     # Check that About dialogue has started.
     assert_screen("sysmon_about_shown");
     # Click on the Credits button
-    assert_and_click("gnome_button_credits");
+    assert_and_click("gnome_selector_credits");
     # Check that Credits are shown
     assert_screen("sysmon_credits_shown");
 }

tests/applications/weather/about.pm

@@ -14,7 +14,7 @@ sub run {
     assert_and_click("weather_menu_about");
     assert_screen("weather_about_shown");
     # Change to Credits
-    assert_and_click("gnome_button_credits");
+    assert_and_click("gnome_selector_credits");
     assert_screen("weather_credits_shown");
 }