Javier Hernández

jhernandez commented on pull request almalinux/pungi#14

2023-03-20 12:01:51 +00:00

ALBS-1030: Generate Devel section in packages.json

extra empty line

jhernandez approved almalinux/pungi#14

2023-03-20 11:46:27 +00:00

ALBS-1030: Generate Devel section in packages.json

Left minor style-related comments. Other than that, LGTM

jhernandez commented on pull request almalinux/pungi#14

2023-03-20 11:45:29 +00:00

ALBS-1030: Generate Devel section in packages.json

same as above

jhernandez commented on pull request almalinux/pungi#14

2023-03-20 11:45:21 +00:00

ALBS-1030: Generate Devel section in packages.json

on purpose empty line?

jhernandez commented on pull request almalinux/pungi#14

2023-03-20 11:38:17 +00:00

ALBS-1030: Generate Devel section in packages.json

Just a personal taste for readability, I'd move if into the next line

jhernandez commented on pull request kzhukov/albs-oval-errata-diff#1

2023-01-10 21:20:23 +00:00

ALBS-901: New service albs-oval-errata-dif

Oh okay, I see there's a timestamp in the report ????

jhernandez commented on pull request kzhukov/albs-oval-errata-diff#1

2023-01-10 11:31:00 +00:00

ALBS-901: New service albs-oval-errata-dif

As a tip, [RH

jhernandez approved kzhukov/albs-oval-errata-diff#1

2023-01-09 18:08:59 +00:00

ALBS-901: New service albs-oval-errata-dif

Left a few minor comments. But overall it looks good to me. Just one question, why using a personal repo rather than a communiy one?

jhernandez commented on pull request kzhukov/albs-oval-errata-diff#1

2023-01-09 18:05:37 +00:00

ALBS-901: New service albs-oval-errata-dif

Not sure if we want to add a timestamp or the like to both the diff and log files. As my previous comment, anything against merging this as it is

jhernandez commented on pull request kzhukov/albs-oval-errata-diff#1

2023-01-09 18:02:59 +00:00

ALBS-901: New service albs-oval-errata-dif

It's rare, but security advisories can also be RHBAs or RHEAs. Up to you if want to add this to the logic, nothing against merging this as it is now.

jhernandez commented on pull request kzhukov/albs-oval-errata-diff#1

2023-01-09 18:00:00 +00:00

ALBS-901: New service albs-oval-errata-dif

Extra whitespaces between start and services

jhernandez pushed tag 0.0.6 to almalinux/cas_wrapper

2022-11-10 10:17:57 +00:00

jhernandez merged pull request almalinux/cas_wrapper#6

2022-11-10 10:15:43 +00:00

ALBS-662: Added the ability to authenticate other CAS users' artifacts

jhernandez pushed to master at almalinux/cas_wrapper

2022-11-10 10:15:43 +00:00

d9c09a5d58 Merge pull request #6 from jhernandez/ALBS-662

a78784fee4 New version 0.0.6

4ced19c78c ALBS-662: Added the ability to authenticate other CAS users' artifacts

Compare 3 commits »

jhernandez pushed to ALBS-662 at jhernandez/cas_wrapper

2022-11-10 10:10:25 +00:00

a78784fee4 New version 0.0.6

jhernandez created pull request almalinux/cas_wrapper#6

2022-11-08 13:05:06 +00:00

ALBS-662: Added the ability to authenticate other CAS users' artifacts

jhernandez created branch ALBS-662 in jhernandez/cas_wrapper

2022-11-08 13:04:38 +00:00

jhernandez pushed to ALBS-662 at jhernandez/cas_wrapper

2022-11-08 13:04:38 +00:00

4ced19c78c ALBS-662: Added the ability to authenticate other CAS users' artifacts

211d4521c0 Merge pull request 'Added notarize_no_exc method to return success state instead of raising the exception' (#5) from albs-637 into master

de5d91217f Fixed review comments

7093f13a10 Added notarize_no_exc method to return success state instead of raising the exception

49c4c97645 Merge pull request 'ALBS-639: Create a CLI tool to generate SBOM' (#4) from ALBS-639 into master

Compare 9 commits »

jhernandez commented on pull request almalinux/pungi#9

2022-11-08 12:46:16 +00:00

ALBS-732

Ok, not all tests are commented, my mistake.

jhernandez commented on pull request almalinux/pungi#9

2022-11-08 12:44:11 +00:00

ALBS-732

Is it really needed? I see that tests are commented.