almalinux/pungi
15
2
Fork 0
Code Issues Pull Requests Releases Activity

ALBS-732 #9

Merged
soksanichenko merged 6 commits from ALBS-732 into a8 2022-11-11 21:39:42 +00:00
Conversation 0 Commits 6 Files Changed 3 +48 -5
soksanichenko commented 2022-11-07 21:13:23 +00:00
Owner
Copy Link
No description provided.
soksanichenko added 3 commits 2022-11-07 21:13:24 +00:00 
- Some tiny changes (pep8 & stronger condition)
- Rpm package `python3-pgpy` is added as dependency
soksanichenko added 1 commit 2022-11-07 21:14:36 +00:00 
- Rpm package `python3-pgpy` is added as build dependency
soksanichenko added 1 commit 2022-11-07 21:51:19 +00:00 
- Fix unittests
soksanichenko added 1 commit 2022-11-07 22:36:51 +00:00
Korulag approved these changes 2022-11-08 11:05:08 +00:00
jhernandez reviewed 2022-11-08 12:44:11 +00:00
pungi.spec
@ -40,6 +40,7 @@ BuildRequires: python3-dogpile-cache
BuildRequires: python3-parameterized
BuildRequires: python3-gobject-base
BuildRequires: python3-dataclasses
BuildRequires: python3-pgpy
jhernandez commented 2022-11-08 12:44:11 +00:00
Member
Copy Link

Is it really needed? I see that tests are commented.
Also, shouldn't this update deseve a new changelog entry?

Is it really needed? I see that tests are commented. Also, shouldn't this update deseve a new changelog entry?
jhernandez commented 2022-11-08 12:46:16 +00:00
Member
Copy Link

Ok, not all tests are commented, my mistake.

Ok, not all tests are commented, my mistake.
soksanichenko commented 2022-11-08 12:51:18 +00:00
Author
Owner
Copy Link
  1. Yep, tests are not muted
  2. I will make direct push with bumping version and new changelog entry later.
1. Yep, tests are not muted 2. I will make direct push with bumping version and new changelog entry later.
soksanichenko merged commit f31e5fdd09 into a8 2022-11-11 21:39:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Korulag
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: almalinux/pungi#9
No description provided.
Delete Branch "ALBS-732"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?