almalinux/pungi
15
2
Fork 0
Code Issues Pull requests Releases Activity

ALBS-732 #9

Merged
soksanichenko merged 6 commits from ALBS-732 into a8 2022-11-11 21:39:42 +00:00
Conversation 2 Commits 6 Files changed 3 +48 -5
soksanichenko commented 2022-11-07 21:13:23 +00:00
Owner
Copy link
No description provided. 
- Some tiny changes (pep8 & stronger condition)
- Rpm package `python3-pgpy` is added as dependency
- Rpm package `python3-pgpy` is added as build dependency
- Fix unittests
Korulag approved these changes 2022-11-08 11:05:08 +00:00
jhernandez reviewed 2022-11-08 12:44:11 +00:00
pungi.spec
@ -40,6 +40,7 @@ BuildRequires: python3-dogpile-cache
BuildRequires: python3-parameterized
BuildRequires: python3-gobject-base
BuildRequires: python3-dataclasses
BuildRequires: python3-pgpy
jhernandez commented 2022-11-08 12:44:11 +00:00
Member
Copy link

Is it really needed? I see that tests are commented.
Also, shouldn't this update deseve a new changelog entry?

Is it really needed? I see that tests are commented. Also, shouldn't this update deseve a new changelog entry?
jhernandez commented 2022-11-08 12:46:16 +00:00
Member
Copy link

Ok, not all tests are commented, my mistake.

Ok, not all tests are commented, my mistake.
soksanichenko commented 2022-11-08 12:51:18 +00:00
Author
Owner
Copy link
  1. Yep, tests are not muted
  2. I will make direct push with bumping version and new changelog entry later.
1. Yep, tests are not muted 2. I will make direct push with bumping version and new changelog entry later.
Sign in to join this conversation.
Reviewers
No reviewers
Korulag
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
almalinux/pungi!9
No description provided.