1
0
mirror of https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git synced 2024-12-25 19:53:08 +00:00
Go to file
Adam Williamson 3df993404c needle tweaks for eurlatgr font in anaconda
Summary:
I discovered another fun font issue today. Current anaconda
images don't use the intended 'default' console font, eurlatgr.
Neither do live images, but installed systems *do*.

The font they use is the system BIOS font, which in openQA
cases means the qemu firmware font. The easiest way to spot the
difference is the @ character; the shorter version is from the
system BIOS, the slightly taller one is what it looks like in
eurlatgr and latarcyrheb-sun16 (the old default).

In a test image I built, for some reason, I *did* get eurlatgr
in the tmux console, and that broke some needle matches. After
figuring all this out, bcl has sent a lorax patch to use
eurlatgr in the installer, so it makes sense to add these fixes
to the repo for when that kicks in.

We shrink the match on root_logged_in.json by one line. This
screenshot is taken from a post-install case where the prompt
appears in the middle of the screen, and has three black rows
above the prompt; in anaconda, when the prompt appears right at
the top of the screen, there's only *two* rows of black above
it, so the match fails. This fixes that. It's been working so
far because installs have been matching root_logged_in_
rawhide20150311, which is taken with the firmware font, but
once the installer starts using eurlatgr, that won't match any
more.

We also add a new needle for the anaconda_install_source_check
_repo_added tag, taken with eurlatgr. The existing screenshot
was taken either with the firmware font or with latarcyrheb.
They both use a curly glyph for a single quote ('), while
eurlatgr uses a straight line.

This also renames the root_logged_in variant needle to be
clearer about why it's there. We'll probably need variants of
some needles until we're sure lives, anaconda env, and installed
systems are all using eurlatgr. RHBZ #1250262 is a bug I filed
for the live images not using eurlatgr.

Test Plan:
Run the tests with both BIOS font and eurlatgr as
the anaconda font and make sure they all work. The latter
might be a bit tricky till the change lands upstream, I've no
idea how it worked out that way in my test boot.iso.

Reviewers: jskladan, garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D483
2015-08-05 09:15:41 -07:00
lib add comments and documentation 2015-08-05 08:23:59 +02:00
needles needle tweaks for eurlatgr font in anaconda 2015-08-05 09:15:41 -07:00
tests add comments and documentation 2015-08-05 08:23:59 +02:00
.arcconfig we will use develop branch 2015-03-18 13:28:43 +01:00
.gitignore .gitignore 2015-02-03 14:00:53 +01:00
COPYING Decoupled tools from tests 2015-01-26 14:43:01 +01:00
main.pm add comments and documentation 2015-08-05 08:23:59 +02:00
README.md add comments and documentation 2015-08-05 08:23:59 +02:00
templates revise storage: better test loading, shared disk selection 2015-07-31 01:31:27 -07:00

OpenQA tests for the Fedora distribution

This repository contains tests and images for testing Fedora with OpenQA. For additional tools, Installation Guide and Docker images, see this repository.

Test development

See official documentation on basic concept, test development (including API specification), needles specification and supported variables for backend. See this example repo on how tests should be structured.

In short, since OpenQA uses only one entrypoint for all tests (main.pm), we have decided to utilize this feature and make tests modular. It means that basic passing through main.pm (without any variables set) results in most basic installation test executed. Developer can then customize it with additional variables (for example by setting PACKAGE_SET=minimal to do installation only with minimal package set).

Make your test modular, so that it utilizes _boot_to_anaconda() and _do_install_and_reboot() tests (that are loaded automatically). Break your test into smaller parts, each dealing with one specific feature (e. g. partitioning, user creation...) and add their loading into main.pm based on reasonable variable setting (so they can be used in other tests also).

Test inheritance

Your test can inherit from basetest, fedorabase, installedtest or anacondatest.

  • basetest is basic class provided by os-autoinst - it has empty post_fail_hook() and doesn't set any flags.
  • fedorabase doesn't neither set flags nor does anything in post_fail_hook(), but it provides basic functions that will be useful during testing Fedora, like console_login() or boot_to_login_screen(). It should be used when no other, more specific class can be used.
  • anacondatest should be used in tests where Anaconda is running. It uploads Anaconda logs (for example anaconda.log or packaging.log) in post_fail_hook(). It also provides convenient methods for Anaconda like select_disks().
  • installedtest should be used in tests that are running on installed system (either in postinstall phase or in upgrade tests). It uploads /var/log in post_fail_hook().

Test development checklist

  1. Select test from this document or from phabricator page
  2. Put each part of your test as a separate file into tests/ directory, reimplementing run() method and test_flags() method, inheriting from one of the classes mentioned above.
  3. Set correct variables (so that all test parts you have made are executed) in WebUI -> Test suites.
  4. Link your newly created Test suite to medium type in WebUI -> Job groups.
  5. Run test (see openqa_fedora_tools repository).
  6. Create needles (images) by using interactive mode and needles editor in WebUI.
  7. Add new Job template and Test suite into templates file.
  8. Add new Test suite and Test case into conf_test_suites.py file in openqa_fedora_tools repository.
  9. Mark your test in PhaseSeparation.md as done.
  10. Open differential request via phabricator.