mirror of
https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git
synced 2024-11-21 13:33:08 +00:00
needle tweaks for eurlatgr font in anaconda
Summary: I discovered another fun font issue today. Current anaconda images don't use the intended 'default' console font, eurlatgr. Neither do live images, but installed systems *do*. The font they use is the system BIOS font, which in openQA cases means the qemu firmware font. The easiest way to spot the difference is the @ character; the shorter version is from the system BIOS, the slightly taller one is what it looks like in eurlatgr and latarcyrheb-sun16 (the old default). In a test image I built, for some reason, I *did* get eurlatgr in the tmux console, and that broke some needle matches. After figuring all this out, bcl has sent a lorax patch to use eurlatgr in the installer, so it makes sense to add these fixes to the repo for when that kicks in. We shrink the match on root_logged_in.json by one line. This screenshot is taken from a post-install case where the prompt appears in the middle of the screen, and has three black rows above the prompt; in anaconda, when the prompt appears right at the top of the screen, there's only *two* rows of black above it, so the match fails. This fixes that. It's been working so far because installs have been matching root_logged_in_ rawhide20150311, which is taken with the firmware font, but once the installer starts using eurlatgr, that won't match any more. We also add a new needle for the anaconda_install_source_check _repo_added tag, taken with eurlatgr. The existing screenshot was taken either with the firmware font or with latarcyrheb. They both use a curly glyph for a single quote ('), while eurlatgr uses a straight line. This also renames the root_logged_in variant needle to be clearer about why it's there. We'll probably need variants of some needles until we're sure lives, anaconda env, and installed systems are all using eurlatgr. RHBZ #1250262 is a bug I filed for the live images not using eurlatgr. Test Plan: Run the tests with both BIOS font and eurlatgr as the anaconda font and make sure they all work. The latter might be a bit tricky till the change lands upstream, I've no idea how it worked out that way in my test boot.iso. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D483
This commit is contained in:
parent
ce4cf5d022
commit
3df993404c
@ -0,0 +1,18 @@
|
||||
{
|
||||
"tags": [
|
||||
"anaconda_install_source_check_repo_added",
|
||||
"ENV-DISTRI-fedora",
|
||||
"ENV-INSTLANG-en_US",
|
||||
"ENV-OFW-1",
|
||||
"ENV-FLAVOR-server"
|
||||
],
|
||||
"area": [
|
||||
{
|
||||
"ypos": 17,
|
||||
"height": 14,
|
||||
"xpos": 102,
|
||||
"type": "match",
|
||||
"width": 304
|
||||
}
|
||||
]
|
||||
}
|
BIN
needles/anaconda_install_source_check_repo_added_eurlatgr.png
Normal file
BIN
needles/anaconda_install_source_check_repo_added_eurlatgr.png
Normal file
Binary file not shown.
After Width: | Height: | Size: 9.7 KiB |
@ -1,11 +1,11 @@
|
||||
{
|
||||
"area": [
|
||||
{
|
||||
"height": 17,
|
||||
"height": 16,
|
||||
"type": "match",
|
||||
"width": 40,
|
||||
"xpos": 7,
|
||||
"ypos": 111
|
||||
"ypos": 112
|
||||
},
|
||||
{
|
||||
"height": 14,
|
||||
@ -23,4 +23,4 @@
|
||||
"ENV-INSTLANG-en_US",
|
||||
"ENV-FLAVOR-server"
|
||||
]
|
||||
}
|
||||
}
|
||||
|
Before Width: | Height: | Size: 6.6 KiB After Width: | Height: | Size: 6.6 KiB |
Loading…
Reference in New Issue
Block a user