Commit Graph

865 Commits

Author SHA1 Message Date
Adam Williamson f7a8550258 Create biosboot partitions in blivet tests
From anaconda-37.12.1, anaconda defaults to GPT for all BIOS
installs. So we need to create a BIOS boot partition when doing
a BIOS install. I think all other potential configs (x86_64
UEFI, aarch64 (UEFI), ppc64le (OFW)) are covered under the other
two paths, so just making this `else` should be OK.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-08-16 15:39:38 -04:00
Adam Williamson 58fbcf31f2 Tweak Clocks world clock test removal loop to be more robust
We need to move the mouse out of the way so we don't need two
needles for "X not highlighted" and "X highlighted", and give
the check_screen a few seconds to update for the cursor move.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-08-16 10:05:26 -04:00
Adam Williamson 8479cb979f Remove nautilus side panel test and associated needles
The show/hide side panel functionality was intentionally removed
in version 43-beta:

https://gitlab.gnome.org/GNOME/nautilus/-/issues/2427

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-08-16 08:53:42 -04:00
Lukas Ruzicka e69ba53f51 Fix the Clocks test to work on Fedora 37. 2022-08-15 16:47:46 +02:00
Adam Williamson 228fdcf42b Update nautilus needles and star_file test for 43-beta
"Star" was removed from the file context menu, so we have to
star the file from the main view now.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-08-11 09:40:15 -07:00
Adam Williamson e2e8fcadd4 Rationalize GNOME credit button handling
We had a ton of needles all covering something very similar
(press a "Credits" button in a GNOME app). There are about four
real variations: old-style regular face white-on-black (eog),
old-style regular face (nautilus and evince before recent
libadwaita ports), old-style bold face (GTE and Clocks before
new libadwaita), and new-style (everything that's been ported
to use libadwaita for its About page). Let's just rationalize
it down to those, using the same needle tag for all of them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-08-08 18:24:57 -07:00
Lukáš Růžička 9e0ec721a6 Create a new test for Gnome Weather 2022-08-08 18:24:51 -07:00
Lukáš Růžička c40a35ea62 Add a new test for Calculator. 2022-08-05 11:34:22 -07:00
Adam Williamson fcbcaaf59a anaconda_help: don't include 'root' in the root password
anaconda now warns about this and it breaks things.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-08-05 11:28:24 -07:00
Adam Williamson 1a65993d36 Add a perltidy check and apply it to the entire codebase
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-28 14:38:38 -07:00
Adam Williamson 8ce8a7fe65 clocks/world: search for "Reykjav" not "Reykjavik"
The city is called Reykjavík (note the í). Previously our search
worked because the search function also looked in the name of the
timezone, and the *timezone* name is "Atlantic/Reykjavik" - i.e.
it's really Latin-ized in the name of the timezone. However,
upstream intentionally stopped including the timezone name in
search matches:
https://gitlab.gnome.org/GNOME/gnome-clocks/-/merge_requests/199
so that doesn't work any more. Just searching for "Reykjav"
should solve the problem.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-25 16:50:17 -07:00
Adam Williamson b7dea9f80c gnome-text-editor: don't check 'System' tab in About
In 43-alpha it's gone, the replacement is Troubleshooting ->
Debugging Information. But it would be a pain to write two
forks in the code for handling both cases, and there's a ton
more stuff in the new-style About dialog that we're not
checking either. I don't think we really need to click on all
of it, and this bit of it isn't super important. So on the
whole I'd rather just keep things simple and drop this check.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-25 16:41:46 -07:00
Adam Williamson 9495cfb1ff Update nautilus tests and needles for 43~alpha
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-22 17:24:43 -07:00
Adam Williamson 84c6e18f14 Reduce duplication of nautilus Documents directory needles
We had three. We only need one, matching on the sidebar entry,
which should be always visible.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-22 17:17:59 -07:00
Adam Williamson dcda535db0 gnome-text-editor: make sure to overwrite prefilled filename
the new_file test failed today because it seems g-t-e now pre-
fills a suggested filename, with extension, and pre-selects the
name part but not the extension part. So when we type 'list.md'
we wound up saving the file as 'list.md.md'. I think hitting
ctrl-a should fix this, and not break when run on older versions
of g-t-e if we ever do that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-22 12:24:09 -07:00
Lukáš Růžička 621f6c13b5 Add wait time to let the application start properly. 2022-07-19 14:49:26 +02:00
Adam Williamson 2ee0377ece nautilus/move_file_into: fix whitespace errors
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-15 11:28:58 -07:00
Adam Williamson f84792f819 nautilus/move_file_into: be more defensive
This is to try and fix some issues on aarch64.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-15 11:28:15 -07:00
Adam Williamson ef76c76024 help.pm: wait longer for main screen to appear
Looks like it can take longer than 45s on aarch64.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-15 11:20:36 -07:00
Adam Williamson f407ceaf0e help.pm: fix whitespace errors
Lots of use of tabs instead of spaces, spaces at ends of lines,
spaces on blank lines...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-15 11:20:09 -07:00
Adam Williamson f67bcef9f7 g-t-e: extend sleep in one test, add in another
aarch64 looks like it often needs more time to settle after
restoring from snapshot before trying a key combo.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-15 11:15:52 -07:00
Lukáš Růžička 48ec73e814 Create a test suite for Nautilus. 2022-07-12 16:01:36 -07:00
Adam Williamson 14942f86e7 Some safety around Discover maximize in desktop_update_graphical
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-08 15:58:11 -07:00
Adam Williamson 788b7167b1 clocks: add missing needle, improve tag name
That last commit to 'fix' the Clocks tests when Silverblue needs
location access to be granted wasn't complete, I left the needle
out. D'oh. Take the chance to give it a better name too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-07 14:28:59 -07:00
Adam Williamson cf969061ce Wait for Discover to run before maximizing it
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-04 10:07:13 -07:00
Adam Williamson be39c0e3a1 desktop_update_graphical: maximize Discover on launch
If there are too many categories, we don't see the Updates entry
on the left, and this has been breaking Rawhide and F36 tests.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-04 09:47:56 -07:00
Lukáš Růžička 1f8b56e068 Change the way to download test data.
This PR changes the way to download the test data into the VM.
Although it does not use a disk image as suggested in one
of the review, it does not clone the entire repository, but
a simple tar.gz file that holds the data which will be
distributed into the directory structure.

This way, the amount of data needed to be downloaded dropped
from approximately 50MB to below 2MB.

Also, the existing test suites were adapted to this situation.
2022-07-04 09:34:04 +02:00
Adam Williamson f81dab6739 Clocks: handle auth, check we actually launched the app
Clocks' aaa_setup did not ever actually check the app launched
properly. It also doesn't handle granting permissions if
necessary, which the apps_startstop test for Clocks does do.

This makes the permission check in the apps_startstop test more
efficient, and adds it to the Clocks app aaa_setup test too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-06-30 13:56:29 -07:00
Lukáš Růžička 7c1e686d14 Create tests for Help. 2022-06-29 23:06:37 +00:00
Adam Williamson d5757b054c Fix assert_and_click call in realmd_join_cockpit
This was just doing something silly before, but with recent
os-autoinst having function signatures, it actually causes the
test to fail because '5' isn't a sane value for the argument
this was setting before. Fix it to set the timeout, as it was
trying to do all along.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-06-27 09:21:48 -07:00
Lukáš Růžička 6f00e3fe8a Create tests for Clocks. 2022-06-23 21:41:56 +00:00
Adam Williamson b203f41f55 Give `systemctl stop ipa.service` longer due to RHBZ #2100282
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-06-22 17:51:04 -07:00
Lukáš Růžička d09d9d8fe6 Fix the Rhythmbox crash when launched for the first time. 2022-06-15 15:53:20 +02:00
Adam Williamson 4971de39e9 Tweak quit_firefox to handle hang on exit on ppc64le (#2094137)
It seems when we quit Firefox back to a VT on ppc64le, the system
hangs. Not sure why, but we can deal with it by rebooting the
system and logging back in as root if it happens. Also take the
opportunity to clean up the flow of quit_firefox so we always
check that we get back to a console then wait 5 seconds for the
console to settle, so all the tests that call it can stop doing
that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-06-06 18:35:52 -07:00
Adam Williamson e1ed9960f3 Let _console_avc_crash wait a bit longer for console login
On Rawhide update tests we often don't seem to get to the login
prompt in 10 seconds, so tweak the code a bit to let us specify
a timeout in root_console, and use 30 seconds here.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-06-06 18:34:44 -07:00
Adam Williamson e047a88ffc check_default_fonts: move reference files, use diff -u
Let's not have the reference files in one person's fedorapeople
space, in case that person leaves. Let's upload the text.txt
for checking (it's easier to be able to just read what's in it
than try and figure it out from the diff output), and let's use
diff -u because non-unified diff output is awful.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-06-02 14:36:33 -07:00
Adam Williamson aa5a248237 Bump timeouts in _setup_browser a bit more
Slow on Rawhide updates.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-06-01 09:00:39 -07:00
Adam Williamson e9a7e0eb6c Give `dracut -f` longer to run in _advisory_update
It seems slow on Rawhide updates ATM.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-06-01 08:56:27 -07:00
Adam Williamson 815c6b28e5 check_default_fonts: wait_still_screen after launching terminal
As we do in desktop_terminal. It's not always ready for input
when the window is visible.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-05-27 11:01:27 -07:00
Lukáš Růžička 1acef21fa5 Automate the i18n_default_fonts testcase for Japanese.
This is the automation of the optional testcase https://fedoraproject.org/wiki/QA:Testcase_i18n_default_fonts.
The test implementation runs the same commands as the mentioned test
case and checks the expected output. It is designed to run in the scope
of postinstall tests when the language is set to "japanese".
2022-05-26 09:54:38 +02:00
Adam Williamson 66bc59de1d Have desktop_browser run disable_firefox_studies
I'd prefer not to do this, but I don't see a better way to deal
with the stupid 'welcome' screens. I'm not maintaining needles
to click them away forever.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-05-24 23:51:59 -07:00
Adam Williamson bd9e17dc85 Update FIXME note on #1765685 workaround
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-05-17 16:04:28 -07:00
Adam Williamson b24802d4e0 Update a FIXME note in VNC client test
Connections is now default, we just have to update the test to
use it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-05-16 16:33:40 -07:00
Adam Williamson 4d049f8f7d browser: drop download save screen handling
Firefox 97 is now stable on all releases, so we can forget about
handling browser_download_save and just assume download will
happen automatically.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-05-16 16:27:35 -07:00
Adam Williamson 428b022255 Drop new user g-i-s handling in _graphical_wait_login
New user g-i-s is gone since F34, and F33 is dead.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-05-16 16:15:52 -07:00
Adam Williamson 5beb87cc16 Drop another unnecessary release number condition
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-05-16 16:14:02 -07:00
Adam Williamson a2df6d976b desktop_login: drop obsolete check for 'login failed' message
Up to F33 we could check that an error message was shown when we
tried to log in with the wrong password on GNOME, but since F34
it's transient and disappears too quick to reliably catch, so
we don't check it any more. Now F33 is EOL, drop the conditional.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-05-16 16:11:52 -07:00
Adam Williamson 77cadae5d4 Drop g-i-s disablement in desktop_login
The g-i-s new user mode was removed in F34, so we don't need to
do this any more (as the now-removed comment said).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-05-16 16:09:28 -07:00
Adam Williamson 375c7409af Drop another unnecessary release number condition
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-05-16 16:07:59 -07:00
Adam Williamson 381e3e3561 Drop a now-unnecessary release number conditional in a check
We're never testing a release lower than 34 again.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-05-16 16:05:15 -07:00