Rationalize GNOME credit button handling

We had a ton of needles all covering something very similar
(press a "Credits" button in a GNOME app). There are about four
real variations: old-style regular face white-on-black (eog),
old-style regular face (nautilus and evince before recent
libadwaita ports), old-style bold face (GTE and Clocks before
new libadwaita), and new-style (everything that's been ported
to use libadwaita for its About page). Let's just rationalize
it down to those, using the same needle tag for all of them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

needles/gnome/apps/evince/evince_about_credits.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 546,
-      "ypos": 224,
-      "width": 53,
-      "height": 21,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "evince_about_credits"
-  ]
-}

needles/gnome/apps/gnome-text-editor/gte_about_credits-20220204.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 484,
-      "ypos": 243,
-      "width": 54,
-      "height": 18,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "gte_about_credits"
-  ]
-}

needles/gnome/apps/gnome-text-editor/gte_about_credits-20220304.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "height": 18,
-      "ypos": 243,
-      "type": "match",
-      "xpos": 484,
-      "width": 54
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "gte_about_credits"
-  ]
-}

needles/gnome/apps/gnome-text-editor/gte_about_credits-20220723.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "ypos": 631,
-      "height": 18,
-      "type": "match",
-      "width": 54,
-      "xpos": 355
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "gte_about_credits"
-  ]
-}

needles/gnome/gnome_button_credits-eog-dark.json

@@ -10,6 +10,6 @@
   ],
   "properties": [],
   "tags": [
-    "eog_about_credits"
+    "gnome_button_credits"
   ]
-}
+}

needles/gnome/gnome_button_credits-libadwaita-20220722.json

@@ -10,6 +10,6 @@
   ],
   "properties": [],
   "tags": [
-    "nautilus_about_credits"
+    "gnome_button_credits"
   ]
-}
+}

needles/gnome/gnome_button_credits-regular.json

@@ -10,6 +10,6 @@
   ],
   "properties": [],
   "tags": [
-    "nautilus_about_credits"
+    "gnome_button_credits"
   ]
-}
+}

tests/applications/eog/about.pm

@@ -16,7 +16,7 @@ sub run {
     wait_still_screen(3);
     assert_screen("eog_about_shown");
     # Click on Credits
-    assert_and_click("eog_about_credits");
+    assert_and_click("gnome_button_credits");
     wait_still_screen(2);
     assert_screen("eog_credits_shown");
 }

tests/applications/evince/about.pm

@@ -19,7 +19,7 @@ sub run {
     assert_screen("evince_about_shown");
 
     # Click on Credits button to see the second part of the dialogue.
-    assert_and_click("evince_about_credits", button => "left", timeout => 30);
+    assert_and_click("gnome_button_credits", button => "left", timeout => 30);
 
     # Check that Credits are accessible and visible, too.
     assert_screen("evince_credits_shown");

tests/applications/gnome-text-editor/about.pm

@@ -19,7 +19,7 @@ sub run {
     assert_screen "gte_about_shown";
 
     # Click on Credits to move to another screen.
-    assert_and_click "gte_about_credits";
+    assert_and_click "gnome_button_credits";
     wait_still_screen(2);
 
     # Check that Credits were shown.

tests/applications/nautilus/about.pm

@@ -19,7 +19,7 @@ sub run {
     assert_screen("nautilus_about_show");
 
     # Click on Credits button to see the second part of the dialogue.
-    assert_and_click("nautilus_about_credits", button => "left", timeout => 30);
+    assert_and_click("gnome_button_credits", button => "left", timeout => 30);
 
     # Check that Credits are accessible and visible, too.
     assert_screen("nautilus_credits_shown");