This reverts commit a2c6f88fab.
Turns out this change was a bug in adobe-source-code-pro-fonts -
if we see this again, it's bad news and we shouldn't accept it.
An F39 Change has changed the default prompt in color terminals.
Several needles need updating for this.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Loupe replaced EOG as the image viewer in F39 and Rawhide. We
need to update several needles for this: its icon is different,
the change affected the appearance of the Utilities submenu
icon, its main UI looks different, and it uses a light colored
file chooser which requires some variant needles for the Maps
export image test.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
EOG has been replaced by Loupe in F39+. We will need to add a
test for Loupe, but first let's remove the EOG test so it does
not fail on every compose.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This is tailored to the initial deployment of webUI in
Workstation live images only; we may need to tweak flows and
approaches as webUI goes further.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Lukas added these in a recent big commit that fixed problems with
GNOME 45, I think these two were probably needles from some
in-development tests that are not actually needed in prod yet.
They make the tests fail, so we need to get rid of them.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
These are all the new needles for the 'no blue outline on
password entry box any more' issue. The naming was a bit non-
standard and they were not in the right directories, and they
need to be actually tagged as workarounds, like the English
one is. Also, add the correct issue link to the workaround note
for the English one.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
The names need to follow the same convention as all the others,
and the needles should have the _active tag as well as the
generic one.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
The 'global' app menu is no longer shown, which affects the
apps_run_terminal needle (it will affect many others for the
compose tests, but this is just for updates tests). It seems we
sometimes have the cursor over the Activities button and it
looks slightly different in that case, so add a variant needle
for that. Finally, the password input box in GDM is no longer
highlighted in blue as it probably should be to indicate that
it's active, so add a workaround needle to handle that.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
They all should have LANGUAGE-turkish tag so they aren't used
on any other language. One got put in the wrong place and not
named clearly. And install_lang_english_selected-20230619.json
doesn't seem like it would ever be used.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This adds a Samba AD server test, and client enrolment tests via
sssd, Cockpit and kickstart. Requires the matching createhdds
commit to add the kickstart to the disk_ks image.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
We actually untagged 45~alpha due to a bug, but presumably it'll
still look like this when that bug is fixed, so let's just have
these needles ready.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Looks like the GNOME icon theme changed a bit in Rawhide, here
are several required needle updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
The Flatpak build doesn't have the spellcheck issue at the
moment, and it may be fixed soon in the RPM build. Trying to
'fix' the issue on the flatpak build actually makes the test
fail. So, let's only do the fix if we actually have a misspelled
word.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Aside from g-t-e which requires some more logic change I'll do
in the morning, this should be everything.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Looks like a shade of grey changed a bit. There will be more
changes for the compose tests, but this fixes the update tests
at least.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
The editor started to show spell-checking that would require a lot
of new needles to be created. Theredore, we set the language to
English to stop showing the spelling mistakes in aaa_setup.pm
Also, the application started to have problems with getting correct
focus, so we want to click into the text before the status gets
recorded.
It's not in the images any more. As aleasto pointed out, we're
actually being sent to Discover to install it, and matching on
*that* screen, which isn't what we intend.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Per the upstream issue, this change was intentional (as a 'least
worst' option), so we shouldn't mark the needle as workaround.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Add a link to the issue report for blivet-gui using an odd icon
for btrfs volumes, now I finally filed it.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
For a while, it seems like the test was often hitting a message
where the field we match on isn't actually visible because a lot
of other fields are shown first. So, add a variant needle that
matches on a different field, the message ID.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
https://github.com/storaged-project/udisks/issues/1102 - udisks2
seems to have a bug where it leaves filesystems mounted at a
"temporary" mount point after creating them. We need to work
around this when it happens or else we'll frequently get test
failures.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
These hit low-90% matches when run on the F38 respins for some
reason, just add another variant...
Signed-off-by: Adam Williamson <awilliam@redhat.com>
In https://openqa.fedoraproject.org/tests/1938847 , we wound up
doing an LVM thinp install when we meant to do a regular LVM
install, because LVM was already highlighted (for some reason)
in the scheme list, and the "LVM" needle is narrow enough that
it matched on the start of "LVM Thin Provisioning".
To avoid this, we make the match area in the existing needle
wider so it can't match on "LVM Thin Provisioning", and add an
alternate needle for LVM when it's highlighted.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
I don't know exactly why this sometimes shows up highlighted and
sometimes unhighlighted, but hey, it's not wrong either way, so
we just handle it.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
We never hit this path without a system menu button any more,
due to changes in KDE over time. It hasn't been hit for two years.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Now both GNOME and KDE do offline updates on all supported
releases, we never see an 'update done' screen any more. This
branch is left over from when the KDE offline update branch was
still conditional on release number.
If we ever implement this test on a desktop that doesn't do
offline updates, we can put this back easily enough.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
There's no need to do all this 'check whether it's selected and
click it if not' stuff (for three different mount points). Just
always click it. If it's already selected, clicking it again
doesn't hurt (one of these stanzas even clicks it *even if it's
selected*!)
If we need to cover both cases, we just need two needles with
the same tag, we don't need separate code paths. In each case,
though, we actually haven't matched one of the needles for ages
(the most recent was part_boot_selected, but now we're using
GPT by default, we won't hit that any more as it'll be the BIOS
boot partition that's selected by default), so delete the needles
we aren't matching any more. If we *do* hit any case where we
need to handle the 'other' state, we can just add the alternative
needle with the same tag.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This has not been hit for a year (on stg; three years on prod).
I *think* it would only be hit if we ran the test on an Everything
image, but as the test is now specifically associated with the
Server install DVD, that doesn't seem likely to happen.
If we somehow *do* hit ext4 pre-selected again, this can still
be handled simply by adding an alternate
anaconda_blivet_part_fs_ext4 needle which matches on ext4 already
being selected; that avoids the need to keep an alternate code
path around.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This branch is very fragile, because the test won't fail if we
miss the match on the security needle. So in practice, we are
never going to notice when the needle goes stale, and we'll just
wind up never triggering this branch and always going down the
other path. That's the current situation: the security_install
needle last matched more than a year ago at least. Let's just
admit the truth here and drop the branch entirely.
Also update the cockpit_updates_restart_ignore needle. This is
in a similar case - we don't really notice when it goes stale,
as the test completes, it just takes a bit longer - but since
this one is quite easy to find, let's just update it instead of
dropping it.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This was resolved upstream and we're no longer hitting this bug
in tests on F38, Rawhide or even F37 respins, so we should no
longer need this workaround.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
It looks like neither of these has been a problem for some time.
The notification needle has not matched for a year. The akonadi
needle doesn't exist any more - it was cleaned up in the 2021
needle cleanup, meaning it hadn't matched for weeks in 2021. I
checked the last several months of KDE app start/stop tests and
don't see any case where there was a stray notification that we
missed. So I think we can just ditch this whole mechanism for
now; if we have problems with these notifications again in future
we can put it back.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
The last one of these was deleted during the last needle cleanup,
but we do actually still occasionally hit the dialog, e.g. in
https://openqa.fedoraproject.org/tests/1837435/modules/kontakt/steps/3
so let's add an updated version of the needle.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
I think the shade of grey on the background changed. We'll
probably need more needle updates for the compose tests (the
desktop_login test and different languages), but this covers the
update tests.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
In today's Rawhide, for some reason, after we delete the first
file, the second file we want to delete is highlighted.
Previously the other file in the directory was highlighted. No
biggie, just handle both cases.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
There's a difference in the Info page and we get every font
twice on Silverblue because they're present in two locations.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This actually hasn't matched for years, we've been falling back
to ctrl-t the entire time. Happened to notice it today while
debugging https://bugzilla.redhat.com/show_bug.cgi?id=2184549
Signed-off-by: Adam Williamson <awilliam@redhat.com>
These variants only show up when a security update is in play,
so not very often; this happened today, so now we get to update
them for current KDE.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
The font rendering on this URL bar seems to be slightly unstable
for some reason. We got a 95% match on this needle in
https://openqa.fedoraproject.org/tests/1846906#step/about/10
so let's just bump the level down a bit.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
...for the GNOME icon theme change. This needle isn't hit very
often so it didn't get updated with the others.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
They've dropped the IRC section from this page. We don't really
need three match areas, just the two is sufficient to identify
it.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This test hasn't run for a long time due to
https://bugzilla.redhat.com/show_bug.cgi?id=2151607 , now we got
it working again, almost all the needles need updating.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
If the cursor is visible in the middle of the screen, this would
not match. So move the match area a bit
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Contacts now has two burger menus, which is awkward. We need
specific needles to identify each, we can't rely on the generic
needle any more as it won't always open the right menu. We also
need to still work with the old UI for the flatpak.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
KDE has a welcome tour now, on F38 and Rawhide at least. Let's
"handle" it with extreme prejudice...
Signed-off-by: Adam Williamson <awilliam@redhat.com>
We still need to handle 43 only requiring one for now, and we
can't just make it release-dependent until 44 is stable for both
38 and Rawhide, so let's use a needle match temporarily. Only
44 has these eye/pencil icons on this screen.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
These are similar to the changes in F37 and Rawhide, but these
needles are specific to F36 somehow so weren't updated in earlier
rounds.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
KDE live installer started looking different on F37 too so we
need a new needle there, plus we need F39 needles now Rawhide is
F39.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
In today's F38 and Rawhide, changes to the persistent overlay
stuff result in a boot warning you have to spam through. Let's
handle this as a soft fail so we don't have floods of failed
tests till it's fixed.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Looks like what happened here is font kerning changed (got
better) in the nm-connection-editor spawned from anaconda.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
A lot of these are because anaconda is more KDE-themed on the
KDE live ISO now. The rest are just miscellaneous appearance
changes to KDE apps in recent Rawhide.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Bike route changed again. For the website opened needle, the
URL bar text seems to keep changing slightly, so instead let's
try matching on the big app logo...hopefully that won't change
as much.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Now we sometimes have to scroll the page down to add the addon,
the Remove button isn't always fully visible behind the popup.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
"Additional repositories" is now hidden behind a dropdown we
have to open first. This will make the test fail on anything
older than Fedora-Rawhide-20230121.n.0, but I don't think we
run this test anywhere that would be a problem.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This PR adds a small test suite to test the Characters applications.
It displays several different groups of characters and then tries
to copy one of the characters and place it into a text editor.
GNOME Software no longer has a welcome screen in any current
Fedora (it was dropped between 35 and 36), but in Rawhide it now
has a popup that prompts you to enable third-party repos which
we need to get rid of, so just convert the welcome screen check
to handle that, and drop all the welcome screen needles.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This test fails on Rawhide (because sddm-on-wayland) but we just
got an F37 respin, where it passes but needs some needle updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
All the deleted ones haven't been matched for five months. Drop
match level to 90 on the remaining ones, we got a 96 match for
one of them in today's respin test.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
I don't know why we wind up with so many slightly different
matches on the login screen. It's weird.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
it's really just a dupe of the -problems needles, it turns out,
Lukas was reinventing that wheel. He had to add another one
today because I broke the JSON in this one when I was simplifying
it yesterday, but I think this one on the new -problems needle
are really just dupes.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
* Scarborough provided quite a messy map that resulted
in frequent needle failure. Changing the location
for something better to make it more reliable.
* The zoom test could have failed with a low resolution
image. Adding some timeout to the needle give more
time to load the proper image.
I think these needles are pretty fragile to changes in the
underlying OSM dataset, not just in Maps itself...
Signed-off-by: Adam Williamson <awilliam@redhat.com>
