Drop click_unwanted_notifications (and associated needle)

It looks like neither of these has been a problem for some time.
The notification needle has not matched for a year. The akonadi
needle doesn't exist any more - it was cleaned up in the 2021
needle cleanup, meaning it hadn't matched for weeks in 2021. I
checked the last several months of KDE app start/stop tests and
don't see any case where there was a stray notification that we
missed. So I think we can just ditch this whole mechanism for
now; if we have problems with these notifications again in future
we can put it back.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

lib/utils.pm

@@ -7,7 +7,7 @@ use Exporter;
 
 use lockapi;
 use testapi;
-our @EXPORT = qw/run_with_error_check type_safely type_very_safely desktop_vt boot_to_login_screen console_login console_switch_layout desktop_switch_layout console_loadkeys_us do_bootloader boot_decrypt check_release menu_launch_type repo_setup setup_workaround_repo disable_updates_repos cleanup_workaround_repo console_initial_setup handle_welcome_screen gnome_initial_setup anaconda_create_user check_desktop download_modularity_tests quit_firefox advisory_get_installed_packages advisory_check_nonmatching_packages start_with_launcher quit_with_shortcut disable_firefox_studies select_rescue_mode copy_devcdrom_as_isofile get_release_number check_left_bar check_top_bar check_prerelease check_version spell_version_number _assert_and_click is_branched rec_log click_unwanted_notifications repos_mirrorlist register_application get_registered_applications solidify_wallpaper check_and_install_git download_testdata make_serial_writable/;
+our @EXPORT = qw/run_with_error_check type_safely type_very_safely desktop_vt boot_to_login_screen console_login console_switch_layout desktop_switch_layout console_loadkeys_us do_bootloader boot_decrypt check_release menu_launch_type repo_setup setup_workaround_repo disable_updates_repos cleanup_workaround_repo console_initial_setup handle_welcome_screen gnome_initial_setup anaconda_create_user check_desktop download_modularity_tests quit_firefox advisory_get_installed_packages advisory_check_nonmatching_packages start_with_launcher quit_with_shortcut disable_firefox_studies select_rescue_mode copy_devcdrom_as_isofile get_release_number check_left_bar check_top_bar check_prerelease check_version spell_version_number _assert_and_click is_branched rec_log repos_mirrorlist register_application get_registered_applications solidify_wallpaper check_and_install_git download_testdata make_serial_writable/;
 
 # We introduce this global variable to hold the list of applications that have
 # registered during the apps_startstop_test when they have sucessfully run.
@@ -1452,29 +1452,6 @@ sub rec_log {
 
 }
 
-sub click_unwanted_notifications {
-    # there are a few KDE tests where at some point we want to click
-    # on all visible 'update available' notifications (there can be
-    # more than one, thanks to
-    # https://bugzilla.redhat.com/show_bug.cgi?id=1730482 ) and the
-    # buggy 'akonadi_migration_agent_running' popup if it's showing -
-    # https://bugzilla.redhat.com/show_bug.cgi?id=1716005
-    # Returns an array indicating which notifications it closed
-    wait_still_screen 5;
-    my $count = 10;
-    my @closed;
-    while ($count > 0 && check_screen "desktop_update_notification_popup", 5) {
-        $count -= 1;
-        push(@closed, 'update');
-        click_lastmatch;
-    }
-    if (check_screen "akonadi_migration_agent_running", 5) {
-        click_lastmatch;
-        push(@closed, 'akonadi');
-    }
-    return @closed;
-}
-
 # In each application test, when the application is started successfully, it
 # will register to the list of applications.
 sub register_application {

needles/kde/desktop_update_notification-kde-20220225.json

@@ -1,24 +0,0 @@
-{
-  "area": [
-    {
-      "ypos": 597,
-      "height": 17,
-      "type": "match",
-      "width": 130,
-      "xpos": 659
-    },
-    {
-      "xpos": 166,
-      "width": 13,
-      "type": "match",
-      "height": 13,
-      "ypos": 740
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "DESKTOP-kde",
-    "desktop_update_notification_popup",
-    "desktop_update_notification"
-  ]
-}

tests/apps_startstop/kde/aasetting.pm

@@ -9,8 +9,6 @@ use utils;
 sub run {
     my $self = shift;
     solidify_wallpaper;
-    # get rid of unwanted notifications that interfere with tests
-    click_unwanted_notifications;
 }
 
 sub test_flags {