Commit Graph

2604 Commits

Author SHA1 Message Date
Adam Williamson 9a0ef37a25 Revert "Update live install tests: handle awkward install ordering"
This reverts commit 56936df7a5. It
was a lovely idea, but forgot that the 'matching update version'
check doesn't actually use the allpkgs.txt list...
2023-02-22 15:55:24 -08:00
Adam Williamson 56936df7a5 Update live install tests: handle awkward install ordering
There's this awkward path for the live image install tests on
updates. We run the 'are the correct versions of all the packages
installed' check on these tests to ensure the right versions
actually made it onto the live image. So we don't run
`dnf -y update` at the end of repo_setup_updates on that path,
because if we did that, even if the packages on the live image
were old, we'd update them there and hide the problem.

However, this causes a bit of an ordering issue, because in
order to set up the advisory repo, we need to install a few
packages. What if the update under test includes one of those
packages, or a dependency that wasn't already installed? In
that case, we wind up with the older stable version of the
package (because obviously we can't install the newer version
from the advisory repo *before we've set up the advisory repo*),
don't update it later, and so the 'correct version' check at
the end of the test fails. See:
https://openqa.fedoraproject.org/tests/1778707 for a case of
this happening with a python-cryptography update.

Up till now I was trying to handle this by just updating the
specific packages we install, but that doesn't account for
*dependencies* of them. I looked down the path of trying to
generate a list of all those dependencies and update all of
them but it looks a bit mad. So instead let's try this. On that
specific path, we'll generate the "all installed packages" list
*before* we run repo_setup, so it just doesn't include anything
that gets installed during repo_setup. The implementation is a
bit icky but not too horrible.

We *could* just *always* generate the all installed packages
list earlier, but then that would mean we *wouldn't* catch dep
issues in this kind of package on the other test paths, whereas
currently we do. I don't want to lose that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-22 14:54:18 -08:00
Adam Williamson 66a899d797 Expect KDE welcome screen on F37 too
5.27.1 is going to F37, and adds it. In the short term this
will waste a minute and a half and cause soft fails on all other
F37 updates until the update that adds this goes stable, but
I don't really feel like working around this, let's just live
with it till the update goes stable.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-22 14:11:07 -08:00
Adam Williamson 822af3d025 graphical_input: try typing 'hotkey'
OK, neither 'input' nor 'keyboard' actually gives us the Keyboard
pane, they both give results for uninstalled apps from Software
:(. 'hotkey' (which is one of the keywords in the .desktop file)
does seem to work, for now at least, let's try that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-22 13:57:33 -08:00
Adam Williamson b1dfcfdd3d Contacts: handle menu changes in 44
Contacts now has two burger menus, which is awkward. We need
specific needles to identify each, we can't rely on the generic
needle any more as it won't always open the right menu. We also
need to still work with the old UI for the flatpak.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-22 12:38:02 -08:00
Adam Williamson a4ff85695b handle_welcome_screen: only set _WELCOME_DONE if we saw it
This is to handle a temporary condition where the screen isn't
present on the KDE base disk images for F38 or F39 yet, so they
only see it on the second boot on update tests, but don't handle
it because we marked it as already 'done'.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-22 08:04:29 -08:00
Adam Williamson 4254906308 Try clicking Skip on the KDE welcome tour thing
It seems like just closing it results in it showing up again on
the next boot...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-21 19:57:19 -08:00
Adam Williamson a99178732a desktop_notifications: handle KDE welcome screen on lives
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-21 18:28:28 -08:00
Adam Williamson b9500536cc Make the changed handle_welcome_screen conditional clearer
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-21 18:22:59 -08:00
Adam Williamson ddb3f44c57 Extend handle_welcome_screen to cover new KDE welcome tour
KDE has a welcome tour now, on F38 and Rawhide at least. Let's
"handle" it with extreme prejudice...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-21 18:16:13 -08:00
Adam Williamson 6976e2e7c9 Update printing sentence check needle for KDE
Font rendering change, again.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-20 22:28:24 -08:00
Adam Williamson c83ca6e240 Update several needles for GNOME icon theme changes
We'll need more after the next compose, but this gets all the
ones we hit in update tests.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-20 22:14:00 -08:00
Adam Williamson ac1a59ef77 workarounds: kwin build that fixes VT switch for F38 and F39
The F38 update that breaks this hasn't gone stable due to gating
and the F39 update will be pulled in once the tests are done
and it goes stable, but doing this anyway so I can re-run the
tests on the F38 plasma-workspace update and push it stable,
and rerun all the failed Rawhide tests without waiting for all
the tests on this update to finish first.
2023-02-20 22:11:31 -08:00
Adam Williamson 19500a4018 drop workarounds that have gone stable
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-20 22:10:40 -08:00
Adam Williamson 7ea4ed733c Sigh, do the are-we-44 check in the right place
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-20 17:29:13 -08:00
Adam Williamson d0699217a4 Handle g-i-s 44 requiring two tabs at 'set a password' screen
We still need to handle 43 only requiring one for now, and we
can't just make it release-dependent until 44 is stable for both
38 and Rawhide, so let's use a needle match temporarily. Only
44 has these eye/pencil icons on this screen.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-20 17:13:37 -08:00
Adam Williamson b40d222cc7 Update a couple of anaconda needles for F36 KDE changes
These are similar to the changes in F37 and Rawhide, but these
needles are specific to F36 somehow so weren't updated in earlier
rounds.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-20 09:24:35 -08:00
Adam Williamson d9c27577c3 Update a bunch of GNOME needles for changes in GNOME 44
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-18 14:54:43 -08:00
Adam Williamson 020ad25638 Update KDE needles for recent Rawhide changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-18 14:50:24 -08:00
Adam Williamson 8bd29dfe21 Update several Japanese install needles
Looks like Japanese default font changes.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-18 14:49:22 -08:00
Adam Williamson 13d935eb85 graphical_input: go back to typing 'keyboard'
On GNOME 44, typing 'input' is now giving us the Software page
for PulseAudio Volume Control, for some reason. Let's try typing
'keyboard' again and hope that works again now...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-18 14:30:41 -08:00
Adam Williamson 8674e29a8e updvercheck: be OK with older update being obsolete too
In the "installed package is newer than the one in the update"
case, also be OK (soft fail) if the update is obsolete, not just
if it's stable.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-18 13:16:32 -08:00
Adam Williamson 5e2a91192f desktop_login: also give assert_shutdown longer
Can't really work a soft fail into this one.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-18 12:27:52 -08:00
Adam Williamson 3213bb9043 desktop_login: give logout longer, but soft fail
Logout seems to be taking a long time in Rawhide currently. Give
it longer to run, but soft fail. I'll add a bug link once I've
investigated and filed one.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-18 11:47:07 -08:00
Adam Williamson 5f8876691f Give _ostree_build lorax command a bit longer
It seems to be timing out a lot.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-16 20:36:14 -08:00
Adam Williamson 05f13a002d Revert "rpmostree_rebase: avoid rebasing Silverblue to 38 for now"
This reverts commit d0d37e6aca.
Turns out rebase still fails even with 37 as the target.
2023-02-16 20:36:03 -08:00
Adam Williamson d0d37e6aca rpmostree_rebase: avoid rebasing Silverblue to 38 for now
It seems to be busted:
https://github.com/fedora-silverblue/issue-tracker/issues/420
so let's just have anything that would rebase to SB 38 rebase to
SB 37 instead for now.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-16 12:04:37 -08:00
Adam Williamson 0a9abca4a6 _ostree_build: drop a stray comment
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-16 11:52:32 -08:00
Adam Williamson 5ac69f3141 Update prerelease note Arabic needle
Looks like the Arabic font changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-16 11:26:38 -08:00
Adam Williamson 856d2eb33e Add KDE variant for anaconda user creationt screen
This looks different now with the KDE theming change.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-16 11:25:48 -08:00
Adam Williamson 80ac81e4df Update and add various version identification needles
KDE live installer started looking different on F37 too so we
need a new needle there, plus we need F39 needles now Rawhide is
F39.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-16 11:24:46 -08:00
Adam Williamson 39b3cc1ff3 Update login_gdm_input needle for appearance change in GNOME 44
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-16 11:24:02 -08:00
Adam Williamson 0029ca8c5a Add F38 background needle (beta, 13:09 time)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-16 11:23:12 -08:00
Adam Williamson 813c329c0c workarounds: add lorax with disabled persistence for 38/39 (#2170544)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-16 10:44:37 -08:00
Adam Williamson 35eec4062e Drop workarounds that went stable
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-16 10:43:22 -08:00
Adam Williamson 8ce6fa4d6e s/overview/overlay/ , duh
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-16 09:15:30 -08:00
Adam Williamson ca6ca2e490 Handle a persistent overlay warning on live boot (#2170544)
In today's F38 and Rawhide, changes to the persistent overlay
stuff result in a boot warning you have to spam through. Let's
handle this as a soft fail so we don't have floods of failed
tests till it's fixed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-16 09:12:36 -08:00
Lukas Ruzicka 94f92c8ae7 Add failed needles for Maps. 2023-02-15 18:35:14 +01:00
Lukas Ruzicka ecf02bb48b Add failed needles for Gnome Text Editor. 2023-02-15 16:07:13 +01:00
Adam Williamson 7156881b64 workarounds: add kde-settings for F38 too
This gets us the F38 background in KDE.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-14 11:27:18 -08:00
Adam Williamson 42316bdfb1 workarounds: add desktop-backgrounds too for F38
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-14 09:58:49 -08:00
Adam Williamson 8ce8f2aba4 f38 workarounds: drop updates now stable, add f38-backgrounds
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-14 09:17:49 -08:00
Adam Williamson 6baf67aefd Work around the f39 toolbox container not existing
On Rawhide, just use an f38 toolbox container for now.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-13 19:16:09 -08:00
Adam Williamson 619f5a70fe Add glib2 2.75.3 to f38 workarounds (FEDORA-2023-965f517da3)
GNOME blows up without it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-13 15:09:14 -08:00
Adam Williamson 860c8e0a09 Add bug F38 GNOME update to workarounds
As we're not getting composes ATM this isn't being pulled into
tests of subsequent updates, but we need it to be or else there
are issues.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-13 12:23:08 -08:00
Adam Williamson 016c78d80b Add FEDORA-2023-ad52b2e4b9 as a workaround for F38
tracker-miners had a bad dep which broke live image builds.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-10 00:05:40 -08:00
Adam Williamson 4db301bba6 Use systemctl start not systemctl isolate in notifications test
Per https://github.com/systemd/systemd/issues/26364#issuecomment-1424900066
this resolves the problem with systemctl isolate not working on
current Rawhide.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-09 14:56:33 -08:00
Adam Williamson 56999e1330 Update more anaconda network needles for font kerning changes
Looks like what happened here is font kerning changed (got
better) in the nm-connection-editor spawned from anaconda.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-08 15:21:24 -08:00
Adam Williamson e75c3ffcb5 Update a couple of Cockpit needles for new release
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-08 15:20:22 -08:00
Adam Williamson 796e50f4fb Update various needles for KDE appearance changes
A lot of these are because anaconda is more KDE-themed on the
KDE live ISO now. The rest are just miscellaneous appearance
changes to KDE apps in recent Rawhide.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-07 16:57:27 -08:00