Commit Graph

103 Commits

Author SHA1 Message Date
Adam Williamson 34eba25858 KDE apps_startstop firewall: type password faster
This is obviously more prone to mistypes, but firewall-config
seems to be timing out if we take more than 25 seconds to type
the password, and we take juuust too long with type_very_safely,
even after tweaking the sleeps to shorter wait_still_screens
here. We could twiddle with those even more, but let's just go
with type_safely for now, if that turns out to be too unreliable
I'll change tack.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-04-15 23:08:20 -07:00
Adam Williamson adedf40b6f apps_startstop: don't rollback, defend against KDE mistypes
This comes from trying to fix the annoying recurring problem with
mistypes in KDE which has been going on since at least December.
First, we add the attempt to kind of 'precache' the kicker menu
in aasetting.pm. Then, I thought, all this snapshot loading has
to be putting a lot of load on the workers. And when each subtest
passes, it shouldn't really be necessary - they all end with
quit_with_shortcut(), which verifies that the app exited and we
got back to a blank desktop, so successful subtests should not
usually interfere with each other. We probably only want to
rollback on *failed* subtests, which is in fact openQA's default
behavior. There only seems to be one case where a test changes the
system state such that later tests might be affected, so I kept
always_rollback just for that one. I've run this through three
cycles on GNOME and KDE and it looks good.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-04-12 15:53:48 -07:00
Lukas Ruzicka 614a2f5e5d Fix the failing KDE startstop tests. 2024-02-27 12:18:45 +01:00
Adam Williamson d85f199f13 deduplicate needle: grant_access / gnome_allow
these were duplicates. In GNOME 46-beta this dialog seems to be
in 'light mode' at least some of the time, so we'll keep the
'light mode' gnome_allow needle we added for Snapshot but
rename it and change its tags. We'll wipe the 'dark mode'
gnome_allow because it should be just the same as the existing
grant_access needle. The two tests that used gnome_allow are
changed to use grant_access.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-02-21 08:12:32 -08:00
Adam Williamson 6654e522ac app start/stop tests: use normal flags for GNOME Terminal test
This test had special flags because it used to be run first and
did the prep steps for the other tests. Now the aaa_setup test
does that job, so there's no reason for this test to have these
flags any more, and somehow they seem to be breaking the test on
Rawhide. Let's give it the same flag as all the other normal
tests.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-10 12:43:45 -08:00
Adam Williamson 99b3ef8f03 kontakt: drop the check for 'enable_unified_mailboxes'
Per the needle cleanup, it hasn't been seen for some time. The
test is failing ATM but even the last time it passed -
https://openqa.fedoraproject.org/tests/2311371#step/kontakt/3 -
we did not see this.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-09 17:44:47 -08:00
Adam Williamson fc7affc473 limpress: use esc not alt-f4 to close template chooser
See https://bugzilla.redhat.com/show_bug.cgi?id=2252806 for why,
we're working around that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-12-04 11:18:12 -08:00
Adam Williamson b2928ff399 KDE app start/stop test updates for Plasma 6
Several needle updates and a tweak to the text we type to launch
kinfocenter (just "info" now launches something else).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-11-30 18:05:37 -08:00
Adam Williamson af73a24f50 Drop dbusviewer from KDE apps start/stop test
khotkeys was removed from Plasma 6, and qdbusviewer was only on
the live image because khotkeys recommended it, so now it's gone.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-11-30 12:12:09 -08:00
Adam Williamson 4e3a284220 krfb: handle two cancel buttons
In today's Rawhide, two dialogs have to be cancelled on krfb
launch before we see the UI: a remote control permission screen
and a kwallet creation flow.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-10-24 08:21:51 -07:00
Adam Williamson f36d04e650 KDE start/stop krfb: dismiss Wallet window if it shows up
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-10-17 09:15:21 -07:00
Adam Williamson c697ca171d Adjust to replacement of cheese with snapshot (Camera)
A new app called snapshot (Camera, on the menus) has replaced
cheese in F40 (but not F39). Adjust to that. We can simplify
this when F39 is out.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-10-15 10:21:17 -07:00
Adam Williamson 1db0e7465a Drop kmag test on F40+
kmag was removed in
https://pagure.io/fedora-comps/c/bb332b310b22a1103347afece6f845087694d85e?branch=main
we can't drop the test entirely yet as it's still in F39. Will
drop this after F39 is released.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-10-15 09:10:51 -07:00
Adam Williamson eb6a47f462 Adjust konversation test to run neochat on Rawhide
KDE replaced Konversation (IRC client) with Neochat (Matrix
client) in Rawhide. As the replacement isn't done in F39 we can't
just switch the test out, we have to handle both, so for now,
let's have the "konversation" test run neochat on Rawhide.

We can't really proceed through neochat's first run wizard as
it needs a Matrix account name and password and we don't want
the hassle of handling a secret just for this, so we'll just
quit out once we see it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-09-26 15:53:54 -07:00
Adam Williamson 836f8e2da6 Revert "apps_startstop: new GNOME image viewer is not in Utilities"
This reverts commit 0d8df76b1b.
Loupe now seems to have been moved down into Utilities like eog
was, so revert this.
2023-09-18 08:48:38 -07:00
Adam Williamson 0d8df76b1b apps_startstop: new GNOME image viewer is not in Utilities
It's on the top level.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-08-23 10:34:03 -07:00
Lukas Ruzicka 4c426051ce Remove the Photos start-stop test.
Based on the information that the application has been removed
from the standard Workstation installation, see
https://pagure.io/fedora-comps/c/462b65876fb4258fdb2ce19f4193900ef2bdc2d9?branch=main,
we remove that application from this suite.
2023-06-28 13:44:31 +02:00
Adam Williamson abc60d23c8 Drop dnfdragora from KDE app start/stop tests
It's not in the images any more. As aleasto pointed out, we're
actually being sent to Discover to install it, and matching on
*that* screen, which isn't what we intend.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-05-30 14:05:42 -07:00
Adam Williamson 1de9d7fa34 Drop click_unwanted_notifications (and associated needle)
It looks like neither of these has been a problem for some time.
The notification needle has not matched for a year. The akonadi
needle doesn't exist any more - it was cleaned up in the 2021
needle cleanup, meaning it hadn't matched for weeks in 2021. I
checked the last several months of KDE app start/stop tests and
don't see any case where there was a stray notification that we
missed. So I think we can just ditch this whole mechanism for
now; if we have problems with these notifications again in future
we can put it back.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-05-04 09:57:15 -07:00
Adam Williamson 51e7b28978 Correct 'grant_access' needle name in several tests
Several tests still had the old 'apps_run_access' name which we
changed some time ago, so these safety checks weren't working.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-05-04 09:57:15 -07:00
Adam Williamson 4fb87a077e Fix KDE media writer launch test
Typing 'mediawriter' doesn't work on Rawhide any more. 'media
writer' (with a space) works OK.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-04-06 11:23:57 -07:00
Adam Williamson a984674e9b add an 'esc' to krfb startstop test to deal with a dialog
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-03-01 14:10:00 -08:00
Adam Williamson a881d227fb apps_startstop: tweak print theme editor launch to avoid #2165657
Typing a partial binary name no longer seems to work. Typing the
full binary name works, but differently from before; seems best
to do a partial entry name search so we launch the actual entry,
not the executable directly.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-01-30 09:31:28 -08:00
Adam Williamson a64cadb8fe Make the Software welcome->ignore change in apps_startstop too
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-01-11 09:16:31 -08:00
Adam Williamson 4d3673f811 Simply abrt KDE stuff even more
...wait, this is what 'workaround' needles are for.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-07 11:30:08 -08:00
Adam Williamson 9c6d5459e6 Simplify the KDE abrt logic
This does the same, just cleaner.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-07 11:26:27 -08:00
Lukáš Růžička 0cb57e7511 Add timeout 30 secs to make less fragile.
The check_screen function checks for the existing tag
but it only waits 1 second by default. In this time,
Abrt will not even start so we need to prolong
the check_screen timeout to make sure the application
has started (or at least give it enough time to try).
2022-12-07 10:00:33 +01:00
Lukas Ruzicka 1605706fb3 Set timeout to 60 on startstop needles. 2022-12-05 15:16:16 +01:00
Lukas Ruzicka f29572ba76 Abrt should not fail on found issues but softfail on startup tests. 2022-12-05 14:30:03 +01:00
Lukas Ruzicka 7daa4b3dd0 Give more time to the needle to avoid failing on delayed start. 2022-12-05 14:03:48 +01:00
Lukas Ruzicka ef5969b600 Wait until screen to make sure the exit shortcut is not pressed when not ready. 2022-10-31 15:56:04 +01:00
Adam Williamson baedbd22aa Run tidy to fix some syntax errors that creeped in recently
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-10-10 15:04:06 +02:00
Lukas Ruzicka 5038dcaab0 Fix the logic in Kmail startstop test
Sometimes the windows are displayed in the reversed order, which
prevents the checks to find the needles and the test fail
even if it should pass. This change should address this case.
2022-10-06 09:51:16 +02:00
Adam Williamson 3a96ef8501 kmouth: also give the first run wizard longer to appear
It seems to consistently take a bit more than 30 seconds.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-09-29 13:17:29 -07:00
Adam Williamson 1a65993d36 Add a perltidy check and apply it to the entire codebase
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-28 14:38:38 -07:00
Lukáš Růžička 621f6c13b5 Add wait time to let the application start properly. 2022-07-19 14:49:26 +02:00
Adam Williamson f81dab6739 Clocks: handle auth, check we actually launched the app
Clocks' aaa_setup did not ever actually check the app launched
properly. It also doesn't handle granting permissions if
necessary, which the apps_startstop test for Clocks does do.

This makes the permission check in the apps_startstop test more
efficient, and adds it to the Clocks app aaa_setup test too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-06-30 13:56:29 -07:00
Lukáš Růžička d09d9d8fe6 Fix the Rhythmbox crash when launched for the first time. 2022-06-15 15:53:20 +02:00
Adam Williamson 1084aa0828 Update KDE vault needles and test
The backend is now cryfs in F36/Rawhide. I don't think we need
to be policing which backend Vault decides to use, so let's just
accept either.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-03-03 08:42:45 -08:00
Adam Williamson 1aee5d1ec0 Avoid duplication between desktop_update and 'software' app test
The 'software' test module in GNOME apps_startstop does a subset
of what the desktop_update_graphical test does already, but
using its own needles. Let's just have it use the same needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-03-01 15:58:45 -08:00
Adam Williamson 752a9476be Drop KDE app 'netcon' test
This was originally a test of nm-connection-editor. However,
at some point that app stopped shipping a .desktop file by
default (it's in a subpackage that is not included in a default
KDE install) and the needle got updated to match on what the
same string now launched, which is a random part of the KDE
system settings. But there's no real sense in this - we don't
test launching every other pane of the system settings app from
the launcher, so it doesn't make sense to just test one random
one like this. Let's just throw the test out.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-25 12:37:53 -08:00
Adam Williamson fcac2af4f8 Update and rationalize KDE app "cancel" needles
We have three different needles which all match on a stock KDE
"cancel" button. Let's just have one. Also, update it for latest
Rawhide/F36 KDE.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-25 12:22:47 -08:00
Adam Williamson 4282048819 Drop screenshot app from GNOME app start/stop tests
It was removed from the default install:
https://pagure.io/fedora-comps/c/5371509
in favor of a new screenshot mechanism that's built in to GNOME
Shell.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-09 10:23:38 -08:00
Adam Williamson 3ae23f66a9 Update GNOME apps test for gedit->gnome-text-editor switch
Workstation replaced gedit with gnome-text-editor. This updates
the needles and also changes the name used for 'tagging' the
application for the core_applications test.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-01-18 15:11:50 -08:00
Adam Williamson d5ca75cb04 Also remove system-config-language test from KDE app test
This was also dropped:
https://pagure.io/fedora-kickstarts/c/5b5fba2

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-01-12 17:26:37 -08:00
Adam Williamson 4e15e16824 Drop kcolorchooser and kruler from KDE apps test
Both were dropped from the default KDE install set:
https://pagure.io/fedora-comps/c/edd0d74
so we need to drop them here too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-01-12 16:59:13 -08:00
Adam Williamson 74927d154a KDE apps: make firefox test handle no 'close tabs' case
Lately Firefox sometimes just closes immediately, it doesn't
show the 'close tabs' dialog. So let's make that optional, but
check we quit properly.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-11-24 10:24:54 -08:00
Adam Williamson de939c17df Update and rationalize KDE "next" needles
kgpg had its own, which doesn't make any sense. There are grey
and blue background variants that weren't consistently named.
This should rationalize things sensibly, and adds a new needle
for the new Plasma in Rawhide, with a lighter blue background.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-09-29 11:05:40 -07:00
Adam Williamson 05a43bdb3c Boxes: workaround #2005458 by hitting esc twice (with softfail)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-09-17 14:33:09 -07:00
Adam Williamson 9882ddcaa5 Robustify and tweak switch out of overview on GNOME boot
This fails sometimes just because we're too early, or something.
Also with GNOME Shell 41rc, alt-f1 no longer works to open and
close the overview. super *does* seem to work in KDE these days,
so let's switch from alt-f1 to super everywhere.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-09-07 11:05:55 -07:00