1
0
mirror of https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git synced 2025-01-21 08:03:08 +00:00

desktop_login: drop obsolete check for 'login failed' message

Up to F33 we could check that an error message was shown when we
tried to log in with the wrong password on GNOME, but since F34
it's transient and disappears too quick to reliably catch, so
we don't check it any more. Now F33 is EOL, drop the conditional.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
This commit is contained in:
Adam Williamson 2022-05-16 16:11:52 -07:00
parent 77cadae5d4
commit a2df6d976b

View File

@ -230,16 +230,7 @@ sub run {
# Try to log in with either account, intentionally entering the wrong password. # Try to log in with either account, intentionally entering the wrong password.
login_user(user=>"jack", password=>"wrongpassword", checklogin=>0); login_user(user=>"jack", password=>"wrongpassword", checklogin=>0);
my $relnum = get_release_number; # get back to the login screen if necessary (dismiss an error message)
if ($desktop eq "gnome" && $relnum < 34) {
# In GDM before F34, a message is shown about an unsuccessful login
# and it can be asserted, so let's do it. In SDDM and GDM F34+,
# there is also a message, but it is only displayed for a short
# moment and the assertion fails here, so we will skip the assertion.
# Not being able to login in with a wrong password is enough here.
assert_screen "login_wrong_password";
send_key 'esc';
}
send_key 'esc' unless (check_screen "login_jim"); send_key 'esc' unless (check_screen "login_jim");
# Now, log into the system again using the correct password. This will # Now, log into the system again using the correct password. This will