From a2df6d976bfcfb1f7cfc78c29dd59a814d9250d4 Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Mon, 16 May 2022 16:11:52 -0700 Subject: [PATCH] desktop_login: drop obsolete check for 'login failed' message Up to F33 we could check that an error message was shown when we tried to log in with the wrong password on GNOME, but since F34 it's transient and disappears too quick to reliably catch, so we don't check it any more. Now F33 is EOL, drop the conditional. Signed-off-by: Adam Williamson --- tests/desktop_login.pm | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/tests/desktop_login.pm b/tests/desktop_login.pm index 9a9c39c4..8fc85cd1 100644 --- a/tests/desktop_login.pm +++ b/tests/desktop_login.pm @@ -230,16 +230,7 @@ sub run { # Try to log in with either account, intentionally entering the wrong password. login_user(user=>"jack", password=>"wrongpassword", checklogin=>0); - my $relnum = get_release_number; - if ($desktop eq "gnome" && $relnum < 34) { - # In GDM before F34, a message is shown about an unsuccessful login - # and it can be asserted, so let's do it. In SDDM and GDM F34+, - # there is also a message, but it is only displayed for a short - # moment and the assertion fails here, so we will skip the assertion. - # Not being able to login in with a wrong password is enough here. - assert_screen "login_wrong_password"; - send_key 'esc'; - } + # get back to the login screen if necessary (dismiss an error message) send_key 'esc' unless (check_screen "login_jim"); # Now, log into the system again using the correct password. This will