re-do most anaconda screenshots for 96dpi

Summary:
Most of the anaconda screenshots were taken with older netinst
images, at 96.09dpi. Workstation lives use 96dpi exactly. This
led to some needles failing on the Workstation live as fonts
render slightly differently at 96 and 96.09dpi. LONG STORY
SHORT, we got a change in GTK+ which means traditional install
images now use 96dpi exactly too; so we should be consistent
between lives and trad images now, but we need to retake all
the screenshots taken at 96.09dpi. That's what this is.

I also cleaned up a couple of other things. The anaconda_error
needle was effectively a duplicate of anaconda_report_btn.
Neither is actually used atm, but I kept report_btn in case we
use it in future.

anaconda_main_hub_installdest_selected isn't needed any more,
since my tweaks to the matching in anaconda_main_hub_nonlive;
it will now match the case this needle was created for initially.

anaconda_software_select_box is no longer used by any test. The
software selection tests were changed to use key sequences and
dropped their use of this needle, but the needle wasn't removed.

anaconda_select_install_lang_english_filtered_english_selected_
as_default was never really necessary, the situation it's meant
for can be handled by simply adding the anaconda_select_install_
lang_english_filtered tag to the anaconda_select_install_lang_
english_selected needle (as this commit does). That achieves
the needed effect and doesn't break the case where the UI is in
Czech.

Most of the match area changes are just because the layout
changed a bit since the screenshot was taken. I did reduce some
over-precision in some needles, notably the multi-disk needles
- there is no reason we need to match on the disk descriptions
and sizes when we're just selecting the appropriate disks. We
aren't testing anaconda's description of the disks (which may
change unexpectedly), only that it *works* with the disk
types used in the test.

After this commit a little under half of the tests pass with
the 23 Branched 20150717 nightly. Most of the ones that fail
fail because of the anaconda tty2 bug (there's no console on
tty2) or the selinux bug (#1243168) that prevents console login
post-install with SELinux enabled. There are a few other fails
too, but none of them seems to be caused by a needle mismatch,
so I'll investigate and fix them separately.

Test Plan:
Run the full test suite on a current nightly, see that some
tests actually pass now!

Reviewers: jskladan, garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D456

needles/anaconda_install_destination_select_disk_1.json

@@ -1,25 +1,18 @@
-{
+{
-  "properties": [],
+    "area": [
-  "area": [
+        {
-    {
+            "height": 24,
-      "ypos": 289,
+            "type": "match",
-      "type": "match",
+            "width": 17,
-      "height": 24,
+            "xpos": 41,
-      "width": 17,
+            "ypos": 289
-      "xpos": 56
+        }
-    },
+    ],
-    {
+    "properties": [],
-      "ypos": 288,
+    "tags": [
-      "type": "match",
+        "anaconda_install_destination_select_disk_1",
-      "height": 24,
+        "ENV-DISTRI-fedora",
-      "width": 87,
+        "ENV-INSTLANG-en_US",
-      "xpos": 102
+        "ENV-FLAVOR-server"
-    }
+    ]
-  ],
-  "tags": [
-    "anaconda_install_destination_select_disk_1",
-    "ENV-DISTRI-fedora",
-    "ENV-INSTLANG-en_US",
-    "ENV-FLAVOR-server"
-  ]
 }

needles/anaconda_install_destination_select_disk_2.json

@@ -1,32 +1,18 @@
-{
+{
-  "tags": [
+    "area": [
-    "anaconda_install_destination_select_disk_2",
+        {
-    "ENV-DISTRI-fedora",
+            "height": 23,
-    "ENV-INSTLANG-en_US",
+            "type": "match",
-    "ENV-FLAVOR-server"
+            "width": 15,
-  ],
+            "xpos": 206,
-  "area": [
+            "ypos": 290
-    {
+        }
-      "xpos": 290,
+    ],
-      "type": "match",
+    "properties": [],
-      "ypos": 178,
+    "tags": [
-      "width": 73,
+        "anaconda_install_destination_select_disk_2",
-      "height": 63
+        "ENV-DISTRI-fedora",
-    },
+        "ENV-INSTLANG-en_US",
-    {
+        "ENV-FLAVOR-server"
-      "ypos": 275,
+    ]
-      "type": "match",
-      "height": 23,
-      "width": 20,
-      "xpos": 266
-    },
-    {
-      "type": "match",
-      "ypos": 278,
-      "width": 81,
-      "height": 22,
-      "xpos": 317
-    }
-  ],
-  "properties": []
 }

needles/anaconda_install_destination_two_disks.json

@@ -1,17 +1,17 @@
-{
+{
-  "tags": [
+    "area": [
-    "anaconda_install_destination_two_disks",
+        {
-    "ENV-DISTRI-fedora",
+            "height": 46,
-    "ENV-INSTLANG-en_US",
+            "type": "match",
-    "ENV-FLAVOR-server"
+            "width": 322,
-  ],
+            "xpos": 57,
-  "area": [
+            "ypos": 213
-    {
+        }
-      "xpos": 57,
+    ],
-      "ypos": 203,
+    "tags": [
-      "width": 322,
+        "anaconda_install_destination_two_disks",
-      "height": 46,
+        "ENV-DISTRI-fedora",
-      "type": "match"
+        "ENV-INSTLANG-en_US",
-    }
+        "ENV-FLAVOR-server"
-  ]
+    ]
 }

needles/anaconda_install_done.json

@@ -1,24 +1,24 @@
 {
-  "area": [
+    "area": [
-    {
+        {
-      "xpos": 669,
+            "height": 20,
-      "ypos": 639,
+            "type": "match",
-      "height": 25,
+            "width": 325,
-      "width": 330,
+            "xpos": 694,
-      "type": "match"
+            "ypos": 634
-    },
+        },
-    {
+        {
-      "type": "match",
+            "height": 28,
-      "width": 17,
+            "type": "match",
-      "ypos": 688,
+            "width": 17,
-      "height": 28,
+            "xpos": 1000,
-      "xpos": 977
+            "ypos": 680
-    }
+        }
-  ],
+    ],
-  "tags": [
+    "tags": [
-    "anaconda_install_done",
+        "anaconda_install_done",
-    "ENV-DESKTOP-default",
+        "ENV-DESKTOP-default",
-    "ENV-DISTRI-fedora",
+        "ENV-DISTRI-fedora",
-    "ENV-INSTLANG-en_US"
+        "ENV-INSTLANG-en_US"
-  ]
+    ]
 }

needles/anaconda_install_root_password.json

@@ -1,17 +1,17 @@
-{
+{
-  "tags": [
+    "area": [
-    "anaconda_install_root_password",
+        {
-    "ENV-DESKTOP-default",
+            "height": 63,
-    "ENV-DISTRI-fedora",
+            "type": "match",
-    "ENV-INSTLANG-en_US"
+            "width": 192,
-  ],
+            "xpos": 266,
-  "area": [
+            "ypos": 154
-    {
+        }
-      "xpos": 286,
+    ],
-      "ypos": 139,
+    "tags": [
-      "width": 192,
+        "anaconda_install_root_password",
-      "height": 63,
+        "ENV-DESKTOP-default",
-      "type": "match"
+        "ENV-DISTRI-fedora",
-    }
+        "ENV-INSTLANG-en_US"
-  ]
+    ]
 }

needles/anaconda_install_user_creation.json

@@ -1,17 +1,17 @@
-{
+{
-  "area": [
+    "area": [
-    {
+        {
-      "xpos": 691,
+            "height": 61,
-      "ypos": 142,
+            "type": "match",
-      "width": 187,
+            "width": 187,
-      "height": 61,
+            "xpos": 691,
-      "type": "match"
+            "ypos": 157
-    }
+        }
-  ],
+    ],
-  "tags": [
+    "tags": [
-    "ENV-DESKTOP-default",
+        "ENV-DESKTOP-default",
-    "ENV-DISTRI-fedora",
+        "ENV-DISTRI-fedora",
-    "ENV-INSTLANG-en_US",
+        "ENV-INSTLANG-en_US",
-    "anaconda_install_user_creation"
+        "anaconda_install_user_creation"
-  ]
+    ]
 }

needles/anaconda_install_user_creation_make_admin.json

@@ -1,17 +1,17 @@
-{
+{
-  "area": [
+    "area": [
-    {
+        {
-      "xpos": 356,
+            "height": 21,
-      "ypos": 197,
+            "type": "match",
-      "width": 204,
+            "width": 204,
-      "height": 21,
+            "xpos": 356,
-      "type": "match"
+            "ypos": 217
-    }
+        }
-  ],
+    ],
-  "tags": [
+    "tags": [
-    "ENV-DESKTOP-default",
+        "ENV-DESKTOP-default",
-    "ENV-DISTRI-fedora",
+        "ENV-DISTRI-fedora",
-    "ENV-INSTLANG-en_US",
+        "ENV-INSTLANG-en_US",
-    "anaconda_install_user_creation_make_admin"
+        "anaconda_install_user_creation_make_admin"
-  ]
+    ]
 }

needles/anaconda_main_hub_begin_installation.json

@@ -1,17 +1,17 @@
-{
+{
-  "area": [
+    "area": [
-    {
+        {
-      "xpos": 867,
+            "height": 42,
-      "ypos": 694,
+            "type": "match",
-      "width": 157,
+            "width": 152,
-      "height": 52,
+            "xpos": 867,
-      "type": "match"
+            "ypos": 694
-    }
+        }
-  ],
+    ],
-  "tags": [
+    "tags": [
-    "anaconda_main_hub_begin_installation",
+        "anaconda_main_hub_begin_installation",
-    "ENV-DESKTOP-default",
+        "ENV-DESKTOP-default",
-    "ENV-DISTRI-fedora",
+        "ENV-DISTRI-fedora",
-    "ENV-INSTLANG-en_US"
+        "ENV-INSTLANG-en_US"
-  ]
+    ]
 }

needles/anaconda_main_hub_install_destination.json

@@ -1,17 +1,17 @@
-{
+{
-  "tags": [
+    "area": [
-    "anaconda_main_hub_install_destination",
+        {
-    "ENV-DESKTOP-default",
+            "height": 77,
-    "ENV-DISTRI-fedora",
+            "type": "match",
-    "ENV-INSTLANG-en_US"
+            "width": 74,
-  ],
+            "xpos": 184,
-  "area": [
+            "ypos": 461
-    {
+        }
-      "xpos": 214,
+    ],
-      "ypos": 446,
+    "tags": [
-      "width": 74,
+        "anaconda_main_hub_install_destination",
-      "height": 77,
+        "ENV-DESKTOP-default",
-      "type": "match"
+        "ENV-DISTRI-fedora",
-    }
+        "ENV-INSTLANG-en_US"
-  ]
+    ]
 }

needles/anaconda_main_hub_installdest_selected.json

@@ -1,60 +0,0 @@
-{
-  "tags": [
-    "anaconda_main_hub",
-    "ENV-DISTRI-fedora",
-    "ENV-INSTLANG-en_US",
-    "ENV-FLAVOR-server"
-  ],
-  "area": [
-    {
-      "xpos": 168,
-      "ypos": 7,
-      "type": "match",
-      "height": 57,
-      "width": 227
-    },
-    {
-      "xpos": 266,
-      "width": 101,
-      "height": 33,
-      "type": "match",
-      "ypos": 153
-    },
-    {
-      "width": 180,
-      "height": 33,
-      "type": "match",
-      "ypos": 155,
-      "xpos": 699
-    },
-    {
-      "width": 203,
-      "height": 38,
-      "type": "match",
-      "ypos": 346,
-      "xpos": 267
-    },
-    {
-      "xpos": 264,
-      "ypos": 475,
-      "type": "match",
-      "height": 50,
-      "width": 252
-    },
-    {
-      "height": 18,
-      "width": 36,
-      "ypos": 236,
-      "type": "match",
-      "xpos": 272
-    },
-    {
-      "type": "match",
-      "ypos": 240,
-      "width": 40,
-      "height": 13,
-      "xpos": 330
-    }
-  ],
-  "properties": []
-}

needles/anaconda_minimal_highlighted.json

@@ -1,18 +1,18 @@
-{
+{
-  "properties": [],
+    "area": [
-  "tags": [
+        {
-    "anaconda_minimal_highlighted",
+            "height": 15,
-    "ENV-DISTRI-fedora",
+            "type": "match",
-    "ENV-INSTLANG-en_US",
+            "width": 95,
-    "ENV-FLAVOR-server"
+            "xpos": 50,
-  ],
+            "ypos": 146
-  "area": [
+        }
-    {
+    ],
-      "xpos": 50,
+    "properties": [],
-      "ypos": 681,
+    "tags": [
-      "width": 95,
+        "anaconda_minimal_highlighted",
-      "height": 15,
+        "ENV-DISTRI-fedora",
-      "type": "match"
+        "ENV-INSTLANG-en_US",
-    }
+        "ENV-FLAVOR-server"
-  ]
+    ]
-}
+}

needles/anaconda_minimal_selected.json

@@ -1,18 +1,18 @@
-{
+{
-  "properties": [],
+    "area": [
-  "area": [
+        {
-    {
+            "height": 14,
-      "xpos": 30,
+            "type": "match",
-      "ypos": 681,
+            "width": 114,
-      "width": 114,
+            "xpos": 30,
-      "height": 14,
+            "ypos": 146
-      "type": "match"
+        }
-    }
+    ],
-  ],
+    "properties": [],
-  "tags": [
+    "tags": [
-    "anaconda_minimal_selected",
+        "anaconda_minimal_selected",
-    "ENV-DISTRI-fedora",
+        "ENV-DISTRI-fedora",
-    "ENV-INSTLANG-en_US",
+        "ENV-INSTLANG-en_US",
-    "ENV-FLAVOR-server"
+        "ENV-FLAVOR-server"
-  ]
+    ]
 }

needles/anaconda_part_list_box_swap.json

@@ -1,18 +1,18 @@
-{
+{
-  "properties": [],
+    "area": [
-  "area": [
+        {
-    {
+            "height": 24,
-      "xpos": 472,
+            "type": "match",
-      "ypos": 498,
+            "width": 91,
-      "width": 91,
+            "xpos": 472,
-      "height": 24,
+            "ypos": 528
-      "type": "match"
+        }
-    }
+    ],
-  ],
+    "properties": [],
-  "tags": [
+    "tags": [
-    "anaconda_part_list_box_swap",
+        "anaconda_part_list_box_swap",
-    "ENV-DISTRI-fedora",
+        "ENV-DISTRI-fedora",
-    "ENV-INSTLANG-en_US",
+        "ENV-INSTLANG-en_US",
-    "ENV-FLAVOR-server"
+        "ENV-FLAVOR-server"
-  ]
+    ]
 }

needles/anaconda_part_plus_button.json

@@ -1,18 +1,18 @@
-{
+{
-  "tags": [
+    "area": [
-    "anaconda_part_plus_button",
+        {
-    "ENV-DISTRI-fedora",
+            "height": 31,
-    "ENV-INSTLANG-en_US",
+            "type": "match",
-    "ENV-FLAVOR-server"
+            "width": 35,
-  ],
+            "xpos": 32,
-  "area": [
+            "ypos": 619
-    {
+        }
-      "xpos": 32,
+    ],
-      "ypos": 624,
+    "properties": [],
-      "width": 35,
+    "tags": [
-      "height": 31,
+        "anaconda_part_plus_button",
-      "type": "match"
+        "ENV-DISTRI-fedora",
-    }
+        "ENV-INSTLANG-en_US",
-  ],
+        "ENV-FLAVOR-server"
-  "properties": []
+    ]
 }

needles/anaconda_part_update_settings.json

@@ -1,18 +1,18 @@
-{
+{
-  "properties": [],
+    "area": [
-  "tags": [
+        {
-    "anaconda_part_update_settings",
+            "height": 23,
-    "ENV-DISTRI-fedora",
+            "type": "match",
-    "ENV-INSTLANG-en_US",
+            "width": 112,
-    "ENV-FLAVOR-server"
+            "xpos": 879,
-  ],
+            "ypos": 566
-  "area": [
+        }
-    {
+    ],
-      "xpos": 879,
+    "properties": [],
-      "ypos": 571,
+    "tags": [
-      "width": 112,
+        "anaconda_part_update_settings",
-      "height": 23,
+        "ENV-DISTRI-fedora",
-      "type": "match"
+        "ENV-INSTLANG-en_US",
-    }
+        "ENV-FLAVOR-server"
-  ]
+    ]
 }

needles/anaconda_select_install_lang.json

@@ -1,17 +1,17 @@
-{
+{
-  "tags": [
+    "area": [
-    "anaconda_select_install_lang",
+        {
-    "ENV-DISTRI-fedora",
+            "height": 28,
-    "ENV-INSTLANG-en_US",
+            "type": "match",
-    "ENV-FLAVOR-server"
+            "width": 93,
-  ],
+            "xpos": 362,
-  "area": [
+            "ypos": 110
-    {
+        }
-      "height": 28,
+    ],
-      "ypos": 110,
+    "tags": [
-      "xpos": 332,
+        "anaconda_select_install_lang",
-      "width": 88,
+        "ENV-DISTRI-fedora",
-      "type": "match"
+        "ENV-INSTLANG-en_US",
-    }
+        "ENV-FLAVOR-server"
-  ]
+    ]
 }

needles/anaconda_select_install_lang_continue.json

@@ -1,17 +1,17 @@
-{
+{
-  "tags": [
+    "area": [
-    "anaconda_select_install_lang_continue",
+        {
-    "ENV-DESKTOP-default",
+            "height": 37,
-    "ENV-DISTRI-fedora",
+            "type": "match",
-    "ENV-INSTLANG-en_US"
+            "width": 99,
-  ],
+            "xpos": 919,
-  "area": [
+            "ypos": 725
-    {
+        }
-      "xpos": 919,
+    ],
-      "ypos": 725,
+    "tags": [
-      "width": 104,
+        "anaconda_select_install_lang_continue",
-      "height": 42,
+        "ENV-DESKTOP-default",
-      "type": "match"
+        "ENV-DISTRI-fedora",
-    }
+        "ENV-INSTLANG-en_US"
-  ]
+    ]
 }

needles/anaconda_select_install_lang_english_filtered_english_selected_as_default.json

@@ -1,18 +0,0 @@
-{
-  "tags": [
-    "anaconda_select_install_lang_english_filtered",
-    "ENV-DISTRI-fedora",
-    "ENV-INSTLANG-en_US",
-    "ENV-OFW-1",
-    "ENV-FLAVOR-server"
-  ],
-  "area": [
-    {
-      "xpos": 221,
-      "ypos": 205,
-      "width": 126,
-      "height": 26,
-      "type": "match"
-    }
-  ]
-}

needles/anaconda_select_install_lang_english_selected.json

@@ -1,18 +1,19 @@
-{
+{
-  "tags": [
+    "area": [
-    "anaconda_select_install_lang_english_selected",
+        {
-    "ENV-DISTRI-fedora",
+            "height": 20,
-    "ENV-INSTLANG-en_US",
+            "type": "match",
-    "ENV-OFW-1",
+            "width": 169,
-    "ENV-FLAVOR-server"
+            "xpos": 603,
-  ],
+            "ypos": 205
-  "area": [
+        }
-    {
+    ],
-      "height": 70,
+    "tags": [
-      "type": "match",
+        "anaconda_select_install_lang_english_selected",
-      "xpos": 593,
+        "anaconda_select_install_lang_english_filtered",
-      "ypos": 190,
+        "ENV-DISTRI-fedora",
-      "width": 349
+        "ENV-INSTLANG-en_US",
-    }
+        "ENV-OFW-1",
-  ]
+        "ENV-FLAVOR-server"
-}
+    ]
+}

needles/anaconda_select_install_lang_input.json

@@ -1,18 +1,18 @@
-{
+{
-  "properties": [],
+    "area": [
-  "area": [
+        {
-    {
+            "height": 19,
-      "xpos": 511,
+            "type": "match",
-      "ypos": 649,
+            "width": 59,
-      "width": 59,
+            "xpos": 511,
-      "height": 19,
+            "ypos": 644
-      "type": "match"
+        }
-    }
+    ],
-  ],
+    "properties": [],
-  "tags": [
+    "tags": [
-    "anaconda_select_install_lang_input",
+        "anaconda_select_install_lang_input",
-    "ENV-DISTRI-fedora",
+        "ENV-DISTRI-fedora",
-    "ENV-INSTLANG-en_US",
+        "ENV-INSTLANG-en_US",
-    "ENV-FLAVOR-server"
+        "ENV-FLAVOR-server"
-  ]
+    ]
 }

needles/anaconda_software_select_box.json

@@ -1,18 +0,0 @@
-{
-  "tags": [
-    "anaconda_software_select_box",
-    "ENV-DISTRI-fedora",
-    "ENV-INSTLANG-en_US",
-    "ENV-OFW-1",
-    "ENV-FLAVOR-server"
-  ],
-  "area": [
-    {
-      "xpos": 50,
-      "ypos": 189,
-      "width": 96,
-      "height": 18,
-      "type": "match"
-    }
-  ]
-}

needles/anaconda_spoke_done.json

@@ -1,17 +1,17 @@
-{
+{
-  "tags": [
+    "area": [
-    "anaconda_spoke_done",
+        {
-    "ENV-DESKTOP-default",
+            "height": 28,
-    "ENV-DISTRI-fedora",
+            "type": "match",
-    "ENV-INSTLANG-en_US"
+            "width": 61,
-  ],
+            "xpos": 8,
-  "area": [
+            "ypos": 48
-    {
+        }
-      "xpos": 19,
+    ],
-      "ypos": 35,
+    "tags": [
-      "width": 63,
+        "anaconda_spoke_done",
-      "height": 30,
+        "ENV-DESKTOP-default",
-      "type": "match"
+        "ENV-DISTRI-fedora",
-    }
+        "ENV-INSTLANG-en_US"
-  ]
+    ]
-}
+}