mirror of
https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git
synced 2024-11-04 23:24:21 +00:00
2e4c1c2325
Summary: Most of the anaconda screenshots were taken with older netinst images, at 96.09dpi. Workstation lives use 96dpi exactly. This led to some needles failing on the Workstation live as fonts render slightly differently at 96 and 96.09dpi. LONG STORY SHORT, we got a change in GTK+ which means traditional install images now use 96dpi exactly too; so we should be consistent between lives and trad images now, but we need to retake all the screenshots taken at 96.09dpi. That's what this is. I also cleaned up a couple of other things. The anaconda_error needle was effectively a duplicate of anaconda_report_btn. Neither is actually used atm, but I kept report_btn in case we use it in future. anaconda_main_hub_installdest_selected isn't needed any more, since my tweaks to the matching in anaconda_main_hub_nonlive; it will now match the case this needle was created for initially. anaconda_software_select_box is no longer used by any test. The software selection tests were changed to use key sequences and dropped their use of this needle, but the needle wasn't removed. anaconda_select_install_lang_english_filtered_english_selected_ as_default was never really necessary, the situation it's meant for can be handled by simply adding the anaconda_select_install_ lang_english_filtered tag to the anaconda_select_install_lang_ english_selected needle (as this commit does). That achieves the needed effect and doesn't break the case where the UI is in Czech. Most of the match area changes are just because the layout changed a bit since the screenshot was taken. I did reduce some over-precision in some needles, notably the multi-disk needles - there is no reason we need to match on the disk descriptions and sizes when we're just selecting the appropriate disks. We aren't testing anaconda's description of the disks (which may change unexpectedly), only that it *works* with the disk types used in the test. After this commit a little under half of the tests pass with the 23 Branched 20150717 nightly. Most of the ones that fail fail because of the anaconda tty2 bug (there's no console on tty2) or the selinux bug (#1243168) that prevents console login post-install with SELinux enabled. There are a few other fails too, but none of them seems to be caused by a needle mismatch, so I'll investigate and fix them separately. Test Plan: Run the full test suite on a current nightly, see that some tests actually pass now! Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D456
18 lines
341 B
JSON
18 lines
341 B
JSON
{
|
|
"area": [
|
|
{
|
|
"height": 15,
|
|
"type": "match",
|
|
"width": 95,
|
|
"xpos": 50,
|
|
"ypos": 146
|
|
}
|
|
],
|
|
"properties": [],
|
|
"tags": [
|
|
"anaconda_minimal_highlighted",
|
|
"ENV-DISTRI-fedora",
|
|
"ENV-INSTLANG-en_US",
|
|
"ENV-FLAVOR-server"
|
|
]
|
|
} |