38 lines
1.2 KiB
Diff
38 lines
1.2 KiB
Diff
From ae88217aa64f1924ff88941d2ad0ce1aa6ad7fc4 Mon Sep 17 00:00:00 2001
|
|
From: "Richard W.M. Jones" <rjones@redhat.com>
|
|
Date: Mon, 7 Apr 2014 12:44:09 +0100
|
|
Subject: [PATCH] Add quoting around parameter when calling external mke2fs
|
|
(RHBZ#1084921).
|
|
|
|
If you tried to write the appliance to a path containing a space, it
|
|
would fail like this:
|
|
|
|
supermin: ext2: creating empty ext2 filesystem '/media/bigon/Little disk/.guestfs-1000/appliance.d.p4ovrvj6/root'
|
|
mke2fs: invalid blocks 'disk/.guestfs-1000/appliance.d.p4ovrvj6/root' on device '/media/bigon/Little'
|
|
|
|
This is because there was missing quoting around the parameter passed
|
|
to mke2fs.
|
|
|
|
Thanks: Laurent Bigonville
|
|
https://bugzilla.redhat.com/show_bug.cgi?id=1084921
|
|
---
|
|
src/ext2.ml | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/src/ext2.ml b/src/ext2.ml
|
|
index c9c8933..bccf3a7 100644
|
|
--- a/src/ext2.ml
|
|
+++ b/src/ext2.ml
|
|
@@ -49,7 +49,7 @@ let build_ext2 debug basedir files modpath kernel_version appliance =
|
|
sprintf "%s %s ext2 -F%s %s"
|
|
Config.mke2fs Config.mke2fs_t_option
|
|
(if debug >= 2 then "" else "q")
|
|
- appliance in
|
|
+ (quote appliance) in
|
|
run_command cmd;
|
|
|
|
let fs = ext2fs_open appliance in
|
|
--
|
|
1.8.5.3
|
|
|