Clean up try blocks

- minimize code in try blocks
- remove "except Exception" (global error handling to be added later)
This commit is contained in:
Petr Viktorin 2019-07-17 12:29:05 +02:00
parent dd5ff52621
commit e6c1981103

View File

@ -1,4 +1,5 @@
import sys import sys
import importlib
try: try:
import pytoml import pytoml
@ -10,19 +11,15 @@ except ImportError:
try: try:
with open("pyproject.toml") as f: f = open("pyproject.toml") as f
pyproject_data = pytoml.load(f)
except FileNotFoundError: except FileNotFoundError:
pyproject_data = {} pyproject_data = {}
except Exception as e:
sys.exit(e)
else: else:
import importlib with f:
pyproject_data = pytoml.load(f)
try: try:
backend = importlib.import_module( backend_name = pyproject_data["build-system"]["build-backend"]
pyproject_data["build-system"]["build-backend"]
)
except KeyError: except KeyError:
try: try:
import setuptools.build_meta import setuptools.build_meta
@ -32,6 +29,9 @@ else:
sys.exit(0) sys.exit(0)
backend = setuptools.build_meta backend = setuptools.build_meta
else:
try:
backend = importlib.import_module(backend_name)
except ImportError: except ImportError:
backend = None backend = None
@ -51,19 +51,14 @@ def add_requirement(requirement):
if "requires" in pyproject_data.get("build-system", {}): if "requires" in pyproject_data.get("build-system", {}):
try:
for requirement in pyproject_data["build-system"]["requires"]: for requirement in pyproject_data["build-system"]["requires"]:
add_requirement(requirement) add_requirement(requirement)
except Exception as e:
sys.exit(e)
if hasattr(backend, "get_requires_for_build_wheel"): get_requires = getattr(backend, "get_requires_for_build_wheel", None)
try: if get_requires:
for requirement in backend.get_requires_for_build_wheel(): for requirement in get_requires():
add_requirement(requirement) add_requirement(requirement)
except Exception as e:
sys.exit(e)
for requirement in requirements: for requirement in requirements:
name = canonicalize_name(requirement.name) name = canonicalize_name(requirement.name)