From e6c1981103ea2bfbb67db4ca4730dfb37e2542bf Mon Sep 17 00:00:00 2001
From: Petr Viktorin <pviktori@redhat.com>
Date: Wed, 17 Jul 2019 12:29:05 +0200
Subject: [PATCH] Clean up try blocks

- minimize code in try blocks
- remove "except Exception" (global error handling to be added later)
---
 pyproject_buildrequires.py | 37 ++++++++++++++++---------------------
 1 file changed, 16 insertions(+), 21 deletions(-)

diff --git a/pyproject_buildrequires.py b/pyproject_buildrequires.py
index b643f9a..5e23411 100644
--- a/pyproject_buildrequires.py
+++ b/pyproject_buildrequires.py
@@ -1,4 +1,5 @@
 import sys
+import importlib
 
 try:
     import pytoml
@@ -10,19 +11,15 @@ except ImportError:
 
 
 try:
-    with open("pyproject.toml") as f:
-        pyproject_data = pytoml.load(f)
+    f = open("pyproject.toml") as f
 except FileNotFoundError:
     pyproject_data = {}
-except Exception as e:
-    sys.exit(e)
 else:
-    import importlib
+    with f:
+        pyproject_data = pytoml.load(f)
 
     try:
-        backend = importlib.import_module(
-            pyproject_data["build-system"]["build-backend"]
-        )
+        backend_name = pyproject_data["build-system"]["build-backend"]
     except KeyError:
         try:
             import setuptools.build_meta
@@ -32,8 +29,11 @@ else:
             sys.exit(0)
 
         backend = setuptools.build_meta
-    except ImportError:
-        backend = None
+    else:
+        try:
+            backend = importlib.import_module(backend_name)
+        except ImportError:
+            backend = None
 
 
 requirements = set()
@@ -51,19 +51,14 @@ def add_requirement(requirement):
 
 
 if "requires" in pyproject_data.get("build-system", {}):
-    try:
-        for requirement in pyproject_data["build-system"]["requires"]:
-            add_requirement(requirement)
-    except Exception as e:
-        sys.exit(e)
+    for requirement in pyproject_data["build-system"]["requires"]:
+        add_requirement(requirement)
 
 
-if hasattr(backend, "get_requires_for_build_wheel"):
-    try:
-        for requirement in backend.get_requires_for_build_wheel():
-            add_requirement(requirement)
-    except Exception as e:
-        sys.exit(e)
+get_requires = getattr(backend, "get_requires_for_build_wheel", None)
+if get_requires:
+    for requirement in get_requires():
+        add_requirement(requirement)
 
 for requirement in requirements:
     name = canonicalize_name(requirement.name)