rpms/opencryptoki
7
0
Fork 0
Code Issues Pull Requests Releases Activity

import opencryptoki-3.18.0-5.el8_7

Browse Source
This commit is contained in:
CentOS Sources 2023-01-12 03:26:42 -05:00 committed by Stepan Oksanichenko
parent 2e1694e46b
commit 5353acefcb
2 changed files with 41 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
SOURCES/opencryptoki-3.19.0-fix-memory-leak.patch Normal file
View File

@ -0,0 +1,33 @@
commit d5ccb00e52f5b0c66533f085cda36f63f7583d44
Author: Ingo Franzki <ifranzki@linux.ibm.com>
Date: Tue Jul 19 16:16:55 2022 +0200
common: fix memory leak in save_private_token_object
Reported by coverty scan:
Error: RESOURCE_LEAK (CWE-772):
opencryptoki-3.18.0/usr/lib/common/loadsave.c:2311: alloc_fn:
Storage is returned from allocation function "fopen".
opencryptoki-3.18.0/usr/lib/common/loadsave.c:2311: var_assign:
Assigning: "fp" = storage returned from "fopen(fname, "r")".
opencryptoki-3.18.0/usr/lib/common/loadsave.c:2316: noescape:
Resource "fp" is not freed or pointed-to in "fileno".
opencryptoki-3.18.0/usr/lib/common/loadsave.c:2407: overwrite_var:
Overwriting "fp" in "fp = fopen(fname, "w")" leaks the storage that "fp" points to.
Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>
diff --git a/usr/lib/common/loadsave.c b/usr/lib/common/loadsave.c
index bbd691c0..91955f47 100644
--- a/usr/lib/common/loadsave.c
+++ b/usr/lib/common/loadsave.c
@@ -2344,6 +2344,8 @@ CK_RV save_private_token_object(STDLL_TokData_t *tokdata, OBJECT *obj)
/* New token objects files created by mkstemp have a size of zero */
if (sb.st_size == 0) {
new = 1;
+ fclose(fp);
+ fp = NULL;
goto do_work;
}

9
SPECS/opencryptoki.spec
View File

@ -1,7 +1,7 @@
Name: opencryptoki Name: opencryptoki
Summary: Implementation of the PKCS#11 (Cryptoki) specification v3.0 Summary: Implementation of the PKCS#11 (Cryptoki) specification v3.0
Version: 3.18.0 Version: 3.18.0
Release: 3%{?dist} Release: 5%{?dist}
License: CPL License: CPL
Group: System Environment/Base Group: System Environment/Base
URL: https://github.com/opencryptoki/opencryptoki URL: https://github.com/opencryptoki/opencryptoki
@ -15,6 +15,7 @@ Patch2: opencryptoki-3.18.0-p11sak.patch
# upstream patches # upstream patches
Patch100: opencryptoki-3.18.0-fix-json-output.patch Patch100: opencryptoki-3.18.0-fix-json-output.patch
Patch102: opencryptoki-3.18.0-returning_CKR_BUFFER_TOO_SMALL.patch Patch102: opencryptoki-3.18.0-returning_CKR_BUFFER_TOO_SMALL.patch
Patch103: opencryptoki-3.19.0-fix-memory-leak.patch
Requires(pre): coreutils diffutils Requires(pre): coreutils diffutils
Requires: (selinux-policy >= 3.14.3-70 if selinux-policy-targeted) Requires: (selinux-policy >= 3.14.3-70 if selinux-policy-targeted)
@ -365,6 +366,12 @@ fi
%changelog %changelog
* Thu Oct 20 2022 Than Ngo <than@redhat.com> - 3.18.0-5
- Related: #2129059, rebased the patch
* Wed Oct 19 2022 Than Ngo <than@redhat.com> - 3.18.0-4
- Resolves: #2129059, C_GenerateKeyPair() fails after generating > 500 RSA keys with CEX7 crypto cards
* Mon Aug 01 2022 Than Ngo <than@redhat.com> - 3.18.0-3 * Mon Aug 01 2022 Than Ngo <than@redhat.com> - 3.18.0-3
- Related: #2043854, do not touch opencryptoki.conf if it is in place already and even if it is unchanged - Related: #2043854, do not touch opencryptoki.conf if it is in place already and even if it is unchanged
- Resolves: #2112785, EP11: Fix C_GetMechanismList returning CKR_BUFFER_TOO_SMALL - Resolves: #2112785, EP11: Fix C_GetMechanismList returning CKR_BUFFER_TOO_SMALL