rpms/net-snmp
6
0
Fork 0
Code Issues Pull Requests Releases Activity

Fixed fedora-review tool complaints:

Browse Source 
- fixed Source0
- removed %defattr
- removed 'missingok' in %config files
- use %global
- removed BuildRoot:
This commit is contained in:
Jan Safranek 2012-08-27 12:47:40 +02:00
parent 245ffbe201
commit eecc6a24ff
1 changed files with 8 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
net-snmp.spec
View File

@ -6,7 +6,7 @@
# allow compilation on Fedora 11 and older # allow compilation on Fedora 11 and older
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
# Arches on which we need to prevent arch conflicts on net-snmp-config.h # Arches on which we need to prevent arch conflicts on net-snmp-config.h
%define multilib_arches %{ix86} ia64 ppc ppc64 s390 s390x x86_64 sparc sparcv9 sparc64 %global multilib_arches %{ix86} ia64 ppc ppc64 s390 s390x x86_64 sparc sparcv9 sparc64
Summary: A collection of SNMP protocol tools and libraries Summary: A collection of SNMP protocol tools and libraries
Name: net-snmp Name: net-snmp
@ -17,7 +17,7 @@ Epoch: 1
License: BSD License: BSD
Group: System Environment/Daemons Group: System Environment/Daemons
URL: http://net-snmp.sourceforge.net/ URL: http://net-snmp.sourceforge.net/
Source0: http://dl.sourceforge.net/net-snmp/net-snmp-%{version}.tar.gz Source0: https://downloads.sourceforge.net/project/net-snmp/net-snmp/%{version}/net-snmp-%{version}.tar.gz
Source1: net-snmp.redhat.conf Source1: net-snmp.redhat.conf
Source2: net-snmpd.init Source2: net-snmpd.init
Source3: net-snmptrapd.init Source3: net-snmptrapd.init
@ -54,7 +54,6 @@ Requires: mysql-libs
# should fire just after this package is installed. # should fire just after this package is installed.
Requires(post): systemd-sysv Requires(post): systemd-sysv
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRequires: openssl-devel, bzip2-devel, elfutils-devel BuildRequires: openssl-devel, bzip2-devel, elfutils-devel
BuildRequires: libselinux-devel, elfutils-libelf-devel, rpm-devel BuildRequires: libselinux-devel, elfutils-libelf-devel, rpm-devel
BuildRequires: perl-devel, perl(ExtUtils::Embed), gawk, procps BuildRequires: perl-devel, perl(ExtUtils::Embed), gawk, procps
@ -408,14 +407,13 @@ echo date >>/tmp/snmp
rm -rf ${RPM_BUILD_ROOT} rm -rf ${RPM_BUILD_ROOT}
%files %files
%defattr(-,root,root,-)
%doc COPYING ChangeLog.trimmed EXAMPLE.conf FAQ NEWS TODO %doc COPYING ChangeLog.trimmed EXAMPLE.conf FAQ NEWS TODO
%doc README README.agent-mibs README.agentx README.krb5 README.snmpv3 %doc README README.agent-mibs README.agentx README.krb5 README.snmpv3
%doc local/passtest local/ipf-mod.pl %doc local/passtest local/ipf-mod.pl
%doc README.thread AGENT.txt PORTING local/README.mib2c README.systemd %doc README.thread AGENT.txt PORTING local/README.mib2c README.systemd
%dir %{_sysconfdir}/snmp %dir %{_sysconfdir}/snmp
%config(noreplace,missingok) %{_sysconfdir}/snmp/snmpd.conf %config(noreplace) %{_sysconfdir}/snmp/snmpd.conf
%config(noreplace,missingok) %{_sysconfdir}/snmp/snmptrapd.conf %config(noreplace) %{_sysconfdir}/snmp/snmptrapd.conf
%{_bindir}/snmpconf %{_bindir}/snmpconf
%{_bindir}/agentxtrap %{_bindir}/agentxtrap
%{_bindir}/net-snmp-create-v3-user %{_bindir}/net-snmp-create-v3-user
@ -430,11 +428,10 @@ rm -rf ${RPM_BUILD_ROOT}
%dir %{_localstatedir}/run/net-snmp %dir %{_localstatedir}/run/net-snmp
%config(noreplace) %{_sysconfdir}/tmpfiles.d/net-snmp.conf %config(noreplace) %{_sysconfdir}/tmpfiles.d/net-snmp.conf
%{_unitdir}/snmp* %{_unitdir}/snmp*
%config(noreplace,missingok) %{_sysconfdir}/sysconfig/snmpd %config(noreplace) %{_sysconfdir}/sysconfig/snmpd
%config(noreplace,missingok) %{_sysconfdir}/sysconfig/snmptrapd %config(noreplace) %{_sysconfdir}/sysconfig/snmptrapd
%files utils %files utils
%defattr(-,root,root,-)
%{_bindir}/encode_keychange %{_bindir}/encode_keychange
%{_bindir}/snmp[^c-]* %{_bindir}/snmp[^c-]*
%attr(0644,root,root) %{_mandir}/man1/snmp[^-]*.1* %attr(0644,root,root) %{_mandir}/man1/snmp[^-]*.1*
@ -444,7 +441,6 @@ rm -rf ${RPM_BUILD_ROOT}
%attr(0644,root,root) %{_mandir}/man5/variables.5.gz %attr(0644,root,root) %{_mandir}/man5/variables.5.gz
%files devel %files devel
%defattr(0644,root,root,0755)
%{_libdir}/lib*.so %{_libdir}/lib*.so
/usr/include/* /usr/include/*
%attr(0644,root,root) %{_mandir}/man3/*.3.* %attr(0644,root,root) %{_mandir}/man3/*.3.*
@ -452,7 +448,6 @@ rm -rf ${RPM_BUILD_ROOT}
%attr(0644,root,root) %{_mandir}/man1/net-snmp-config*.1.* %attr(0644,root,root) %{_mandir}/man1/net-snmp-config*.1.*
%files perl %files perl
%defattr(-,root,root)
%{_bindir}/mib2c-update %{_bindir}/mib2c-update
%{_bindir}/mib2c %{_bindir}/mib2c
%{_bindir}/snmp-bridge-mib %{_bindir}/snmp-bridge-mib
@ -470,17 +465,14 @@ rm -rf ${RPM_BUILD_ROOT}
%{perl_vendorarch}/auto/Bundle/*SNMP* %{perl_vendorarch}/auto/Bundle/*SNMP*
%files python %files python
%defattr(-,root,root,-)
%doc README %doc README
%{python_sitearch}/* %{python_sitearch}/*
%files gui %files gui
%defattr(-,root,root)
%{_bindir}/tkmib %{_bindir}/tkmib
%attr(0644,root,root) %{_mandir}/man1/tkmib.1* %attr(0644,root,root) %{_mandir}/man1/tkmib.1*
%files libs %files libs
%defattr(-,root,root)
%doc COPYING README ChangeLog.trimmed FAQ NEWS TODO %doc COPYING README ChangeLog.trimmed FAQ NEWS TODO
%{_libdir}/libnetsnmp.so.* %{_libdir}/libnetsnmp.so.*
%dir %{_datadir}/snmp %dir %{_datadir}/snmp
@ -489,20 +481,19 @@ rm -rf ${RPM_BUILD_ROOT}
%dir %{_localstatedir}/lib/net-snmp %dir %{_localstatedir}/lib/net-snmp
%files agent-libs %files agent-libs
%defattr(-,root,root)
%{_libdir}/libnetsnmpagent*.so.* %{_libdir}/libnetsnmpagent*.so.*
%{_libdir}/libnetsnmphelpers*.so.* %{_libdir}/libnetsnmphelpers*.so.*
%{_libdir}/libnetsnmpmibs*.so.* %{_libdir}/libnetsnmpmibs*.so.*
%{_libdir}/libnetsnmptrapd*.so.* %{_libdir}/libnetsnmptrapd*.so.*
%files sysvinit %files sysvinit
%defattr(-,root,root)
%{_initrddir}/snmpd %{_initrddir}/snmpd
%{_initrddir}/snmptrapd %{_initrddir}/snmptrapd
%changelog %changelog
* Mon Aug 27 2012 Jan Safranek <jsafrane@redhat.com> - 1:5.7.1-10 * Mon Aug 27 2012 Jan Safranek <jsafrane@redhat.com> - 1:5.7.1-10
- Updated RPM scriplets with latest systemd-rpm macros (#850403) - Updated RPM scriplets with latest systemd-rpm macros (#850403).
- Fixed fedora-review tool complaints.
* Fri Jul 20 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1:5.7.1-9 * Fri Jul 20 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1:5.7.1-9
- Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild