import CS libxslt-1.1.34-10.el9_6
This commit is contained in:
parent
d2afd7867e
commit
5ea97cb51a
130
SOURCES/libxslt-1.1.34-CVE-2025-24855.patch
Normal file
130
SOURCES/libxslt-1.1.34-CVE-2025-24855.patch
Normal file
@ -0,0 +1,130 @@
|
|||||||
|
From c7c7f1f78dd202a053996fcefe57eb994aec8ef2 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Nick Wellnhofer <wellnhofer@aevum.de>
|
||||||
|
Date: Tue, 17 Dec 2024 15:56:21 +0100
|
||||||
|
Subject: [PATCH] [CVE-2025-24855] Fix use-after-free of XPath context node
|
||||||
|
|
||||||
|
There are several places where the XPath context node isn't restored
|
||||||
|
after modifying it, leading to use-after-free errors with nested XPath
|
||||||
|
evaluations and dynamically allocated context nodes.
|
||||||
|
|
||||||
|
Restore XPath context node in
|
||||||
|
|
||||||
|
- xsltNumberFormatGetValue
|
||||||
|
- xsltEvalXPathPredicate
|
||||||
|
- xsltEvalXPathStringNs
|
||||||
|
- xsltComputeSortResultInternal
|
||||||
|
|
||||||
|
In some places, the transformation context node was saved and restored
|
||||||
|
which shouldn't be necessary.
|
||||||
|
|
||||||
|
Thanks to Ivan Fratric for the report!
|
||||||
|
|
||||||
|
Fixes #128.
|
||||||
|
---
|
||||||
|
libxslt/numbers.c | 5 +++++
|
||||||
|
libxslt/templates.c | 9 ++++++---
|
||||||
|
libxslt/xsltutils.c | 4 ++--
|
||||||
|
3 files changed, 13 insertions(+), 5 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/libxslt/numbers.c b/libxslt/numbers.c
|
||||||
|
index 0e1fa136..741124d1 100644
|
||||||
|
--- a/libxslt/numbers.c
|
||||||
|
+++ b/libxslt/numbers.c
|
||||||
|
@@ -733,9 +733,12 @@ xsltNumberFormatGetValue(xmlXPathContextPtr context,
|
||||||
|
int amount = 0;
|
||||||
|
xmlBufferPtr pattern;
|
||||||
|
xmlXPathObjectPtr obj;
|
||||||
|
+ xmlNodePtr oldNode;
|
||||||
|
|
||||||
|
pattern = xmlBufferCreate();
|
||||||
|
if (pattern != NULL) {
|
||||||
|
+ oldNode = context->node;
|
||||||
|
+
|
||||||
|
xmlBufferCCat(pattern, "number(");
|
||||||
|
xmlBufferCat(pattern, value);
|
||||||
|
xmlBufferCCat(pattern, ")");
|
||||||
|
@@ -748,6 +751,8 @@ xsltNumberFormatGetValue(xmlXPathContextPtr context,
|
||||||
|
xmlXPathFreeObject(obj);
|
||||||
|
}
|
||||||
|
xmlBufferFree(pattern);
|
||||||
|
+
|
||||||
|
+ context->node = oldNode;
|
||||||
|
}
|
||||||
|
return amount;
|
||||||
|
}
|
||||||
|
diff --git a/libxslt/templates.c b/libxslt/templates.c
|
||||||
|
index f08b9bda..1c8d96e2 100644
|
||||||
|
--- a/libxslt/templates.c
|
||||||
|
+++ b/libxslt/templates.c
|
||||||
|
@@ -61,6 +61,7 @@ xsltEvalXPathPredicate(xsltTransformContextPtr ctxt, xmlXPathCompExprPtr comp,
|
||||||
|
int oldNsNr;
|
||||||
|
xmlNsPtr *oldNamespaces;
|
||||||
|
xmlNodePtr oldInst;
|
||||||
|
+ xmlNodePtr oldNode;
|
||||||
|
int oldProximityPosition, oldContextSize;
|
||||||
|
|
||||||
|
if ((ctxt == NULL) || (ctxt->inst == NULL)) {
|
||||||
|
@@ -69,6 +70,7 @@ xsltEvalXPathPredicate(xsltTransformContextPtr ctxt, xmlXPathCompExprPtr comp,
|
||||||
|
return(0);
|
||||||
|
}
|
||||||
|
|
||||||
|
+ oldNode = ctxt->xpathCtxt->node;
|
||||||
|
oldContextSize = ctxt->xpathCtxt->contextSize;
|
||||||
|
oldProximityPosition = ctxt->xpathCtxt->proximityPosition;
|
||||||
|
oldNsNr = ctxt->xpathCtxt->nsNr;
|
||||||
|
@@ -96,8 +98,9 @@ xsltEvalXPathPredicate(xsltTransformContextPtr ctxt, xmlXPathCompExprPtr comp,
|
||||||
|
ctxt->state = XSLT_STATE_STOPPED;
|
||||||
|
ret = 0;
|
||||||
|
}
|
||||||
|
- ctxt->xpathCtxt->nsNr = oldNsNr;
|
||||||
|
|
||||||
|
+ ctxt->xpathCtxt->node = oldNode;
|
||||||
|
+ ctxt->xpathCtxt->nsNr = oldNsNr;
|
||||||
|
ctxt->xpathCtxt->namespaces = oldNamespaces;
|
||||||
|
ctxt->inst = oldInst;
|
||||||
|
ctxt->xpathCtxt->contextSize = oldContextSize;
|
||||||
|
@@ -137,7 +140,7 @@ xsltEvalXPathStringNs(xsltTransformContextPtr ctxt, xmlXPathCompExprPtr comp,
|
||||||
|
}
|
||||||
|
|
||||||
|
oldInst = ctxt->inst;
|
||||||
|
- oldNode = ctxt->node;
|
||||||
|
+ oldNode = ctxt->xpathCtxt->node;
|
||||||
|
oldPos = ctxt->xpathCtxt->proximityPosition;
|
||||||
|
oldSize = ctxt->xpathCtxt->contextSize;
|
||||||
|
oldNsNr = ctxt->xpathCtxt->nsNr;
|
||||||
|
@@ -167,7 +170,7 @@ xsltEvalXPathStringNs(xsltTransformContextPtr ctxt, xmlXPathCompExprPtr comp,
|
||||||
|
"xsltEvalXPathString: returns %s\n", ret));
|
||||||
|
#endif
|
||||||
|
ctxt->inst = oldInst;
|
||||||
|
- ctxt->node = oldNode;
|
||||||
|
+ ctxt->xpathCtxt->node = oldNode;
|
||||||
|
ctxt->xpathCtxt->contextSize = oldSize;
|
||||||
|
ctxt->xpathCtxt->proximityPosition = oldPos;
|
||||||
|
ctxt->xpathCtxt->nsNr = oldNsNr;
|
||||||
|
diff --git a/libxslt/xsltutils.c b/libxslt/xsltutils.c
|
||||||
|
index 0e9dc62f..a20da961 100644
|
||||||
|
--- a/libxslt/xsltutils.c
|
||||||
|
+++ b/libxslt/xsltutils.c
|
||||||
|
@@ -1065,8 +1065,8 @@ xsltComputeSortResultInternal(xsltTransformContextPtr ctxt, xmlNodePtr sort,
|
||||||
|
return(NULL);
|
||||||
|
}
|
||||||
|
|
||||||
|
- oldNode = ctxt->node;
|
||||||
|
oldInst = ctxt->inst;
|
||||||
|
+ oldNode = ctxt->xpathCtxt->node;
|
||||||
|
oldPos = ctxt->xpathCtxt->proximityPosition;
|
||||||
|
oldSize = ctxt->xpathCtxt->contextSize;
|
||||||
|
oldNsNr = ctxt->xpathCtxt->nsNr;
|
||||||
|
@@ -1137,8 +1137,8 @@ xsltComputeSortResultInternal(xsltTransformContextPtr ctxt, xmlNodePtr sort,
|
||||||
|
results[i] = NULL;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
- ctxt->node = oldNode;
|
||||||
|
ctxt->inst = oldInst;
|
||||||
|
+ ctxt->xpathCtxt->node = oldNode;
|
||||||
|
ctxt->xpathCtxt->contextSize = oldSize;
|
||||||
|
ctxt->xpathCtxt->proximityPosition = oldPos;
|
||||||
|
ctxt->xpathCtxt->nsNr = oldNsNr;
|
||||||
|
--
|
||||||
|
GitLab
|
||||||
|
|
@ -1,7 +1,7 @@
|
|||||||
Name: libxslt
|
Name: libxslt
|
||||||
Summary: Library providing the Gnome XSLT engine
|
Summary: Library providing the Gnome XSLT engine
|
||||||
Version: 1.1.34
|
Version: 1.1.34
|
||||||
Release: 9%{?dist}
|
Release: 10%{?dist}
|
||||||
|
|
||||||
License: MIT
|
License: MIT
|
||||||
URL: http://xmlsoft.org/XSLT
|
URL: http://xmlsoft.org/XSLT
|
||||||
@ -24,6 +24,8 @@ Patch3: f165525fe744e6fe3b377b480d6cc5f9c546d360.patch
|
|||||||
Patch4: libxslt-1.1.34-tutorial2-dtd.patch
|
Patch4: libxslt-1.1.34-tutorial2-dtd.patch
|
||||||
# https://bugzilla.redhat.com/show_bug.cgi?id=2047653
|
# https://bugzilla.redhat.com/show_bug.cgi?id=2047653
|
||||||
Patch5: libxslt-1.1.34-test-fuzz-build.patch
|
Patch5: libxslt-1.1.34-test-fuzz-build.patch
|
||||||
|
# https://issues.redhat.com/browse/RHEL-83500
|
||||||
|
Patch6: libxslt-1.1.34-CVE-2025-24855.patch
|
||||||
|
|
||||||
%description
|
%description
|
||||||
This C library allows to transform XML files into other XML files
|
This C library allows to transform XML files into other XML files
|
||||||
@ -130,6 +132,9 @@ rm -vrf %{buildroot}%{_docdir}
|
|||||||
%endif
|
%endif
|
||||||
|
|
||||||
%changelog
|
%changelog
|
||||||
|
* Thu Mar 20 2025 David King <dking@redhat.com> - 1.1.34-10
|
||||||
|
- Fix CVE-2025-24855 (RHEL-83500)
|
||||||
|
|
||||||
* Fri Jan 28 2022 David King <amigadave@amigadave.com> - 1.1.34-9
|
* Fri Jan 28 2022 David King <amigadave@amigadave.com> - 1.1.34-9
|
||||||
- Fix validity of tutorial XML (#2047326)
|
- Fix validity of tutorial XML (#2047326)
|
||||||
- Fix build of tests/fuzz (#2047653)
|
- Fix build of tests/fuzz (#2047653)
|
||||||
|
Loading…
Reference in New Issue
Block a user