rpms/libservicelog
6
0
Fork 0
Code Issues Pull Requests Releases Activity

"-Werror=format-security" compilation option complains about the way

Browse Source 
we used some of the standard function (like snprintf) in our code.
Hence modified spec file to build binary without
"-Werror=format-security" option.

Note that this is the temporary workaround to build packages.
We should fix real issue in upstream code.

Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
This commit is contained in:
Vasant Hegde 2014-03-07 16:21:19 +05:30
parent ded9fe406f
commit 1730b326e7
3 changed files with 9 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
libservicelog-1.1.9-include.patch
View File

@ -1,11 +0,0 @@
diff -up libservicelog-1.1/src/v29_notify_gram.y.include libservicelog-1.1/src/v29_notify_gram.y
--- libservicelog-1.1/src/v29_notify_gram.y.include 2010-05-13 17:19:41.000000000 +0200
+++ libservicelog-1.1/src/v29_notify_gram.y 2010-05-13 17:19:55.000000000 +0200
@@ -26,6 +26,7 @@
#include "../servicelog-1/libservicelog.h"
#include <malloc.h>
#include <assert.h>
+#include "v29_notify_gram.h"
static struct v29_sl_notify *notify;
static int *semantic_errors;

10
libservicelog-1.1.9-install.patch
View File

@ -1,10 +0,0 @@
diff -up libservicelog-1.1/Makefile.am.install libservicelog-1.1/Makefile.am
--- libservicelog-1.1/Makefile.am.install 2009-10-30 04:32:27.000000000 +0100
+++ libservicelog-1.1/Makefile.am 2010-05-11 14:39:54.000000000 +0200
@@ -19,5 +19,5 @@ library_includedir = ${includedir}/servi
library_include_HEADERS = servicelog-1/servicelog.h servicelog-1/libservicelog.h
install-exec-hook:
- install -D --mode=754 --group=service servicelog.db \
+ install -D --mode=754 servicelog.db \
${DESTDIR}/var/lib/servicelog/servicelog.db

11
libservicelog.spec
View File

@ -1,6 +1,6 @@
Name: libservicelog
Version: 1.1.14
Release: 3%{?dist}
Release: 4%{?dist}
Summary: Servicelog Database and Library
Group: System Environment/Libraries
@ -44,7 +44,11 @@ Contains header files for building with libservicelog.
%build
autoreconf -fiv
%configure --disable-static
%{__make} %{?_smp_mflags}
# disable "-Werror=format-security" checking gcc option until we fix
# these errors are fixed in upstream code.
CFLAG="%{?_smp_mflags} -fPIC -DPIC"
CFLAG=`echo $CFLAG | sed 's/-Werror=format-security//'`
%{__make} $CFLAGS
%install
@ -80,6 +84,9 @@ getent group service >/dev/null || /usr/sbin/groupadd service
%changelog
* Fri Mar 07 2014 Vasant Hegde <hegdevasant@fedoraproject.org> - 1.1.14-4
- Disable "-Werror=format-security" gcc option
* Thu Oct 10 2013 Vasant Hegde <hegdevasant@linux.vnet.ibm.com> - 1.1.14-3
- Add ppc64le architecture