From 1730b326e7c8092d6c773e1f6cdcf4c17f1929fe Mon Sep 17 00:00:00 2001 From: Vasant Hegde Date: Fri, 7 Mar 2014 16:21:19 +0530 Subject: [PATCH] "-Werror=format-security" compilation option complains about the way we used some of the standard function (like snprintf) in our code. Hence modified spec file to build binary without "-Werror=format-security" option. Note that this is the temporary workaround to build packages. We should fix real issue in upstream code. Signed-off-by: Vasant Hegde --- libservicelog-1.1.9-include.patch | 11 ----------- libservicelog-1.1.9-install.patch | 10 ---------- libservicelog.spec | 11 +++++++++-- 3 files changed, 9 insertions(+), 23 deletions(-) delete mode 100644 libservicelog-1.1.9-include.patch delete mode 100644 libservicelog-1.1.9-install.patch diff --git a/libservicelog-1.1.9-include.patch b/libservicelog-1.1.9-include.patch deleted file mode 100644 index 8528a17..0000000 --- a/libservicelog-1.1.9-include.patch +++ /dev/null @@ -1,11 +0,0 @@ -diff -up libservicelog-1.1/src/v29_notify_gram.y.include libservicelog-1.1/src/v29_notify_gram.y ---- libservicelog-1.1/src/v29_notify_gram.y.include 2010-05-13 17:19:41.000000000 +0200 -+++ libservicelog-1.1/src/v29_notify_gram.y 2010-05-13 17:19:55.000000000 +0200 -@@ -26,6 +26,7 @@ - #include "../servicelog-1/libservicelog.h" - #include - #include -+#include "v29_notify_gram.h" - - static struct v29_sl_notify *notify; - static int *semantic_errors; diff --git a/libservicelog-1.1.9-install.patch b/libservicelog-1.1.9-install.patch deleted file mode 100644 index cdea5f6..0000000 --- a/libservicelog-1.1.9-install.patch +++ /dev/null @@ -1,10 +0,0 @@ -diff -up libservicelog-1.1/Makefile.am.install libservicelog-1.1/Makefile.am ---- libservicelog-1.1/Makefile.am.install 2009-10-30 04:32:27.000000000 +0100 -+++ libservicelog-1.1/Makefile.am 2010-05-11 14:39:54.000000000 +0200 -@@ -19,5 +19,5 @@ library_includedir = ${includedir}/servi - library_include_HEADERS = servicelog-1/servicelog.h servicelog-1/libservicelog.h - - install-exec-hook: -- install -D --mode=754 --group=service servicelog.db \ -+ install -D --mode=754 servicelog.db \ - ${DESTDIR}/var/lib/servicelog/servicelog.db diff --git a/libservicelog.spec b/libservicelog.spec index 33fc465..a984f28 100644 --- a/libservicelog.spec +++ b/libservicelog.spec @@ -1,6 +1,6 @@ Name: libservicelog Version: 1.1.14 -Release: 3%{?dist} +Release: 4%{?dist} Summary: Servicelog Database and Library Group: System Environment/Libraries @@ -44,7 +44,11 @@ Contains header files for building with libservicelog. %build autoreconf -fiv %configure --disable-static -%{__make} %{?_smp_mflags} +# disable "-Werror=format-security" checking gcc option until we fix +# these errors are fixed in upstream code. +CFLAG="%{?_smp_mflags} -fPIC -DPIC" +CFLAG=`echo $CFLAG | sed 's/-Werror=format-security//'` +%{__make} $CFLAGS %install @@ -80,6 +84,9 @@ getent group service >/dev/null || /usr/sbin/groupadd service %changelog +* Fri Mar 07 2014 Vasant Hegde - 1.1.14-4 +- Disable "-Werror=format-security" gcc option + * Thu Oct 10 2013 Vasant Hegde - 1.1.14-3 - Add ppc64le architecture