Commit Graph

21 Commits

Author SHA1 Message Date
Dave Young
e02ec8b7e8 firstboot: add automatic and manual memory reservation for rhel
Add two radiobuttons for user to select automatic/manual memory reserve
For fedora they will not be added.

When switching from manual configure to auto reserve, the memory size and
summary widgets will be dimmed.

Testing below cases on virtual machine, all cases need reboot and verify:
Fedora:
1. Enable/Disable kdump
2. change reserve size
3. change kdump.conf content
4. Auto -> Manual
5. Manual -> Auto

RHEL:
modify the /etc/redhat-release and install the rhel7 kernel rpm in fedora vm.
1. auto reservation
2. manual specify reserve mem size
3. enable/disable kdump
4. change kdump.conf content

Vivek: label with text "Memory To Be Reserved"

Signed-off-by: Dave Young <dyoung@redhat.com>
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-28 16:22:35 +08:00
Dave Young
97aea9a995 firstboot: remove unnecessary underline shortkey
The '_' before UI string is for Alt+TheFirstCharacter shortkey
ie. Press Alt+T will focus on the self.totalMem widget.

But the totalMem and systemUsableMem are not configurable, so
this is in fact unnecessary. OTOH, The 'Alt+T' will be used in later
patches, so remove these two here.

Signed-off-by: Dave Young <dyoung@redhat.com>
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-28 16:22:25 +08:00
Dave Young
dc5f48e90a firstboot: fix gtk warning about non-zero page size
Pygtk documentation says the page size field is not used, but actually
there will be a gtk warning below:

/usr/share/firstboot/modules/firstboot_kdump.py:216: GtkWarning: GtkSpinButton: setting an adjustment with non-zero page size is deprecated
  self.kdumpMemspin = gtk.SpinButton(self.memAdjustment, 0, 0)

Fix it by setting the last field to 0.

Signed-off-by: Dave Young <dyoung@redhat.com>
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-28 16:22:15 +08:00
Dave Young
ed4d7a3865 firstboot: update all kernels config in grubbyCmd
Per vivek, update all kernels configs in grub config file make more sense.

use --update-kernel=ALL to update all grub entries.

Signed-off-by: Dave Young <dyoung@redhat.com>
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-28 16:22:11 +08:00
Dave Young
caf1c13f53 firstboot: add actual reserved memory widget
Memory reservation could fail, so add a new widget to show the
actual reserved size. If crashkernel is set but reserved size is
0, we still regard kdump is enabled, the actual reserved widget
just show the reservation status.

vivek: label with text "Memory Currently Reserved"

Signed-off-by: Dave Young <dyoung@redhat.com>
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-28 16:22:06 +08:00
Dave Young
1c9add2a5f firstboot code cleanup
variables and code cleanup
For example, below variables are changed:
kdumpMem -> kdumpMemspin
memSpin -> memAdjustment
remMem -> remainingMem
resMem -> reserveMem
kdumpMem -> reservedMem

Signed-off-by: Dave Young <dyoung@redhat.com>
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-28 16:21:55 +08:00
Dave Young
c12a3216c5 Remove the kernel-kdump handling
Fedora firstboot will alert about requiring a kernel-kdump
for x86, this is not true. In fact all arches what we support
do not depend on kernel-kdump any more.

Thus remove the kernel-kdump handling in firstboot.

Signed-off-by: Dave Young <dyoung@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-09 10:22:50 +08:00
Dave Young
4b061633b3 s390x firstboot fix
Resolves: bz805782

1. remove s390x from unsupported archs
2. add s390x bootloader handling

Signed-off-by: Dave Young <dyoung@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-09 10:22:50 +08:00
Dave Young
ea29dbf667 remove elilo support
Resolves: bz805782

elilo is deprecated in fedora, so remove the elilo support in firstboot module.

Signed-off-by: Dave Young <dyoung@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-09 10:22:50 +08:00
Dave Young
36ece6081d grub2 fix in firstboot
Resolves: bz805782

Update to use grub2, also update the config file names

Signed-off-by: Dave Young <dyoung@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-09 10:22:50 +08:00
Dave Young
2b11d78e2e Take closing the reboot dialog as no
Resolves: bz805782

Copying something from old bug 688150:
Steps to Reproduce:
1.Go through FirstBoot process while get to Kdump
2.Change Kdump memory
3.Press Finish
4.A window pops-up (Changing Kdump setting requires ...)
5.Do not press "No" or "Yes" but pres the "X"  in the right up corner.

Actual results:
The effect of this action is the same as pressing "YES"

Expected results:
The effect of this action is the same as pressing "NO

So this patch fix to only reboot when rc == gtk.RESPONSE_YES.

Port from below patch from rhel:
commit ed0c89d8e42b9205671cb6c81f9f73c275bee72f
Author: amwang <amwang@redhat.com>
Date:   Thu Mar 17 10:07:52 2011 +0000

    Resolves: bug 688150.

Signed-off-by: Dave Young <dyoung@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-09 10:22:50 +08:00
Dave Young
dfb10612a2 Handle new crashkernel= syntax in firstboot
Resolves: bz805782

Port from below patch from rhel:
commit 6a6816e97fccaf7805ba9d04fcb3f58d87bd2517
Author: amwang <amwang@redhat.com>
Date:   Fri Feb 11 06:53:27 2011 +0000

    Resolves: bug 676758.

Signed-off-by: Dave Young <dyoung@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-09 10:22:49 +08:00
Dave Young
a3ee4fffe0 Fix a localized string in firstboot
Resolves: bz805782

The text of gtk checkbutton for enable kdump was not localized.
Add gettext _() around it to make it translatable.

[update]:
-add changelog

Port below patch from rhel:
commit ce18ccc9557137b276471fbe200d7a18ce90fcf5
Author: amwang <amwang@redhat.com>
Date:   Mon Aug 9 08:20:34 2010 +0000

    Resolves: bug 619744.

Signed-off-by: Dave Young <dyoung@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-09 10:22:49 +08:00
Dave Young
4020f959c1 Configure kdump in firstboot
Resolves: bz805782
Make kdump configurable in firstboot

Add an advanced kdump config text widget, so user can configure
kdump.conf in firstboot,
[update]:
-add changelog
-remove unused variable

Port below patch from rhel:
commit e5ac50339e73b11cd9d5ba91712c43cce7ffcbcb
Author: amwang <amwang@redhat.com>
Date:   Thu Mar 17 09:18:13 2011 +0000

    Resolves: bug 598064.

Signed-off-by: Dave Young <dyoung@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-09 10:22:49 +08:00
Dave Young
752aaaa48c fix firstboot to ensure kdump svc is disabled properly
Resolves: bz805782

in case kdump is disabled, we also need to disable the kdump service
This patch is ported from below rhel patch, changed below two issues though:
1. fixed the systemctl line
2. dropped an useless line for using 0 for gtk adjustment page_size field.
see http://www.pygtk.org/pygtk2tutorial/sec-SpinButtons.html for the field doc.

Rhel6 commit is below:
commit c5735dee743fa41d14635fe2fbf5f48264bc36f6
Author: nhorman <nhorman@redhat.com>
Date:   Thu Jul 29 15:52:00 2010 +0000

    Resolves: bz 594830

Signed-off-by: Dave Young <dyoung@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-09 10:22:49 +08:00
Dave Young
a0281590ae firstboot text domain fix
Resolves: bz805782

the text domain should be kexec-tools instead of firstboot,
or it kexec-tools translation will not find the right .mo

Backport from rhel6 bz619061
commit 18de84f91906ec41b2640f67d21eef39ecb0833b
Author: amwang <amwang@redhat.com>
Date:   Fri Jul 30 02:45:52 2010 +0000

    Resolves: bug 619061.

Signed-off-by: Dave Young <dyoung@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-09 10:22:48 +08:00
Dave Young
f1638fbe8a Update to use systemctl instead of sysv chkconfig
use systemctl to check/set the service enable/disable status

Signed-off-by: Dave Young <dyoung@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
2012-08-09 10:22:48 +08:00
Lubomir Rintel
dc002368a1 Pull EL6 kdump fixes into Rawhide Resolves: 597588 2010-06-13 19:20:48 +00:00
Neil Horman
b3f251cfd0 Resolves: bz539812 2009-11-23 16:17:42 +00:00
Neil Horman
9487d3dfb1 Fixing firstboot module 2009-06-23 18:36:27 +00:00
Neil Horman
d3c4b95f8a Updating fc7 with all RHEL5 work 2006-12-15 21:05:01 +00:00