668 lines
29 KiB
Diff
668 lines
29 KiB
Diff
From patchwork Tue Mar 10 12:52:39 2020
|
|
Content-Type: text/plain; charset="utf-8"
|
|
MIME-Version: 1.0
|
|
Content-Transfer-Encoding: 7bit
|
|
X-Patchwork-Submitter: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
X-Patchwork-Id: 11429251
|
|
Return-Path:
|
|
<SRS0=oUlM=43=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org>
|
|
Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org
|
|
[172.30.200.123])
|
|
by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8D720924
|
|
for <patchwork-linux-arm@patchwork.kernel.org>;
|
|
Tue, 10 Mar 2020 12:53:32 +0000 (UTC)
|
|
Received: from bombadil.infradead.org (bombadil.infradead.org
|
|
[198.137.202.133])
|
|
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
|
|
(No client certificate requested)
|
|
by mail.kernel.org (Postfix) with ESMTPS id 663C724693
|
|
for <patchwork-linux-arm@patchwork.kernel.org>;
|
|
Tue, 10 Mar 2020 12:53:32 +0000 (UTC)
|
|
Authentication-Results: mail.kernel.org;
|
|
dkim=pass (2048-bit key) header.d=lists.infradead.org
|
|
header.i=@lists.infradead.org header.b="brxu2SSp"
|
|
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 663C724693
|
|
Authentication-Results: mail.kernel.org;
|
|
dmarc=none (p=none dis=none) header.from=suse.de
|
|
Authentication-Results: mail.kernel.org;
|
|
spf=none
|
|
smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org
|
|
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
|
|
d=lists.infradead.org; s=bombadil.20170209; h=Sender:
|
|
Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:
|
|
List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:
|
|
Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description:
|
|
Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:
|
|
List-Owner; bh=ZW8pFtwlUj3q7GZJotB4Rgjtfp9gMy+l74jJQcTab0w=; b=brxu2SSpvrhJNb
|
|
w5nIpDDyBZwSbCT9/lV2mTMlmQYmRJmzfp6qMUdidNb6M06u9vNMEUs7Ux1xhzZ+2kUiHMGdYmySb
|
|
2ZTluMYsD0wDWn/cBbbQSTAVeWuM5loKbQx7f6YtApSP/BRhwHyQT2hOCH5FQsO4upkRzvyiu1oDy
|
|
RFlB4bVwhxeh0DLHk4treOY7PH07MfqozbH1deQqmRPbrtHmPfNqVfuLHJoWQUyHBobxUu8VcPdIN
|
|
hznwXAVJBLYVLiKMQQ+KFCAaj2Qhv5LbtahIMlTj8qx3PdD4LASzktKkD/iUYd358hJSk43gJpAIe
|
|
812yC2v21Pex7ZCY06ag==;
|
|
Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org)
|
|
by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux))
|
|
id 1jBeO2-0004Ny-7z; Tue, 10 Mar 2020 12:53:30 +0000
|
|
Received: from mx2.suse.de ([195.135.220.15])
|
|
by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux))
|
|
id 1jBeNk-00048F-6W; Tue, 10 Mar 2020 12:53:13 +0000
|
|
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
|
|
Received: from relay2.suse.de (unknown [195.135.220.254])
|
|
by mx2.suse.de (Postfix) with ESMTP id DF3D2B149;
|
|
Tue, 10 Mar 2020 12:53:10 +0000 (UTC)
|
|
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
To: linux-kernel@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
|
|
Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>,
|
|
bcm-kernel-feedback-list@broadcom.com,
|
|
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
Subject: [PATCH v5 1/4] soc: bcm2835: Sync xHCI reset firmware property with
|
|
downstream
|
|
Date: Tue, 10 Mar 2020 13:52:39 +0100
|
|
Message-Id: <20200310125243.25805-2-nsaenzjulienne@suse.de>
|
|
X-Mailer: git-send-email 2.25.1
|
|
In-Reply-To: <20200310125243.25805-1-nsaenzjulienne@suse.de>
|
|
References: <20200310125243.25805-1-nsaenzjulienne@suse.de>
|
|
MIME-Version: 1.0
|
|
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3
|
|
X-CRM114-CacheID: sfid-20200310_055312_379726_E2DB0CE8
|
|
X-CRM114-Status: GOOD ( 13.79 )
|
|
X-Spam-Score: -2.3 (--)
|
|
X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary:
|
|
Content analysis details: (-2.3 points)
|
|
pts rule name description
|
|
---- ----------------------
|
|
--------------------------------------------------
|
|
-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,
|
|
medium trust [195.135.220.15 listed in list.dnswl.org]
|
|
0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
|
|
[195.135.220.15 listed in wl.mailspike.net]
|
|
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
|
|
-0.0 SPF_PASS SPF: sender matches SPF record
|
|
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
|
|
X-BeenThere: linux-arm-kernel@lists.infradead.org
|
|
X-Mailman-Version: 2.1.29
|
|
Precedence: list
|
|
List-Id: <linux-arm-kernel.lists.infradead.org>
|
|
List-Unsubscribe:
|
|
<http://lists.infradead.org/mailman/options/linux-arm-kernel>,
|
|
<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
|
|
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
|
|
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
|
|
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
|
|
List-Subscribe:
|
|
<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,
|
|
<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
|
|
Cc: tim.gover@raspberrypi.org, sergei.shtylyov@cogentembedded.com,
|
|
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
|
|
linux-rpi-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
|
|
linux-arm-kernel@lists.infradead.org, wahrenst@gmx.net
|
|
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
|
|
Errors-To:
|
|
linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org
|
|
|
|
The property is needed in order to trigger VL805's firmware load. Note
|
|
that there is a gap between the property introduced and the previous
|
|
one. This is also the case downstream.
|
|
|
|
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
|
|
---
|
|
include/soc/bcm2835/raspberrypi-firmware.h | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h
|
|
index 7800e12ee042..cc9cdbc66403 100644
|
|
--- a/include/soc/bcm2835/raspberrypi-firmware.h
|
|
+++ b/include/soc/bcm2835/raspberrypi-firmware.h
|
|
@@ -90,7 +90,7 @@ enum rpi_firmware_property_tag {
|
|
RPI_FIRMWARE_SET_PERIPH_REG = 0x00038045,
|
|
RPI_FIRMWARE_GET_POE_HAT_VAL = 0x00030049,
|
|
RPI_FIRMWARE_SET_POE_HAT_VAL = 0x00030050,
|
|
-
|
|
+ RPI_FIRMWARE_NOTIFY_XHCI_RESET = 0x00030058,
|
|
|
|
/* Dispmanx TAGS */
|
|
RPI_FIRMWARE_FRAMEBUFFER_ALLOCATE = 0x00040001,
|
|
|
|
From patchwork Tue Mar 10 12:52:40 2020
|
|
Content-Type: text/plain; charset="utf-8"
|
|
MIME-Version: 1.0
|
|
Content-Transfer-Encoding: 7bit
|
|
X-Patchwork-Submitter: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
X-Patchwork-Id: 11429255
|
|
Return-Path:
|
|
<SRS0=oUlM=43=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org>
|
|
Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org
|
|
[172.30.200.123])
|
|
by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D4796138D
|
|
for <patchwork-linux-arm@patchwork.kernel.org>;
|
|
Tue, 10 Mar 2020 12:53:47 +0000 (UTC)
|
|
Received: from bombadil.infradead.org (bombadil.infradead.org
|
|
[198.137.202.133])
|
|
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
|
|
(No client certificate requested)
|
|
by mail.kernel.org (Postfix) with ESMTPS id B22E52468F
|
|
for <patchwork-linux-arm@patchwork.kernel.org>;
|
|
Tue, 10 Mar 2020 12:53:47 +0000 (UTC)
|
|
Authentication-Results: mail.kernel.org;
|
|
dkim=pass (2048-bit key) header.d=lists.infradead.org
|
|
header.i=@lists.infradead.org header.b="UnuFVkmk"
|
|
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B22E52468F
|
|
Authentication-Results: mail.kernel.org;
|
|
dmarc=none (p=none dis=none) header.from=suse.de
|
|
Authentication-Results: mail.kernel.org;
|
|
spf=none
|
|
smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org
|
|
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
|
|
d=lists.infradead.org; s=bombadil.20170209; h=Sender:
|
|
Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:
|
|
List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:
|
|
Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description:
|
|
Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:
|
|
List-Owner; bh=eupkp4tsmm4bLugl948LTwuMnwmoAOiN5fj7gGg2GJM=; b=UnuFVkmkE9iLlT
|
|
dNztNBOsbtwlARvXfPvQbXyhiNZOH0emv3kmr+XxltWYeAiqH5UzUtJy0KwjF2KunmcjkiSOmBj0b
|
|
YDxYVIOUXPbof4UrgceWbINbqzOpy703aw8B2pWaXc2Fx+tkQI31pG+fHwB1TSaAXnCU0ClY85soE
|
|
suAOeomFWgZYxgZBIqem7oslnqdQ6KgACCkliCU3dEKd+XX/hZA9C2J0N/EgEwcNWXEmKB9PdwTli
|
|
2lAYh1TlEnx1fuRLvs8UyVj+r4BpSYgTcvEoy1eI12XtX708NuiE57pnSZn3Xc+2EI2fzW/7FowQ/
|
|
edW61tscKfv3VMYGGa4A==;
|
|
Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org)
|
|
by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux))
|
|
id 1jBeOE-0004am-Pw; Tue, 10 Mar 2020 12:53:42 +0000
|
|
Received: from mx2.suse.de ([195.135.220.15])
|
|
by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux))
|
|
id 1jBeNl-00048m-7v; Tue, 10 Mar 2020 12:53:14 +0000
|
|
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
|
|
Received: from relay2.suse.de (unknown [195.135.220.254])
|
|
by mx2.suse.de (Postfix) with ESMTP id EF846B18F;
|
|
Tue, 10 Mar 2020 12:53:11 +0000 (UTC)
|
|
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
To: linux-kernel@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
|
|
Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>,
|
|
bcm-kernel-feedback-list@broadcom.com,
|
|
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
Subject: [PATCH v5 2/4] firmware: raspberrypi: Introduce vl805 init routine
|
|
Date: Tue, 10 Mar 2020 13:52:40 +0100
|
|
Message-Id: <20200310125243.25805-3-nsaenzjulienne@suse.de>
|
|
X-Mailer: git-send-email 2.25.1
|
|
In-Reply-To: <20200310125243.25805-1-nsaenzjulienne@suse.de>
|
|
References: <20200310125243.25805-1-nsaenzjulienne@suse.de>
|
|
MIME-Version: 1.0
|
|
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3
|
|
X-CRM114-CacheID: sfid-20200310_055313_564661_57DD1A42
|
|
X-CRM114-Status: GOOD ( 15.58 )
|
|
X-Spam-Score: -2.3 (--)
|
|
X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary:
|
|
Content analysis details: (-2.3 points)
|
|
pts rule name description
|
|
---- ----------------------
|
|
--------------------------------------------------
|
|
-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,
|
|
medium trust [195.135.220.15 listed in list.dnswl.org]
|
|
0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
|
|
[195.135.220.15 listed in wl.mailspike.net]
|
|
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
|
|
-0.0 SPF_PASS SPF: sender matches SPF record
|
|
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
|
|
X-BeenThere: linux-arm-kernel@lists.infradead.org
|
|
X-Mailman-Version: 2.1.29
|
|
Precedence: list
|
|
List-Id: <linux-arm-kernel.lists.infradead.org>
|
|
List-Unsubscribe:
|
|
<http://lists.infradead.org/mailman/options/linux-arm-kernel>,
|
|
<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
|
|
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
|
|
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
|
|
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
|
|
List-Subscribe:
|
|
<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,
|
|
<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
|
|
Cc: tim.gover@raspberrypi.org, sergei.shtylyov@cogentembedded.com,
|
|
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
|
|
linux-rpi-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
|
|
linux-arm-kernel@lists.infradead.org, wahrenst@gmx.net
|
|
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
|
|
Errors-To:
|
|
linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org
|
|
|
|
On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be
|
|
loaded directly from an EEPROM or, if not present, by the SoC's
|
|
VideCore. The function informs VideCore that VL805 was just reset, or
|
|
requests for a probe defer.
|
|
|
|
Based on Tim Gover's downstream implementation.
|
|
|
|
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
|
|
---
|
|
|
|
Changes since v4:
|
|
- Inline function definition when RASPBERRYPI_FIRMWARE is not defined
|
|
|
|
Changes since v1:
|
|
- Move include into .c file and add forward declaration to .h
|
|
|
|
drivers/firmware/raspberrypi.c | 38 ++++++++++++++++++++++
|
|
include/soc/bcm2835/raspberrypi-firmware.h | 7 ++++
|
|
2 files changed, 45 insertions(+)
|
|
|
|
diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
|
|
index da26a584dca0..cbb495aff6a0 100644
|
|
--- a/drivers/firmware/raspberrypi.c
|
|
+++ b/drivers/firmware/raspberrypi.c
|
|
@@ -12,6 +12,7 @@
|
|
#include <linux/of_platform.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
+#include <linux/pci.h>
|
|
#include <soc/bcm2835/raspberrypi-firmware.h>
|
|
|
|
#define MBOX_MSG(chan, data28) (((data28) & ~0xf) | ((chan) & 0xf))
|
|
@@ -286,6 +287,43 @@ struct rpi_firmware *rpi_firmware_get(struct device_node *firmware_node)
|
|
}
|
|
EXPORT_SYMBOL_GPL(rpi_firmware_get);
|
|
|
|
+/*
|
|
+ * On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be
|
|
+ * loaded directly from an EEPROM or, if not present, by the SoC's VideCore.
|
|
+ * Inform VideCore that VL805 was just reset, or defer xhci's probe if not yet
|
|
+ * joinable trough the mailbox interface.
|
|
+ */
|
|
+int rpi_firmware_init_vl805(struct pci_dev *pdev)
|
|
+{
|
|
+ struct device_node *fw_np;
|
|
+ struct rpi_firmware *fw;
|
|
+ u32 dev_addr;
|
|
+ int ret;
|
|
+
|
|
+ fw_np = of_find_compatible_node(NULL, NULL,
|
|
+ "raspberrypi,bcm2835-firmware");
|
|
+ if (!fw_np)
|
|
+ return 0;
|
|
+
|
|
+ fw = rpi_firmware_get(fw_np);
|
|
+ of_node_put(fw_np);
|
|
+ if (!fw)
|
|
+ return -EPROBE_DEFER;
|
|
+
|
|
+ dev_addr = pdev->bus->number << 20 | PCI_SLOT(pdev->devfn) << 15 |
|
|
+ PCI_FUNC(pdev->devfn) << 12;
|
|
+
|
|
+ ret = rpi_firmware_property(fw, RPI_FIRMWARE_NOTIFY_XHCI_RESET,
|
|
+ &dev_addr, sizeof(dev_addr));
|
|
+ if (ret)
|
|
+ return ret;
|
|
+
|
|
+ dev_dbg(&pdev->dev, "loaded Raspberry Pi's VL805 firmware\n");
|
|
+
|
|
+ return 0;
|
|
+}
|
|
+EXPORT_SYMBOL_GPL(rpi_firmware_init_vl805);
|
|
+
|
|
static const struct of_device_id rpi_firmware_of_match[] = {
|
|
{ .compatible = "raspberrypi,bcm2835-firmware", },
|
|
{},
|
|
diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h
|
|
index cc9cdbc66403..3025aca3c358 100644
|
|
--- a/include/soc/bcm2835/raspberrypi-firmware.h
|
|
+++ b/include/soc/bcm2835/raspberrypi-firmware.h
|
|
@@ -10,6 +10,7 @@
|
|
#include <linux/of_device.h>
|
|
|
|
struct rpi_firmware;
|
|
+struct pci_dev;
|
|
|
|
enum rpi_firmware_property_status {
|
|
RPI_FIRMWARE_STATUS_REQUEST = 0,
|
|
@@ -141,6 +142,7 @@ int rpi_firmware_property(struct rpi_firmware *fw,
|
|
int rpi_firmware_property_list(struct rpi_firmware *fw,
|
|
void *data, size_t tag_size);
|
|
struct rpi_firmware *rpi_firmware_get(struct device_node *firmware_node);
|
|
+int rpi_firmware_init_vl805(struct pci_dev *pdev);
|
|
#else
|
|
static inline int rpi_firmware_property(struct rpi_firmware *fw, u32 tag,
|
|
void *data, size_t len)
|
|
@@ -158,6 +160,11 @@ static inline struct rpi_firmware *rpi_firmware_get(struct device_node *firmware
|
|
{
|
|
return NULL;
|
|
}
|
|
+
|
|
+static inline int rpi_firmware_init_vl805(struct pci_dev *pdev)
|
|
+{
|
|
+ return 0;
|
|
+}
|
|
#endif
|
|
|
|
#endif /* __SOC_RASPBERRY_FIRMWARE_H__ */
|
|
|
|
From patchwork Tue Mar 10 12:52:41 2020
|
|
Content-Type: text/plain; charset="utf-8"
|
|
MIME-Version: 1.0
|
|
Content-Transfer-Encoding: 7bit
|
|
X-Patchwork-Submitter: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
X-Patchwork-Id: 11429257
|
|
Return-Path:
|
|
<SRS0=oUlM=43=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org>
|
|
Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org
|
|
[172.30.200.123])
|
|
by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DB7DF924
|
|
for <patchwork-linux-arm@patchwork.kernel.org>;
|
|
Tue, 10 Mar 2020 12:54:01 +0000 (UTC)
|
|
Received: from bombadil.infradead.org (bombadil.infradead.org
|
|
[198.137.202.133])
|
|
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
|
|
(No client certificate requested)
|
|
by mail.kernel.org (Postfix) with ESMTPS id B8AF22468F
|
|
for <patchwork-linux-arm@patchwork.kernel.org>;
|
|
Tue, 10 Mar 2020 12:54:01 +0000 (UTC)
|
|
Authentication-Results: mail.kernel.org;
|
|
dkim=pass (2048-bit key) header.d=lists.infradead.org
|
|
header.i=@lists.infradead.org header.b="Pukt5VBt"
|
|
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8AF22468F
|
|
Authentication-Results: mail.kernel.org;
|
|
dmarc=none (p=none dis=none) header.from=suse.de
|
|
Authentication-Results: mail.kernel.org;
|
|
spf=none
|
|
smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org
|
|
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
|
|
d=lists.infradead.org; s=bombadil.20170209; h=Sender:
|
|
Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:
|
|
List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:
|
|
Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description:
|
|
Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:
|
|
List-Owner; bh=BdoGeNn/NWcbYVlSIJeeADhjLPnS4htif3Z9tAGsAwY=; b=Pukt5VBtbAyyHT
|
|
Fl05OgBfjiC6FzMq3vCA9/PjIVGnDl7+C9Y63M8cdUbsobWVut0YWAFVbxQgaQz235gW9sfpGxt/V
|
|
mD8vzLqKf6uRRow1iQWGR7cZhKOwWGYd/zGoyQtwE5MR06gK9hYUwfDs7irt11GsjJaAH7uoWvpnV
|
|
1st3tm/ScoO386zatdiMdGhSNU1I42NGKUCH6evFgkwPeoqs0P4NYMA3W2Xnb4VECrMGeEdZLG1bw
|
|
5H3WNE1+8q3HSuXB/qNxf1kgajM102CNfhPWAm9FE9nh/PyRbe/6lrUEy+pFEKOXLWCp4sSHVRek5
|
|
57BW6iK719eKvyQ3iNbg==;
|
|
Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org)
|
|
by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux))
|
|
id 1jBeOV-0004sJ-68; Tue, 10 Mar 2020 12:53:59 +0000
|
|
Received: from mx2.suse.de ([195.135.220.15])
|
|
by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux))
|
|
id 1jBeNm-00049C-8J; Tue, 10 Mar 2020 12:53:15 +0000
|
|
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
|
|
Received: from relay2.suse.de (unknown [195.135.220.254])
|
|
by mx2.suse.de (Postfix) with ESMTP id E5116B1B1;
|
|
Tue, 10 Mar 2020 12:53:12 +0000 (UTC)
|
|
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
To: linux-kernel@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
|
|
bcm-kernel-feedback-list@broadcom.com,
|
|
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
|
|
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
|
|
Andrew Murray <amurray@thegoodpenguin.co.uk>
|
|
Subject: [PATCH v5 3/4] PCI: brcmstb: Wait for Raspberry Pi's firmware when
|
|
present
|
|
Date: Tue, 10 Mar 2020 13:52:41 +0100
|
|
Message-Id: <20200310125243.25805-4-nsaenzjulienne@suse.de>
|
|
X-Mailer: git-send-email 2.25.1
|
|
In-Reply-To: <20200310125243.25805-1-nsaenzjulienne@suse.de>
|
|
References: <20200310125243.25805-1-nsaenzjulienne@suse.de>
|
|
MIME-Version: 1.0
|
|
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3
|
|
X-CRM114-CacheID: sfid-20200310_055314_439377_DE6EBA94
|
|
X-CRM114-Status: GOOD ( 12.27 )
|
|
X-Spam-Score: -2.3 (--)
|
|
X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary:
|
|
Content analysis details: (-2.3 points)
|
|
pts rule name description
|
|
---- ----------------------
|
|
--------------------------------------------------
|
|
-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,
|
|
medium trust [195.135.220.15 listed in list.dnswl.org]
|
|
0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
|
|
[195.135.220.15 listed in wl.mailspike.net]
|
|
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
|
|
-0.0 SPF_PASS SPF: sender matches SPF record
|
|
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
|
|
X-BeenThere: linux-arm-kernel@lists.infradead.org
|
|
X-Mailman-Version: 2.1.29
|
|
Precedence: list
|
|
List-Id: <linux-arm-kernel.lists.infradead.org>
|
|
List-Unsubscribe:
|
|
<http://lists.infradead.org/mailman/options/linux-arm-kernel>,
|
|
<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
|
|
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
|
|
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
|
|
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
|
|
List-Subscribe:
|
|
<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,
|
|
<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
|
|
Cc: tim.gover@raspberrypi.org, sergei.shtylyov@cogentembedded.com,
|
|
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
|
|
linux-rpi-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
|
|
Bjorn Helgaas <bhelgaas@google.com>, linux-arm-kernel@lists.infradead.org,
|
|
wahrenst@gmx.net
|
|
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
|
|
Errors-To:
|
|
linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org
|
|
|
|
xHCI's PCI fixup, run at the end of pcie-brcmstb's probe, depends on
|
|
RPi4's VideoCore firmware interface to be up and running. It's possible
|
|
for both initializations to race, so make sure it's available prior to
|
|
starting.
|
|
|
|
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
|
|
---
|
|
|
|
Changes since v4:
|
|
- Fixed typo in commit description
|
|
|
|
drivers/pci/controller/pcie-brcmstb.c | 15 +++++++++++++++
|
|
1 file changed, 15 insertions(+)
|
|
|
|
diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
|
|
index 3a10e678c7f4..a3d3070a5832 100644
|
|
--- a/drivers/pci/controller/pcie-brcmstb.c
|
|
+++ b/drivers/pci/controller/pcie-brcmstb.c
|
|
@@ -28,6 +28,8 @@
|
|
#include <linux/string.h>
|
|
#include <linux/types.h>
|
|
|
|
+#include <soc/bcm2835/raspberrypi-firmware.h>
|
|
+
|
|
#include "../pci.h"
|
|
|
|
/* BRCM_PCIE_CAP_REGS - Offset for the mandatory capability config regs */
|
|
@@ -917,11 +919,24 @@ static int brcm_pcie_probe(struct platform_device *pdev)
|
|
{
|
|
struct device_node *np = pdev->dev.of_node, *msi_np;
|
|
struct pci_host_bridge *bridge;
|
|
+ struct device_node *fw_np;
|
|
struct brcm_pcie *pcie;
|
|
struct pci_bus *child;
|
|
struct resource *res;
|
|
int ret;
|
|
|
|
+ /*
|
|
+ * We have to wait for the Raspberry Pi's firmware interface to be up
|
|
+ * as some PCI fixups depend on it.
|
|
+ */
|
|
+ fw_np = of_find_compatible_node(NULL, NULL,
|
|
+ "raspberrypi,bcm2835-firmware");
|
|
+ if (fw_np && !rpi_firmware_get(fw_np)) {
|
|
+ of_node_put(fw_np);
|
|
+ return -EPROBE_DEFER;
|
|
+ }
|
|
+ of_node_put(fw_np);
|
|
+
|
|
bridge = devm_pci_alloc_host_bridge(&pdev->dev, sizeof(*pcie));
|
|
if (!bridge)
|
|
return -ENOMEM;
|
|
|
|
From patchwork Tue Mar 10 12:52:42 2020
|
|
Content-Type: text/plain; charset="utf-8"
|
|
MIME-Version: 1.0
|
|
Content-Transfer-Encoding: 7bit
|
|
X-Patchwork-Submitter: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
X-Patchwork-Id: 11429259
|
|
Return-Path:
|
|
<SRS0=oUlM=43=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org>
|
|
Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org
|
|
[172.30.200.123])
|
|
by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9C04D924
|
|
for <patchwork-linux-arm@patchwork.kernel.org>;
|
|
Tue, 10 Mar 2020 12:54:22 +0000 (UTC)
|
|
Received: from bombadil.infradead.org (bombadil.infradead.org
|
|
[198.137.202.133])
|
|
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
|
|
(No client certificate requested)
|
|
by mail.kernel.org (Postfix) with ESMTPS id 7966324698
|
|
for <patchwork-linux-arm@patchwork.kernel.org>;
|
|
Tue, 10 Mar 2020 12:54:22 +0000 (UTC)
|
|
Authentication-Results: mail.kernel.org;
|
|
dkim=pass (2048-bit key) header.d=lists.infradead.org
|
|
header.i=@lists.infradead.org header.b="QRTrew7I"
|
|
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7966324698
|
|
Authentication-Results: mail.kernel.org;
|
|
dmarc=none (p=none dis=none) header.from=suse.de
|
|
Authentication-Results: mail.kernel.org;
|
|
spf=none
|
|
smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org
|
|
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
|
|
d=lists.infradead.org; s=bombadil.20170209; h=Sender:
|
|
Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:
|
|
List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:
|
|
Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description:
|
|
Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:
|
|
List-Owner; bh=aEzRVs2pg+6QbUDWQQN1yAPYlnW+XWVwKn2FDiv80JA=; b=QRTrew7IL9vbdM
|
|
mtuOZU1FJwi43+wuyjiempsm4CcD4i4E2/w4xlW2OIcLT1Grm9thTXmLQIoxXAfg40P9oIqWxPEtz
|
|
rhv86PkeJMnxEH8qF+wjIQKwccTJyUAhPdShbUZ/SivZsdsqI9hjcuaMW0rwR6cLriXBDt+0cakcT
|
|
lbhYuhaJVupUPuPdyFV7jiOnkgrBm6i6iXfFQicO3lZtICEl5jCZUl5BCEfIalnyYAqvlbF9gPgmb
|
|
pbeU1TQCw0Wal6Frhgd0SiHOdo6Q1sx3T/++jMOKa8+Gbk9Vwgi7jggC4L2Njz0PVUrjTdR9/s+jF
|
|
d2k8KmMvgAcbYk/oKJZQ==;
|
|
Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org)
|
|
by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux))
|
|
id 1jBeOn-0005AX-Nk; Tue, 10 Mar 2020 12:54:17 +0000
|
|
Received: from mx2.suse.de ([195.135.220.15])
|
|
by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux))
|
|
id 1jBeNn-0004A1-CM; Tue, 10 Mar 2020 12:53:16 +0000
|
|
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
|
|
Received: from relay2.suse.de (unknown [195.135.220.254])
|
|
by mx2.suse.de (Postfix) with ESMTP id D2329B134;
|
|
Tue, 10 Mar 2020 12:53:13 +0000 (UTC)
|
|
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
To: linux-kernel@vger.kernel.org,
|
|
Mathias Nyman <mathias.nyman@intel.com>
|
|
Subject: [PATCH v5 4/4] USB: pci-quirks: Add Raspberry Pi 4 quirk
|
|
Date: Tue, 10 Mar 2020 13:52:42 +0100
|
|
Message-Id: <20200310125243.25805-5-nsaenzjulienne@suse.de>
|
|
X-Mailer: git-send-email 2.25.1
|
|
In-Reply-To: <20200310125243.25805-1-nsaenzjulienne@suse.de>
|
|
References: <20200310125243.25805-1-nsaenzjulienne@suse.de>
|
|
MIME-Version: 1.0
|
|
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3
|
|
X-CRM114-CacheID: sfid-20200310_055315_576152_512D1DE7
|
|
X-CRM114-Status: GOOD ( 14.95 )
|
|
X-Spam-Score: -2.3 (--)
|
|
X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary:
|
|
Content analysis details: (-2.3 points)
|
|
pts rule name description
|
|
---- ----------------------
|
|
--------------------------------------------------
|
|
-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,
|
|
medium trust [195.135.220.15 listed in list.dnswl.org]
|
|
0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
|
|
[195.135.220.15 listed in wl.mailspike.net]
|
|
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
|
|
-0.0 SPF_PASS SPF: sender matches SPF record
|
|
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
|
|
X-BeenThere: linux-arm-kernel@lists.infradead.org
|
|
X-Mailman-Version: 2.1.29
|
|
Precedence: list
|
|
List-Id: <linux-arm-kernel.lists.infradead.org>
|
|
List-Unsubscribe:
|
|
<http://lists.infradead.org/mailman/options/linux-arm-kernel>,
|
|
<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
|
|
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
|
|
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
|
|
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
|
|
List-Subscribe:
|
|
<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,
|
|
<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
|
|
Cc: f.fainelli@gmail.com, sergei.shtylyov@cogentembedded.com,
|
|
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
|
|
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>, tim.gover@raspberrypi.org,
|
|
bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org,
|
|
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
|
|
wahrenst@gmx.net
|
|
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
|
|
Errors-To:
|
|
linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org
|
|
|
|
On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be
|
|
loaded directly from an EEPROM or, if not present, by the SoC's
|
|
VideCore. Inform VideCore that VL805 was just reset.
|
|
|
|
Also, as this creates a dependency between XHCI_PCI and VideoCore's
|
|
firmware interface, reflect that on the firmware interface Kconfg.
|
|
|
|
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
---
|
|
|
|
Changes since v4:
|
|
- Do not split up error message
|
|
|
|
Changes since v3:
|
|
- Add more complete error message
|
|
|
|
Changes since v1:
|
|
- Make RASPBERRYPI_FIRMWARE dependent on this quirk to make sure it
|
|
gets compiled when needed.
|
|
|
|
drivers/firmware/Kconfig | 1 +
|
|
drivers/usb/host/pci-quirks.c | 16 ++++++++++++++++
|
|
2 files changed, 17 insertions(+)
|
|
|
|
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
|
|
index ea869addc89b..40a468d712a5 100644
|
|
--- a/drivers/firmware/Kconfig
|
|
+++ b/drivers/firmware/Kconfig
|
|
@@ -180,6 +180,7 @@ config ISCSI_IBFT
|
|
config RASPBERRYPI_FIRMWARE
|
|
tristate "Raspberry Pi Firmware Driver"
|
|
depends on BCM2835_MBOX
|
|
+ default XHCI_PCI
|
|
help
|
|
This option enables support for communicating with the firmware on the
|
|
Raspberry Pi.
|
|
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
|
|
index beb2efa71341..0dc34668bb2a 100644
|
|
--- a/drivers/usb/host/pci-quirks.c
|
|
+++ b/drivers/usb/host/pci-quirks.c
|
|
@@ -16,6 +16,9 @@
|
|
#include <linux/export.h>
|
|
#include <linux/acpi.h>
|
|
#include <linux/dmi.h>
|
|
+
|
|
+#include <soc/bcm2835/raspberrypi-firmware.h>
|
|
+
|
|
#include "pci-quirks.h"
|
|
#include "xhci-ext-caps.h"
|
|
|
|
@@ -1243,11 +1246,24 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
|
|
|
|
static void quirk_usb_early_handoff(struct pci_dev *pdev)
|
|
{
|
|
+ int ret;
|
|
+
|
|
/* Skip Netlogic mips SoC's internal PCI USB controller.
|
|
* This device does not need/support EHCI/OHCI handoff
|
|
*/
|
|
if (pdev->vendor == 0x184e) /* vendor Netlogic */
|
|
return;
|
|
+
|
|
+ if (pdev->vendor == PCI_VENDOR_ID_VIA && pdev->device == 0x3483) {
|
|
+ ret = rpi_firmware_init_vl805(pdev);
|
|
+ if (ret) {
|
|
+ /* Firmware might be outdated, or something failed */
|
|
+ dev_warn(&pdev->dev,
|
|
+ "Failed to load VL805's firmware: %d. Will continue to attempt to work, but bad things might happen. You should fix this...\n",
|
|
+ ret);
|
|
+ }
|
|
+ }
|
|
+
|
|
if (pdev->class != PCI_CLASS_SERIAL_USB_UHCI &&
|
|
pdev->class != PCI_CLASS_SERIAL_USB_OHCI &&
|
|
pdev->class != PCI_CLASS_SERIAL_USB_EHCI &&
|