45 lines
1.7 KiB
Diff
45 lines
1.7 KiB
Diff
From 93600079ef308e0d3ae39dc234c5eed7534aa941 Mon Sep 17 00:00:00 2001
|
|
From: Kamal Heib <kheib@redhat.com>
|
|
Date: Thu, 16 Apr 2026 18:03:21 -0400
|
|
Subject: [PATCH] net/mlx5: Warn when write combining is not supported
|
|
|
|
JIRA: https://redhat.atlassian.net/browse/RHEL-169055
|
|
|
|
commit d980f371b134d5d66d082161171a6be613975dfc
|
|
Author: Maor Gottlieb <maorg@nvidia.com>
|
|
Date: Wed Jul 9 00:16:26 2025 +0300
|
|
|
|
net/mlx5: Warn when write combining is not supported
|
|
|
|
Warn if write combining is not supported, as it can impact latency.
|
|
Add the warning message to be printed only when the driver actually
|
|
run the test and detect unsupported state, rather than when
|
|
inheriting parent's result for SFs.
|
|
|
|
Signed-off-by: Maor Gottlieb <maorg@nvidia.com>
|
|
Reviewed-by: Michael Guralnik <michaelgur@nvidia.com>
|
|
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
|
|
Reviewed-by: Simon Horman <horms@kernel.org>
|
|
Link: https://patch.msgid.link/1752009387-13300-5-git-send-email-tariqt@nvidia.com
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
|
|
|
Signed-off-by: Kamal Heib <kheib@redhat.com>
|
|
|
|
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wc.c b/drivers/net/ethernet/mellanox/mlx5/core/wc.c
|
|
index 740b719e7072..2f0316616fa4 100644
|
|
--- a/drivers/net/ethernet/mellanox/mlx5/core/wc.c
|
|
+++ b/drivers/net/ethernet/mellanox/mlx5/core/wc.c
|
|
@@ -378,6 +378,9 @@ static void mlx5_core_test_wc(struct mlx5_core_dev *mdev)
|
|
mlx5_free_bfreg(mdev, &sq->bfreg);
|
|
err_alloc_bfreg:
|
|
kfree(sq);
|
|
+
|
|
+ if (mdev->wc_state == MLX5_WC_STATE_UNSUPPORTED)
|
|
+ mlx5_core_warn(mdev, "Write combining is not supported\n");
|
|
}
|
|
|
|
bool mlx5_wc_support_get(struct mlx5_core_dev *mdev)
|
|
--
|
|
2.50.1 (Apple Git-155)
|
|
|