Andrew Lukoshko
ca61dd79c6
Add the RHEL 687.11.1..687.12.1 backports (1198-1252) sourced from centos-stream-9 and upstream stable, on top of 687.10.1. Bump to 5.14.0-687.12.1.
58 lines
2.3 KiB
Diff
58 lines
2.3 KiB
Diff
From aa745912584aeada31b5672155cd1014c4b5f149 Mon Sep 17 00:00:00 2001
|
|
From: Paulo Alcantara <paalcant@redhat.com>
|
|
Date: Mon, 11 May 2026 14:21:19 -0300
|
|
Subject: [PATCH] smb: client: use kzalloc to zero-initialize security
|
|
descriptor buffer
|
|
|
|
JIRA: https://issues.redhat.com/browse/RHEL-172822
|
|
|
|
commit 5e489c6c47a2ac15edbaca153b9348e42c1eacab
|
|
Author: Bjoern Doebel <doebel@amazon.de>
|
|
Date: Thu Apr 30 08:57:17 2026 +0000
|
|
|
|
smb: client: use kzalloc to zero-initialize security descriptor buffer
|
|
|
|
Commit 62e7dd0a39c2d ("smb: common: change the data type of num_aces
|
|
to le16") split struct smb_acl's __le32 num_aces field into __le16
|
|
num_aces and __le16 reserved. The reserved field corresponds to Sbz2
|
|
in the MS-DTYP ACL wire format, which must be zero [1].
|
|
|
|
When building an ACL descriptor in build_sec_desc(), we are using a
|
|
kmalloc()'ed descriptor buffer and writing the fields explicitly using
|
|
le16() writes now. This never writes to the 2 byte reserved field,
|
|
leaving it as uninitialized heap data.
|
|
|
|
When the reserved field happens to contain non-zero slab garbage,
|
|
Samba rejects the security descriptor with "ndr_pull_security_descriptor
|
|
failed: Range Error", causing chmod to fail with EINVAL.
|
|
|
|
Change kmalloc() to kzalloc() to ensure the entire buffer is
|
|
zero-initialized.
|
|
|
|
Fixes: 62e7dd0a39c2d ("smb: common: change the data type of num_aces to le16")
|
|
Cc: stable@vger.kernel.org
|
|
|
|
Signed-off-by: Bjoern Doebel <doebel@amazon.de>
|
|
Assisted-by: Kiro:claude-opus-4.6
|
|
[1] https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-dtyp/20233ed8-a6c6-4097-aafa-dd545ed24428
|
|
Signed-off-by: Steve French <stfrench@microsoft.com>
|
|
|
|
Signed-off-by: Paulo Alcantara <paalcant@redhat.com>
|
|
|
|
diff --git a/fs/smb/client/cifsacl.c b/fs/smb/client/cifsacl.c
|
|
index 8638fdfb6ffb..e23bbe088221 100644
|
|
--- a/fs/smb/client/cifsacl.c
|
|
+++ b/fs/smb/client/cifsacl.c
|
|
@@ -1739,7 +1739,7 @@ id_mode_to_cifs_acl(struct inode *inode, const char *path, __u64 *pnmode,
|
|
* descriptor parameters, and security descriptor itself
|
|
*/
|
|
nsecdesclen = max_t(u32, nsecdesclen, DEFAULT_SEC_DESC_LEN);
|
|
- pnntsd = kmalloc(nsecdesclen, GFP_KERNEL);
|
|
+ pnntsd = kzalloc(nsecdesclen, GFP_KERNEL);
|
|
if (!pnntsd) {
|
|
kfree(pntsd);
|
|
cifs_put_tlink(tlink);
|
|
--
|
|
2.50.1 (Apple Git-155)
|
|
|