rpms/gnome-software
5
0
Fork 0
Code Issues Pull Requests Releases Activity

Resolves: #2132292 (rpm-ostree plugin refuses to update)

Browse Source
This commit is contained in:
Milan Crha 2022-10-05 18:52:53 +02:00
parent 89923f63dc
commit 1cc4989f98
2 changed files with 43 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
0003-rpm-ostree-download-size.patch Normal file
View File

@ -0,0 +1,38 @@
From 823f49dc59eb1a6a00c80084a8ac37782df124fa Mon Sep 17 00:00:00 2001
Date: Mon, 26 Sep 2022 15:11:25 +0200
Subject: [PATCH] rpm-ostree: Mark apps as downloaded
There was a typo in the changes of the gs_app_set_size_download() API,
the `0` meant the app is downloaded, not that the size is unknown.
With this fixed, the Updates page offers to `Restart & Update`, instead
of `Download`, which does nothing, because the rpm-stree plugin
does not implement corresponding GsPlugin function.
---
plugins/rpm-ostree/gs-plugin-rpm-ostree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/plugins/rpm-ostree/gs-plugin-rpm-ostree.c b/plugins/rpm-ostree/gs-plugin-rpm-ostree.c
index 6984ff95b..1b4f758da 100644
--- a/plugins/rpm-ostree/gs-plugin-rpm-ostree.c
+++ b/plugins/rpm-ostree/gs-plugin-rpm-ostree.c
@@ -749,7 +749,7 @@ app_from_modified_pkg_variant (GsPlugin *plugin, GVariant *variant)
gs_app_set_management_plugin (app, plugin);
gs_app_add_quirk (app, GS_APP_QUIRK_NEEDS_REBOOT);
app_set_rpm_ostree_packaging_format (app);
- gs_app_set_size_download (app, GS_SIZE_TYPE_UNKNOWN, 0);
+ gs_app_set_size_download (app, GS_SIZE_TYPE_VALID, 0);
gs_app_set_kind (app, AS_COMPONENT_KIND_GENERIC);
gs_app_set_bundle_kind (app, AS_BUNDLE_KIND_PACKAGE);
gs_app_set_scope (app, AS_COMPONENT_SCOPE_SYSTEM);
@@ -788,7 +788,7 @@ app_from_single_pkg_variant (GsPlugin *plugin, GVariant *variant, gboolean addit
gs_app_set_management_plugin (app, plugin);
gs_app_add_quirk (app, GS_APP_QUIRK_NEEDS_REBOOT);
app_set_rpm_ostree_packaging_format (app);
- gs_app_set_size_download (app, GS_SIZE_TYPE_UNKNOWN, 0);
+ gs_app_set_size_download (app, GS_SIZE_TYPE_VALID, 0);
gs_app_set_kind (app, AS_COMPONENT_KIND_GENERIC);
gs_app_set_bundle_kind (app, AS_BUNDLE_KIND_PACKAGE);
gs_app_set_scope (app, AS_COMPONENT_SCOPE_SYSTEM);
--
GitLab

6
gnome-software.spec
View File

@ -18,7 +18,7 @@
Name: gnome-software Name: gnome-software
Version: 43.0 Version: 43.0
Release: 2%{?dist} Release: 3%{?dist}
Summary: A software center for GNOME Summary: A software center for GNOME
License: GPLv2+ License: GPLv2+
@ -27,6 +27,7 @@ Source0: https://download.gnome.org/sources/gnome-software/43/%{name}-%{tarbal
Patch01: 0001-crash-with-broken-theme.patch Patch01: 0001-crash-with-broken-theme.patch
Patch02: 0002-install-rpm-file.patch Patch02: 0002-install-rpm-file.patch
Patch03: 0003-rpm-ostree-download-size.patch
BuildRequires: docbook-style-xsl BuildRequires: docbook-style-xsl
BuildRequires: desktop-file-utils BuildRequires: desktop-file-utils
@ -212,6 +213,9 @@ desktop-file-validate %{buildroot}%{_datadir}/applications/*.desktop
%{_datadir}/gtk-doc/html/gnome-software/ %{_datadir}/gtk-doc/html/gnome-software/
%changelog %changelog
* Wed Oct 05 2022 Milan Crha <mcrha@redhat.com> - 43.0-3
- Resolves: #2132292 (rpm-ostree plugin refuses to update)
* Tue Sep 27 2022 Kalev Lember <klember@redhat.com> - 43.0-2 * Tue Sep 27 2022 Kalev Lember <klember@redhat.com> - 43.0-2
- Rebuild to fix sysprof-capture symbols leaking into libraries consuming it - Rebuild to fix sysprof-capture symbols leaking into libraries consuming it