From 1cc4989f9873aeccb514af0dd102a34a1954e96e Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Wed, 5 Oct 2022 18:52:53 +0200 Subject: [PATCH] Resolves: #2132292 (rpm-ostree plugin refuses to update) --- 0003-rpm-ostree-download-size.patch | 38 +++++++++++++++++++++++++++++ gnome-software.spec | 6 ++++- 2 files changed, 43 insertions(+), 1 deletion(-) create mode 100644 0003-rpm-ostree-download-size.patch diff --git a/0003-rpm-ostree-download-size.patch b/0003-rpm-ostree-download-size.patch new file mode 100644 index 0000000..e353dd1 --- /dev/null +++ b/0003-rpm-ostree-download-size.patch @@ -0,0 +1,38 @@ +From 823f49dc59eb1a6a00c80084a8ac37782df124fa Mon Sep 17 00:00:00 2001 +Date: Mon, 26 Sep 2022 15:11:25 +0200 +Subject: [PATCH] rpm-ostree: Mark apps as downloaded + +There was a typo in the changes of the gs_app_set_size_download() API, +the `0` meant the app is downloaded, not that the size is unknown. +With this fixed, the Updates page offers to `Restart & Update`, instead +of `Download`, which does nothing, because the rpm-stree plugin +does not implement corresponding GsPlugin function. +--- + plugins/rpm-ostree/gs-plugin-rpm-ostree.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/plugins/rpm-ostree/gs-plugin-rpm-ostree.c b/plugins/rpm-ostree/gs-plugin-rpm-ostree.c +index 6984ff95b..1b4f758da 100644 +--- a/plugins/rpm-ostree/gs-plugin-rpm-ostree.c ++++ b/plugins/rpm-ostree/gs-plugin-rpm-ostree.c +@@ -749,7 +749,7 @@ app_from_modified_pkg_variant (GsPlugin *plugin, GVariant *variant) + gs_app_set_management_plugin (app, plugin); + gs_app_add_quirk (app, GS_APP_QUIRK_NEEDS_REBOOT); + app_set_rpm_ostree_packaging_format (app); +- gs_app_set_size_download (app, GS_SIZE_TYPE_UNKNOWN, 0); ++ gs_app_set_size_download (app, GS_SIZE_TYPE_VALID, 0); + gs_app_set_kind (app, AS_COMPONENT_KIND_GENERIC); + gs_app_set_bundle_kind (app, AS_BUNDLE_KIND_PACKAGE); + gs_app_set_scope (app, AS_COMPONENT_SCOPE_SYSTEM); +@@ -788,7 +788,7 @@ app_from_single_pkg_variant (GsPlugin *plugin, GVariant *variant, gboolean addit + gs_app_set_management_plugin (app, plugin); + gs_app_add_quirk (app, GS_APP_QUIRK_NEEDS_REBOOT); + app_set_rpm_ostree_packaging_format (app); +- gs_app_set_size_download (app, GS_SIZE_TYPE_UNKNOWN, 0); ++ gs_app_set_size_download (app, GS_SIZE_TYPE_VALID, 0); + gs_app_set_kind (app, AS_COMPONENT_KIND_GENERIC); + gs_app_set_bundle_kind (app, AS_BUNDLE_KIND_PACKAGE); + gs_app_set_scope (app, AS_COMPONENT_SCOPE_SYSTEM); +-- +GitLab + diff --git a/gnome-software.spec b/gnome-software.spec index ffcafcf..40d50e3 100644 --- a/gnome-software.spec +++ b/gnome-software.spec @@ -18,7 +18,7 @@ Name: gnome-software Version: 43.0 -Release: 2%{?dist} +Release: 3%{?dist} Summary: A software center for GNOME License: GPLv2+ @@ -27,6 +27,7 @@ Source0: https://download.gnome.org/sources/gnome-software/43/%{name}-%{tarbal Patch01: 0001-crash-with-broken-theme.patch Patch02: 0002-install-rpm-file.patch +Patch03: 0003-rpm-ostree-download-size.patch BuildRequires: docbook-style-xsl BuildRequires: desktop-file-utils @@ -212,6 +213,9 @@ desktop-file-validate %{buildroot}%{_datadir}/applications/*.desktop %{_datadir}/gtk-doc/html/gnome-software/ %changelog +* Wed Oct 05 2022 Milan Crha - 43.0-3 +- Resolves: #2132292 (rpm-ostree plugin refuses to update) + * Tue Sep 27 2022 Kalev Lember - 43.0-2 - Rebuild to fix sysprof-capture symbols leaking into libraries consuming it