rpms/git
6
0
Fork 0
Code Issues Pull Requests Releases Activity

gitk: add Requires: git-gui (#1765113)

Browse Source 
While this could arguably be a Recommends: rather than Requires:, we
chose the latter for a few reasons.  The user experience when running
gitk and selecting "Start git gui" from the menu is quite poor.  No
indication is shown to the user graphically.  The only hint as to why
git gui did not start is output to stdout (and is not terribly helpful
for users who may be using gitk and git-gui because they are unfamiliar
with the command-line).

There are no additional dependencies pulled in by git-gui which are not
already dependencies of gitk.  And the git-gui package is relatively
small.

Lastly, the default behavior of Recommends: is the same as Requires: at
this time.

If/when any of these things change, we may revisit whether moving to
Recommends: makes more sense.

Thanks to Vasiliy Glazov and Pavel Cahyna for reporting the issue and
helping to determine the proper resolution.
This commit is contained in:
Todd Zullinger 2019-10-24 12:59:13 -04:00
parent 33ecb7860b
commit 16e19ee356
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
git.spec
View File

@ -391,6 +391,7 @@ Provides: emacs-git-el = %{version}-%{release}
Summary: Git repository browser Summary: Git repository browser
BuildArch: noarch BuildArch: noarch
Requires: git = %{version}-%{release} Requires: git = %{version}-%{release}
Requires: git-gui = %{version}-%{release}
Requires: tk >= 8.4 Requires: tk >= 8.4
%description -n gitk %description -n gitk
%{summary}. %{summary}.
@ -1026,6 +1027,7 @@ rmdir --ignore-fail-on-non-empty "$testdir"
* Thu Oct 24 2019 Todd Zullinger <tmz@pobox.com> - 2.24.0-0.1.rc1 * Thu Oct 24 2019 Todd Zullinger <tmz@pobox.com> - 2.24.0-0.1.rc1
- update to 2.24.0-rc1 - update to 2.24.0-rc1
- skip failing test in t7812-grep-icase-non-ascii on s390x - skip failing test in t7812-grep-icase-non-ascii on s390x
- gitk: add Requires: git-gui (#1765113)
* Sat Oct 19 2019 Todd Zullinger <tmz@pobox.com> - 2.24.0-0.0.rc0 * Sat Oct 19 2019 Todd Zullinger <tmz@pobox.com> - 2.24.0-0.0.rc0
- update to 2.24.0-rc0 - update to 2.24.0-rc0