From 16e19ee3561f67a2186abbcd066b0a940fdc0875 Mon Sep 17 00:00:00 2001 From: Todd Zullinger Date: Thu, 24 Oct 2019 12:59:13 -0400 Subject: [PATCH] gitk: add Requires: git-gui (#1765113) While this could arguably be a Recommends: rather than Requires:, we chose the latter for a few reasons. The user experience when running gitk and selecting "Start git gui" from the menu is quite poor. No indication is shown to the user graphically. The only hint as to why git gui did not start is output to stdout (and is not terribly helpful for users who may be using gitk and git-gui because they are unfamiliar with the command-line). There are no additional dependencies pulled in by git-gui which are not already dependencies of gitk. And the git-gui package is relatively small. Lastly, the default behavior of Recommends: is the same as Requires: at this time. If/when any of these things change, we may revisit whether moving to Recommends: makes more sense. Thanks to Vasiliy Glazov and Pavel Cahyna for reporting the issue and helping to determine the proper resolution. --- git.spec | 2 ++ 1 file changed, 2 insertions(+) diff --git a/git.spec b/git.spec index 5be40ef..ee18dce 100644 --- a/git.spec +++ b/git.spec @@ -391,6 +391,7 @@ Provides: emacs-git-el = %{version}-%{release} Summary: Git repository browser BuildArch: noarch Requires: git = %{version}-%{release} +Requires: git-gui = %{version}-%{release} Requires: tk >= 8.4 %description -n gitk %{summary}. @@ -1026,6 +1027,7 @@ rmdir --ignore-fail-on-non-empty "$testdir" * Thu Oct 24 2019 Todd Zullinger - 2.24.0-0.1.rc1 - update to 2.24.0-rc1 - skip failing test in t7812-grep-icase-non-ascii on s390x +- gitk: add Requires: git-gui (#1765113) * Sat Oct 19 2019 Todd Zullinger - 2.24.0-0.0.rc0 - update to 2.24.0-rc0