Remove rpath when installing

The `%{?_cmake_skip_rpath}` macro was dropped to make tests pass. The
guidelines [1] claim that `cmake` should handle rpaths correctly (ie. set
them in builddir and remove during installation). However, the installed
files have the `DT_RUNPATH` tag set. I wonder why the
`/usr/lib/rpm/check-rpaths` script doesn't fail in that case. Let's use
the `-DCMAKE_SKIP_INSTALL_RPATH` option to get rid of them.

[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/

Resolves: RHEL-71382
This commit is contained in:
Ondrej Holy 2024-12-18 12:52:34 +01:00
parent a46c2d7b0e
commit b3347205f3

View File

@ -30,7 +30,7 @@
Name: freerdp
Epoch: 2
Version: 3.10.3
Release: 1%{?dist}
Release: 2%{?dist}
Summary: Free implementation of the Remote Desktop Protocol (RDP)
# The effective license is Apache-2.0 but:
@ -180,6 +180,7 @@ find . -name "*.c" -exec chmod 664 {} \;
%build
%cmake \
-DBUILD_TESTING=ON \
-DCMAKE_SKIP_INSTALL_RPATH=ON \
-DCMAKE_INSTALL_LIBDIR:PATH=%{_lib} \
-DWITH_ALSA=ON \
-DWITH_AAD=ON \