From b3347205f3ba7d969d694c4847f9ac6d67597969 Mon Sep 17 00:00:00 2001
From: Ondrej Holy <oholy@redhat.com>
Date: Wed, 18 Dec 2024 12:52:34 +0100
Subject: [PATCH] Remove rpath when installing

The `%{?_cmake_skip_rpath}` macro was dropped to make tests pass. The
guidelines [1] claim that `cmake` should handle rpaths correctly (ie. set
them in builddir and remove during installation). However, the installed
files have the `DT_RUNPATH` tag set. I wonder why the
`/usr/lib/rpm/check-rpaths` script doesn't fail in that case. Let's use
the `-DCMAKE_SKIP_INSTALL_RPATH` option to get rid of them.

[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/

Resolves: RHEL-71382
---
 freerdp.spec | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/freerdp.spec b/freerdp.spec
index fad3686..17f98ca 100644
--- a/freerdp.spec
+++ b/freerdp.spec
@@ -30,7 +30,7 @@
 Name:           freerdp
 Epoch:          2
 Version:        3.10.3
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Free implementation of the Remote Desktop Protocol (RDP)
 
 # The effective license is Apache-2.0 but:
@@ -180,6 +180,7 @@ find . -name "*.c" -exec chmod 664 {} \;
 %build
 %cmake \
     -DBUILD_TESTING=ON \
+    -DCMAKE_SKIP_INSTALL_RPATH=ON \
     -DCMAKE_INSTALL_LIBDIR:PATH=%{_lib} \
     -DWITH_ALSA=ON \
     -DWITH_AAD=ON \