Commit Graph

28 Commits

Author SHA1 Message Date
Petr Menšík
0f2a592b77 Fix broken client subnet validation (CVE-2026-4893)
Bug report from Royce M <royce@xchglabs.com>

Location: forward.c:713, edns0.c:421

With --add-subnet enabled, process_reply() passes the OPT record
length (~23 bytes) instead of the packet length to check_source().
All internal bounds checks fail, and the function always returns 1.
ECS source validation per RFC 7871 Section 9.2 is completely bypassed.

Resolves-Vulnerability: CVE-2026-4893
Resolves: RHEL-168333
(cherry picked from commit 7479b4aee6bc1ece02d0e6c9f5691d9a803dd2f3)
2026-05-07 18:27:05 +02:00
Petr Menšík
06e01714d9 Fix buffer overflow in helper.c with large CLIDs (CVE-2026-4892)
Bug reported bt Royce M <royce@xchglabs.com>

Location: helper.c:265-270
DHCPv6 CLIDs can be up to 65535 bytes. When --dhcp-script is configured,
the helper hex-encodes raw CLID bytes via sprintf("%.2x") into daemon->packet (5131 bytes).
A 1000-byte CLID writes ~3000 bytes. The helper process retains root privileges.

Note: log6_packet() correctly caps CLID to 100 bytes for logging, but the helper code path was missed.

Resolves-Vulnerability: CVE-2026-4892
Resolves: RHEL-168316
(cherry picked from commit 80aacdfbba3f687d5586ab99e3fa7e0d952e90ac)
2026-05-07 18:26:52 +02:00
Petr Menšík
82a866d161 Verify rdlen field in RRSIG packets (CVE-2026-4891)
Resolves-Vulnerability: CVE-2026-4891
Resolves: RHEL-168298
(cherry picked from commit c81b4798ce6a31448d694f055d3c55438cd9a81d)
2026-05-07 18:26:40 +02:00
Petr Menšík
07251c056d Fix NSEC bitmap parsing infinite loop (CVE-2026-4890)
Resolves-Vulnerability: CVE-2026-4890
Resolves: RHEL-168280
(cherry picked from commit 5262d85986a0027b7fa7a5e196f1683ac05cf50f)
2026-05-07 18:26:26 +02:00
Petr Menšík
af5fc65743 Prevent overflow in extract_name function (CVE-2026-2291)
Handle invalid names correctly and refuse them without writing into too
small buffer. Contains upstream proposed basic fix.

Resolves-Vulnerability: CVE-2026-2291
Resolves: RHEL-148711
(cherry picked from commit f2182d5c6296fe676a449a2ff9bb65326a9339e7)
2026-05-07 18:26:03 +02:00
Petr Menšík
1f97a52930 Import working test plans from c10s
Use on RHEL part, too distant from Fedora anyway. Remove old plans and
use identical plans.fmf from c10s too.

Signed-off-by: Petr Menšík <pemensik@redhat.com>
2026-05-07 12:51:15 +02:00
Tomas Korbar
5bcc1ec516 Fix dnsmasq caching of intertwined CNAMES
Resolves: RHEL-61943
2025-08-19 13:02:51 +02:00
Petr Menšík
29f30a06a4 Fix problem with DNS retries
Backport 3 changes from 2.85 to send again client-driven retries. Both
for known queries from new sources and for retries from known sources
too.

This should ensure enough queries are forwarded. It would restore
incoming queries would match forwarded queries again. That is difference
to 2.85, where that is not always needed.

Resolves: RHEL-6586
2025-08-12 18:20:41 +02:00
Tomas Korbar
f76916a4d7 Fix CVE 2023-50387 and CVE 2023-50868
Resolves: RHEL-25667
Resolves: RHEL-25629
2024-03-18 11:25:04 +01:00
Petr Menšík
c5009ce16a Do not crash on invalid domain in --synth-domain option
Avoid crashing on empty or . domains specified.

Upstream Changelog:
Fix crash on startup with a --synth-domain which has no prefix.
Introduced in 2.79. Thanks to Andreas Engel for the bug report.

Resolves: RHEL-15216
2023-11-01 18:47:53 +01:00
Petr Menšík
8a2a7d987c Do not create server_domain for non-server records
--local=/example/ and --address=/example/# create records, which contain
no address or just NULL address. Some people generate quite large
blocklists, which then can take quite long to walk through. Because it
uses linear algorithm, it gets quite slow.

Similar to upstream in 2.86, avoid walking through literal addresses or
local blocks. Speeds up significantly loading of 50k or more records.

Fixed regression caused by commit 73f4c86bcc

Resolves: rhbz#2233542
(cherry picked from commit 418de6681f)
2023-08-22 16:06:39 +02:00
Petr Menšík
a8ba680391 Use CentOS/RHEL id for gating tmt plan
(cherry picked from commit c90c231c2c)
2023-07-21 10:24:03 +02:00
Petr Menšík
2d674920bd Import optional plan from Fedora
(cherry picked from commit b0e8376d17)
2023-07-21 10:23:48 +02:00
Petr Menšík
d4f93c3c5e Add group writeable permission for log file
When log-facility is used to create a new file, make that file also
writeable by root. Systemd strips the ability to write into this file
even when started by root. Allow root explicitly.

Resolves: rhbz#2207798
(cherry picked from commit cafac891ea)
2023-07-20 22:02:17 +02:00
Petr Menšík
27f283ccd5 Add extra test plan to run all defined tests
They should not block release on failure, but should be executed with
visible results.
2023-06-13 19:50:22 +02:00
Petr Menšík
afa6be0504 Require basic tests of fedora to pass gating 2023-06-13 18:19:54 +02:00
Petr Menšík
cfc91e6ce4 Run tmt based tests from dnsmasq
Tests pushed to Fedora should pass for most of RHEL tests. Use those
tests on CentOS as well.
2023-06-12 16:45:35 +02:00
Petr Menšík
2084d400c7 fixup! Correct releasing of serv_domain
Ensure correct domain entries are prepared also for DBus specified
domains. Initialize server_domain when adding new nameserver, no matter
what is its source. Do not wait for check_servers() to domain
initialization.

Resolves: rhbz#2186481
2023-05-10 13:43:45 +02:00
Petr Menšík
764271fcfc Correct releasing of serv_domain
In case the server->serv_domain points to domain also when it is not the
last server used, ensure the reference to last_server is always reset.
Some records might reference the server_domain, but cannot ever become
last_server. Such as server=/example.com/#

Do proper check also for above case and do not delete used serv_domain
structure. Also do optimization to reuse common server domains and do
not create new entry to already existing one.

Do two step cleaning during nameservers cleanup stage. Should avoid any
invalid pointer present.

Resolves: rhbz#2186481
2023-04-21 19:21:08 +02:00
Petr Menšík
f132a4c40b Set the default maximum DNS UDP packet size to 1232
Resolves: CVE-2023-28450
2023-04-21 19:19:26 +02:00
Troy Dawson
8ca7e31dc5 Bring rpminspect.yaml over from Brew dist-git
Signed-off-by: Troy Dawson <tdawson@redhat.com>
2023-03-10 10:33:45 -08:00
Troy Dawson
1f6a45753a Bring gating.yaml over from Brew dist-git
Signed-off-by: Troy Dawson <tdawson@redhat.com>
2023-03-10 10:33:45 -08:00
James Antill
13a48beb10 Import rpm: c8s 2023-02-27 12:36:49 -05:00
CentOS Sources
8237ae4b13 Auto sync2gitlab import of dnsmasq-2.79-26.el8.src.rpm 2023-02-18 00:17:53 +00:00
CentOS Sources
65adf43f35 Auto sync2gitlab import of dnsmasq-2.79-24.el8.src.rpm 2022-08-26 16:14:04 +00:00
CentOS Sources
079cef3ac0 Auto sync2gitlab import of dnsmasq-2.79-23.el8.src.rpm 2022-08-02 06:12:39 +00:00
James Antill
ede9cffdaa Auto sync2gitlab import of dnsmasq-2.79-21.el8.src.rpm 2022-05-26 01:20:47 -04:00
James Antill
957172e1d2 Initial c8s branch. 2022-05-26 01:20:43 -04:00