rpms
/
dnf-plugins-core
7
0
Fork 1
Code Issues Pull Requests Releases Activity

Fix issue with invalid utf-8 chars in needs-restarting #1

Merged
alukoshko merged 1 commits from jonathan/dnf-plugins-core:a8 into a8 2023-09-11 14:43:46 +00:00
Conversation 4 Commits 1 Files Changed 2 +68 -1
jonathan commented 2023-08-14 14:35:52 +00:00
Contributor
Copy Link

Signed-off-by: Jonathan Wright jonathan@almalinux.org

Signed-off-by: Jonathan Wright <jonathan@almalinux.org>
alukoshko was assigned by jonathan 2023-08-14 14:35:53 +00:00
jonathan added 1 commit 2023-08-14 14:35:53 +00:00
9690994bc3 Fix issue with invalid utf-8 chars in needs-restarting 
Signed-off-by: Jonathan Wright <jonathan@almalinux.org>
jonathan force-pushed a8 from 9690994bc3 to 6ac15e99f4 2023-08-14 14:57:10 +00:00 Compare
jonathan force-pushed a8 from 6ac15e99f4 to 8f50dadeaf 2023-08-14 15:08:12 +00:00 Compare
eabdullin requested changes 2023-08-15 06:15:36 +00:00
SPECS/dnf-plugins-core.spec Outdated
@ -35,3 +35,3 @@
Name: dnf-plugins-core
Version: 4.0.21
Release: 19%{?dist}
Release: 20%{?dist}.1.alma
eabdullin commented 2023-08-15 06:15:12 +00:00
Owner
Copy Link

Should be 19{?dist}.alma.1

Should be 19{?dist}.alma.1
jonathan commented 2023-08-16 20:30:24 +00:00
Author
Contributor
Copy Link

.alma.1 or .1.alma? In rpms/iperf3#1 we used .1.alma.

`.alma.1` or `.1.alma`? In https://git.almalinux.org/rpms/iperf3/pulls/1 we used `.1.alma`.
eabdullin requested changes 2023-08-15 06:30:27 +00:00
SPECS/dnf-plugins-core.spec Outdated
@ -844,6 +845,9 @@ ln -sf %{_mandir}/man1/%{yum_utils_subpackage_name}.1.gz %{buildroot}%{_mandir}/
%endif
%changelog
* Mon Aug 14 2023 Jonathan Wright <jonathan@almalinux.org> - 4.0.21-20
eabdullin commented 2023-08-15 06:30:13 +00:00
Owner
Copy Link

Same here

Same here
alukoshko commented 2023-08-15 09:21:28 +00:00
Owner
Copy Link

Agree. When we do own patching we keep original RHEL version-release and add our own .alma.1.

Agree. When we do own patching we keep original RHEL version-release and add our own .alma.1.
jonathan force-pushed a8 from 8f50dadeaf to 7358c8dd7b 2023-08-16 20:29:27 +00:00 Compare
jonathan commented 2023-08-16 20:31:14 +00:00
Author
Contributor
Copy Link

Agree. When we do own patching we keep original RHEL version-release and add our own .alma.1.

.alma.1 or .1.alma? In rpms/iperf3#1 we used .1.alma.

> Agree. When we do own patching we keep original RHEL version-release and add our own .alma.1. `.alma.1` or `.1.alma`? In https://git.almalinux.org/rpms/iperf3/pulls/1 we used `.1.alma`.
jonathan requested review from eabdullin 2023-08-16 20:39:37 +00:00
eabdullin commented 2023-08-17 06:41:20 +00:00
Owner
Copy Link

.alma.1
Using .1.alma was a mistake

`.alma.1` Using `.1.alma` was a mistake
jonathan force-pushed a8 from 7358c8dd7b to 465066425c 2023-09-01 12:19:11 +00:00 Compare
jonathan force-pushed a8 from 465066425c to 92498bde8a 2023-09-01 12:19:34 +00:00 Compare
jonathan commented 2023-09-01 12:21:21 +00:00
Author
Contributor
Copy Link

@eabdullin fixed

@eabdullin fixed
alukoshko merged commit 220f726c59 into a8 2023-09-11 14:43:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
eabdullin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
alukoshko
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: rpms/dnf-plugins-core#1
No description provided.
Delete Branch "jonathan/dnf-plugins-core:a8"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?