forked from rpms/kernel
		
	
		
			
				
	
	
		
			48 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			48 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
| From 05104a4e8713b27291c7bb49c1e7e68b4e243571 Mon Sep 17 00:00:00 2001
 | |
| From: Neil Horman <nhorman@tuxdriver.com>
 | |
| Date: Fri, 27 Sep 2013 16:53:35 +0000
 | |
| Subject: iommu: Remove stack trace from broken irq remapping warning
 | |
| 
 | |
| The warning for the irq remapping broken check in intel_irq_remapping.c is
 | |
| pretty pointless.  We need the warning, but we know where its comming from, the
 | |
| stack trace will always be the same, and it needlessly triggers things like
 | |
| Abrt.  This changes the warning to just print a text warning about BIOS being
 | |
| broken, without the stack trace, then sets the appropriate taint bit.  Since we
 | |
| automatically disable irq remapping, theres no need to contiue making Abrt jump
 | |
| at this problem
 | |
| 
 | |
| Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
 | |
| CC: Joerg Roedel <joro@8bytes.org>
 | |
| CC: Bjorn Helgaas <bhelgaas@google.com>
 | |
| CC: Andy Lutomirski <luto@amacapital.net>
 | |
| CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
 | |
| CC: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
 | |
| Signed-off-by: Joerg Roedel <joro@8bytes.org>
 | |
| ---
 | |
| diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
 | |
| index f71673d..b97d70b 100644
 | |
| --- a/drivers/iommu/intel_irq_remapping.c
 | |
| +++ b/drivers/iommu/intel_irq_remapping.c
 | |
| @@ -525,12 +525,13 @@ static int __init intel_irq_remapping_supported(void)
 | |
|  	if (disable_irq_remap)
 | |
|  		return 0;
 | |
|  	if (irq_remap_broken) {
 | |
| -		WARN_TAINT(1, TAINT_FIRMWARE_WORKAROUND,
 | |
| -			   "This system BIOS has enabled interrupt remapping\n"
 | |
| -			   "on a chipset that contains an erratum making that\n"
 | |
| -			   "feature unstable.  To maintain system stability\n"
 | |
| -			   "interrupt remapping is being disabled.  Please\n"
 | |
| -			   "contact your BIOS vendor for an update\n");
 | |
| +		printk(KERN_WARNING
 | |
| +			"This system BIOS has enabled interrupt remapping\n"
 | |
| +			"on a chipset that contains an erratum making that\n"
 | |
| +			"feature unstable.  To maintain system stability\n"
 | |
| +			"interrupt remapping is being disabled.  Please\n"
 | |
| +			"contact your BIOS vendor for an update\n");
 | |
| +		add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
 | |
|  		disable_irq_remap = 1;
 | |
|  		return 0;
 | |
|  	}
 | |
| --
 | |
| cgit v0.9.2
 |