ALBS-226: Patch pungi/lorax for building AL9 #3

Merged

soksanichenko merged 3 commits from ALBS-226 into aln9

soksanichenko commented

Owner

Defaults modules can be empty, but pungi detects
empty folder while copying and raises the exception in this case

- Defaults modules can be empty, but pungi detects empty folder while copying and raises the exception in this case

soksanichenko added 1 commit

700ae3cbac ALBS-226: Patch pungi/lorax for building AL9

- Defaults modules can be empty, but pungi detects
  empty folder while copying and raises the exception in this case

soksanichenko added 1 commit

acfdfcef15 ALBS-226: Patch pungi/lorax for building AL9

- Unit tests are fixed

soksanichenko added 1 commit

a83be2fbb2 ALBS-226: Patch pungi/lorax for building AL9

- Unit tests are fixed

monkrobot reviewed

pungi/scripts/gather_modules.py

													
				@ -67,1 +70,4 @@

				    os.makedirs(module_defaults_path, exist_ok=True)

				    # Defaults modules can be empty, but pungi detects

				    # empty folder while copying and raises the exception in this case

				    Path(os.path.join(module_defaults_path, EMPTY_FILE)).touch()

monkrobot commented

Why do you use here pathlib Path and os.path together? Maybe it's better to use just pathlib?

Why do you use here pathlib Path and os.path together? Maybe it's better to use just pathlib?

monkrobot approved these changes

anfimovdm approved these changes

anfimovdm left a comment

Collaborator

lgtm

lgtm

Korulag approved these changes

soksanichenko merged commit 30414cc748 into aln9 2 years ago

soksanichenko referenced this issue from a commit

Merge pull request 'ALBS-226: Patch pungi/lorax for building AL9' (#3) from ALBS-226 into aln9

Reviewers

monkrobot approved these changes

anfimovdm approved these changes

Korulag approved these changes

The pull request has been merged as 30414cc748.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b ALBS-226 aln9

git pull origin ALBS-226

Step 2:

Merge the changes and update on Gitea.

git checkout aln9

git merge --no-ff ALBS-226

git push origin aln9

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.