almalinux/pungi
14
1
Fork 0
Code Issues Pull Requests Releases Activity

ALBS-226: Patch pungi/lorax for building AL9 #3

Merged
soksanichenko merged 3 commits from ALBS-226 into aln9 2022-03-21 15:52:51 +00:00
Conversation 0 Commits 3 Files Changed 2 +8 -2
soksanichenko commented 2022-03-18 21:46:03 +00:00
Owner
Copy Link
  • Defaults modules can be empty, but pungi detects
    empty folder while copying and raises the exception in this case
- Defaults modules can be empty, but pungi detects empty folder while copying and raises the exception in this case
soksanichenko added 1 commit 2022-03-18 21:46:04 +00:00 
- Defaults modules can be empty, but pungi detects
  empty folder while copying and raises the exception in this case
soksanichenko added 1 commit 2022-03-19 01:26:19 +00:00 
- Unit tests are fixed
soksanichenko added 1 commit 2022-03-19 01:32:54 +00:00 
- Unit tests are fixed
monkrobot reviewed 2022-03-21 09:21:36 +00:00
pungi/scripts/gather_modules.py
@ -67,1 +70,4 @@
os.makedirs(module_defaults_path, exist_ok=True)
# Defaults modules can be empty, but pungi detects
# empty folder while copying and raises the exception in this case
Path(os.path.join(module_defaults_path, EMPTY_FILE)).touch()
monkrobot commented 2022-03-21 09:21:36 +00:00
First-time contributor
Copy Link

Why do you use here pathlib Path and os.path together? Maybe it's better to use just pathlib?

Why do you use here pathlib Path and os.path together? Maybe it's better to use just pathlib?
monkrobot approved these changes 2022-03-21 09:22:02 +00:00
anfimovdm approved these changes 2022-03-21 15:31:46 +00:00
anfimovdm left a comment
Member
Copy Link

lgtm

lgtm
Korulag approved these changes 2022-03-21 15:42:38 +00:00
soksanichenko merged commit 30414cc748 into aln9 2022-03-21 15:52:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
monkrobot
anfimovdm
Korulag
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: almalinux/pungi#3
No description provided.
Delete Branch "ALBS-226"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?