Commit Graph

2249 Commits

Author SHA1 Message Date
Alexander Todorov
b9e5fa5e7b tests: Allow skipping image build in compose sanity test
when $SKIP_IMAGE_BUILD is set the test skips 2 phases:
- start the compose again (after it has been cancelled) and
- waiting for it to finish & downloading the resulting image

This will allow to enable this test script in downstream gating
jobs.

Cherry-picked from cc29b99659,
https://github.com/weldr/lorax/pull/1053/

Related: rhbz#1825190
2020-07-28 14:21:47 -07:00
Alexander Todorov
b3ec7af1d1 Set BACKEND=osbuild-composer if running that test scenario
- this will execute cli sanity tests in parallel with the other
- make sure to pass BACKED to vm.install too
- more checks in lib.sh

Cherry-picked from cc29b99659

Related: rhbz#1825190
2020-07-28 14:21:47 -07:00
Alexander Todorov
359b99a178 tests: Don't check info after compose cancel with osbuild-composer
osbuild-composer doesn't remove cancelled composes and even if we
wait for the cancellation to take place the UUID is still there
and `compose info` returns an exit code of 0 instead of 1

Cherry-picked from 27c4c67a59

Related: rhbz#1825190
2020-07-28 14:21:47 -07:00
Alexander Todorov
de3f548025 tests: Compare blueprints as TOML objects, not strings
this is to avoid differences in ordering and white space. The same
approach is used on rhel7-extras branch.

Cherry-picked from 04bc5e9e86

Related: rhbz#1825190
2020-07-28 14:21:47 -07:00
Alexander Todorov
45d227a189 tests: Remove lorax-composer specific checks
Cherry-picked from eb7748236c

Related: rhbz#1825190
2020-07-28 14:21:47 -07:00
Alexander Todorov
76b52daa97 tests: Remove compose after we're done
Cherry-picked from 1c218ecbae

Related: rhbz#1825190
2020-07-28 14:21:47 -07:00
Lars Karlitski
3734129e67 tests: don't use beakerlib in blueprint
b/c for osbuild-composer beakerlib is not included in the
distributions we test on.

Cherry-picked from abcbbf3194

Related: rhbz#1825190
2020-07-28 14:21:47 -07:00
Lars Karlitski
8f860cc8a1 tests: don't depend on internal state of composer
Cherry-picked from 123827c90a

Related: rhbz#1825190
2020-07-28 14:21:47 -07:00
Alexander Todorov
6b2efa0da1 tests: Do not rely on example blueprints
- avoids having to modify them in the first place so less changes
  to the SUT
- will help with transition to osbuild-composer backend
- each test which needs a blueprint either declares it on its own
  (some already do this) or may use a shared blueprints from the
  tests lib dir

Cherry-picked from 7b08fa8838

Related: rhbz#1825190
2020-07-28 14:21:47 -07:00
Alexander Todorov
6240df6caf tests: Special case compose types for osbuild-composer
- alibaba - will be added later
- google - will be added later, low priority b/c
  GCE doesn't fully support RHEL8
- live-iso - not supported for now
- ext4 & partitioned disk - removed from osbuild-composer
- hyper-v & liveimg-tar are available only on master branch

Cherry-picked from 4dd7cf8798

Related: rhbz#1825190
2020-07-28 14:21:47 -07:00
Alexander Todorov
b72bb63599 tests: Don't check example blueprints if we don't have to
ATM osbuild-composer doesn't ship example blueprints

Cherry-picked from d68e01b7e1

Related: rhbz#1825190
2020-07-28 14:21:47 -07:00
Alexander Todorov
9193384bb8 tests: Use BACKEND env variable instead of hard-coded values
- default BACKEND to lorax-composer
- pass BACKEND everywhere we need to

Cherry-picked from 14a3c8d5a7

Related: rhbz#1825190
2020-07-28 14:21:47 -07:00
Alexander Todorov
a6aab2242a tests: Disable non-cli test scenarios b/c osbuild-composer
the image building functionality is now tested by the
osbuild-composer test suite. We weren't successfull at making this
test suite work with the 2 backends so decided to disabled these
scenarios instead. In the future they will likely be deleted.

Cherry-picked from f1c15c67e0

Related: rhbz#1825190
2020-07-28 14:21:47 -07:00
Brian C. Lane
6deb09db64 Automatic commit of package [lorax] release [28.14.50-1].
Created by command:

/usr/bin/tito tag
2020-07-23 11:10:34 -07:00
Brian C. Lane
088111f087 composer-cli: Make start-ostree parent and ref optional
This changes the start-ostree command to:

compose start-ostree [--size XXXX] [--parent PARENT] [--ref REF] <BLUEPRINT> <TYPE> [<IMAGE-NAME> <PROFILE.TOML>]

Both of them are optional, and if missing a "" is passed to
osbuild-composer. Also adds more tests for all the various possible
options and removes the provider and profile arguments.

(cherry picked from commit 5b0487f47c)

Resolves: rhbz#1859680
2020-07-23 10:35:28 -07:00
Brian C. Lane
dcb2f36c2d composer-cli: Add a get_arg function
This is in preperation for adding more optional arguments. Adds a
generic get_arg function, tests for it, and converts get_size to use it.

(cherry picked from commit 4a4128af23)

Related: rhbz#1859680
2020-07-23 10:35:28 -07:00
Brian C. Lane
6c2c304d98 Automatic commit of package [lorax] release [28.14.49-1].
Created by command:

/usr/bin/tito tag
2020-06-25 14:28:32 -07:00
Dan Horák
b43beffa4f include generic.ins for s390 boot iso
Include the generic.ins file on the s390 boot iso, so it's directly bootable
on an LPAR. The full iso already had generic.ins included.

(cherry picked from commit 0dbfe28745)
Signed-off-by: Brian C. Lane <bcl@redhat.com>

Related: rhbz#1844517
2020-06-25 13:37:09 -07:00
Brian C. Lane
ea48377d6b Fix the bug referenced in the last build
It was the wrong bug to use, changed to the right one so that future
builds have the correct reference.

Resolves: rhbz#1848727
2020-06-22 11:27:52 -07:00
Brian C. Lane
5ab3e14a4e Automatic commit of package [lorax] release [28.14.48-1].
Created by command:

/usr/bin/tito tag
2020-06-18 12:15:12 -07:00
Brian C. Lane
952b34dbca composer-cli: Disable retry counter on connection timeout
urllib3 has a retry system that send the request again when the
connection fails, times out, is redircted, etc. This turns off retries,
which aren't very useful anyway.

Related: rhbz#1844649
2020-06-17 10:21:00 -07:00
Brian C. Lane
800fc3b18b composer-cli: Change timeout to 5 minutes
Related: rhbz#1844649

In some cases osbuild-composer with an empty cache can take longer than
a minute to depsolve and start a compose.
2020-06-16 17:04:47 -07:00
Brian C. Lane
fc7b2931cc Automatic commit of package [lorax] release [28.14.47-1].
Created by command:

/usr/bin/tito tag
2020-06-11 09:18:20 -07:00
Brian C. Lane
54ec52eb25 lorax-composer: Add deprecation notice to documentation
Related: rhbz#1844649
2020-06-11 09:14:11 -07:00
Brian C. Lane
a003c871b3 composer-cli: Add documentation for uploads and osbuild-composer
Related: rhbz#1844649
2020-06-11 09:14:11 -07:00
Brian C. Lane
c300ac6000 composer-cli: Remove the upload and providers commands
These have never been supported on RHEL8 so remove them. Uploads are
supported by osbuild-composer using the 'compose' command.

Related: rhbz#1844649
2020-06-11 09:14:11 -07:00
Brian C. Lane
ba5a36c982 composer-cli: Return a better error with no value
And add tests for the get_size function.

Related: rhbz#1844649
2020-06-11 09:14:11 -07:00
Brian C. Lane
d056c350d4 tests: rhel8-branch uses nose not pytest
It tries to run anything with 'test' in it (and run() is reserved). It
also outputs stderr so only log errors.

Related: rhbz#1844649
2020-06-11 09:14:11 -07:00
Brian C. Lane
10c9b98219 tests: Add tests for composer-cli compose start JSON POST
Related: rhbz#1844649
2020-06-11 09:14:01 -07:00
Brian C. Lane
885866d4cf composer-cli: Update bash completion for start-ostree
Related: rhbz#1844649
2020-06-09 13:55:01 -07:00
Brian C. Lane
7da012a92b composer-cli: Add new start-ostree command
This is used to start an ostree build, it is only supported on
ostree-composer, and requires the ostree ref and parent. It may also
include --size and optionally be uploaded.

Resolves: rhbz#1844649
2020-06-09 13:52:44 -07:00
Brian C. Lane
7c705c17d1 composer-cli: Add support for --size to compose start
osbuild-composer can support user specified image sizes, this adds an
optional argument, after start, to specify the size in MiB. eg.

    composer-cli compose start --size 2048 example-http-server qcow2

This only works when the backend is not 'lorax-composer', when it is the
user will get a warning that it will be ignored.

Related: rhbz#1844649
2020-06-09 13:47:40 -07:00
Brian C. Lane
b75a4e2e3c composer-cli: pytoml load() needs an open file not a string
Resolves: rhbz#1843704
2020-06-03 15:16:37 -07:00
Martin Pitt
b2f79ef4a3 test: Put VM image overlay into /var/tmp
At least in our CI, the default place to store VM runtime overlays
(testvm.get_temp_dir()) points to a tmpfs file, so that tests can put VM
overlays into RAM and are not affected by slow I/O. But that doesn't
work for composer, as it tends to produce huge overlays due to real-life
OS composed trees.

Use /var/tmp/ instead, which is meant for large files.

Also simplify the VirtMachine invocation -- if `identity_file` is None,
that's fine -- it's the default value of that argument anyway.

Cherry-picked from master commit 9b8e0e2335
2020-06-02 21:32:12 +02:00
Brian C. Lane
cb0bd3eb25 Automatic commit of package [lorax] release [28.14.46-1].
Created by command:

/usr/bin/tito tag
2020-06-01 14:34:34 -07:00
jstodola
c467c35201 Keep /etc/default/useradd in install.img
Anaconda creates a user for connecting via ssh during the installation when the sshpw kickstart command is used. The user is created with "/sbin/nologin" shell when /etc/default/useradd is missing, which prevents the user from log into the running installation.

Resolves: rhbz#1838677
2020-06-01 13:41:21 -07:00
Brian C. Lane
eca66f833a Automatic commit of package [lorax] release [28.14.45-1].
Created by command:

/usr/bin/tito tag
2020-05-18 15:34:28 -07:00
Brian C. Lane
1718dea7fd lmc-no-virt: Add requirement on anaconda-install-env-deps
This makes sure that anaconda has all the expected modules available,
eg. libblockdev-plugins-all

Resolves: rhbz#1827911
2020-05-15 08:39:06 -07:00
Brian C. Lane
b79283b870 Fix cherry-pick of extra multipath.conf line
I included an extra line in the previous commit, remove it.

Related: rhbz#1676777
2020-05-13 14:49:51 -07:00
David Lehman
0fbf37690f Use smarter multipath detection logic.
This new setting for 'find_multipaths' tries to prevent things like
LVM from going ahead and activating LVM on the individual disks/paths
until there is reasonable certainty (via a timeout) that the device
is not a component of a multipath set.

NOTE: 'smart' is supported by device-mapper-multipath v0.7.7 and later.

Resolves: rhbz#1676777

(cherry picked from commit b8c1e706bb)
Signed-off-by: Brian C. Lane <bcl@redhat.com>
2020-05-13 14:42:47 -07:00
Brian C. Lane
2f42748e5c Automatic commit of package [lorax] release [28.14.44-1].
Created by command:

/usr/bin/tito tag
2020-05-05 11:54:54 -07:00
Brian C. Lane
3a8ef92c33 rsyslog: Disable journal ratelimits during install
Every log entry is sacred

Resolves: rhbz#1752754
2020-04-28 13:59:13 -07:00
Chris Roberts
9dfc0e6baf Update datastore for VMware testing
Related: rhbz#1825190
Signed-off-by: Brian C. Lane <bcl@redhat.com>
2020-04-28 13:57:10 -07:00
Brian C. Lane
0b45912ecb Automatic commit of package [lorax] release [28.14.43-1].
Created by command:

/usr/bin/tito tag
2020-04-27 16:50:53 -07:00
Brian C. Lane
1ffd8562be New lorax documentation - 28.14.43
Related: rhbz#1826479
2020-04-27 16:33:01 -07:00
Brian C. Lane
e8f31464bd tests: Add tests for variant branding detection
This adds tests to make sure that the changes to _install_branding are
working as expected with or without variants.

Related: rhbz#1826479
2020-04-27 16:02:24 -07:00
Brian C. Lane
3613c12464 lorax: Update how the release package is chosen
Previously the release package was chosen by picking the first package
that provides 'system-release' that isn't named generic. This can cause
branding issues with repos containing multiple system-release packages.

This patch changes _install_branding so that it will give preference to
a system-release package that ends with lowercase --variant name. If
there isn't one it will fall back to the previous behavior.

Resolves: rhbz#1826479
2020-04-27 16:02:15 -07:00
Brian C. Lane
78e525fa80 tests: Add tests for branding
Related: rhbz#1826479
2020-04-27 16:02:06 -07:00
Brian C. Lane
b310f3f788 Move get_dnf_base_object into a module
This allows it to be imported by tests.

Related: rhbz#1826479
2020-04-27 16:01:56 -07:00
Brian C. Lane
db8f198304 lorax: Add --skip-branding cmdline argument
Also document how branding currently works. See docs/lorax.rst

Resolves: rhbz#1826479
2020-04-27 16:01:35 -07:00