almalinux/cas_wrapper
13
0
Fork 2
Code Issues Pull Requests Releases Activity

ALBS-444 #2

Merged
anfimovdm merged 9 commits from ALBS-444 into master 2022-07-01 14:25:17 +00:00
Conversation 0 Commits 9 Files Changed 3 +3 -1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b6dfd39655 - Show all commits

4
cas_wrapper.py
View File

@ -142,12 +142,14 @@ class CasWrapper:
self, self,
local_path: str, local_path: str,
use_hash: bool = False, use_hash: bool = False,
return_json: bool = False,
) -> bool: ) -> bool:
is_authenticated = False is_authenticated = False
anfimovdm marked this conversation as resolved Outdated
AvoidMe commented 2022-06-29 16:06:27 +00:00
Outdated
Review
Copy Link

Instead of with self I would prefer self.ensure_login() or something, because you didn't use exit

Instead of `with self` I would prefer `self.ensure_login()` or something, because you didn't use __exit__
anfimovdm commented 2022-06-30 10:07:22 +00:00
Outdated
Review
Copy Link

Done

Done
with self as cas: with self as cas:
anfimovdm marked this conversation as resolved Outdated
soksanichenko commented 2022-06-30 10:14:21 +00:00
Outdated
Review
Copy Link

I guess colon is not needed in the logging message or it's in wrong place of the message

I guess colon is not needed in the logging message or it's in wrong place of the message
try: try:
is_authenticated = cas.authenticate(local_path, is_authenticated = cas.authenticate(local_path,
use_hash=use_hash) use_hash=use_hash,
return_json=return_json)
# we can fall with ProcessExecutionError, # we can fall with ProcessExecutionError,
# because source can be not notarized # because source can be not notarized
except ProcessExecutionError: except ProcessExecutionError: