almalinux/cas_wrapper
13
0
Fork 2
Code Issues Pull Requests Releases Activity

ALBS-443: Integrate CodeNotary with git updater tool #1

Merged
soksanichenko merged 10 commits from ALBS-443 into master 2022-06-22 11:07:24 +00:00
Conversation 0 Commits 10 Files Changed 2 +28 -25
1 changed files with 28 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f46eef7df9 - Show all commits

53
cas_wrapper.py
View File

@ -30,38 +30,20 @@ class CasWrapper:
self._cas = local['cas']
self._cas['login']()
soksanichenko marked this conversation as resolved
AvoidMe commented 2022-06-21 08:38:24 +00:00
Review
Copy Link

I feel uncomfortable with login() in __init__, can't we do it in __enter__ and __exit__?

I feel uncomfortable with `login()` in `__init__`, can't we do it in `__enter__` and `__exit__`?
soksanichenko commented 2022-06-21 10:46:18 +00:00
Review
Copy Link

Do you suggest convert it to context manager?

Do you suggest convert it to context manager?
AvoidMe commented 2022-06-21 11:14:18 +00:00
Review
Copy Link

yes

yes
def notarize(self, local_git_repo_path: str) -> str:
def notarize(
self,
local_path: str,
metadata: Dict = None,
) -> str:
"""
Wrapper around `cas notarize`
:param local_git_repo_path: path to a local Git repo
:param local_path: path to a local Git repo
:param metadata: additional metadata
:return: hash of notarized commit
:rtype: str
"""
command = self._cas[
'notarize',
local_git_repo_path,
'-o',
'json',
]
result_of_execution = command()
return json.loads(result_of_execution)['hash']
def authenticate(
self,
local_path: str,
metadata: Dict = None,
):
"""
Wrapper around `cas authenticate`
:param local_path: path to a local Git repo
(should be started from `git://`)
or to a single local file
:param metadata: additional metadata
:return: true if a commit is trusted, vice versa - false
:rtype: bool
"""
command = self._cas[
'authenticate',
local_path,
'-o',
'json',
@ -72,6 +54,27 @@ class CasWrapper:
'-a',
f'{key}={value}',
]
result_of_execution = command()
return json.loads(result_of_execution)['hash']
def authenticate(
self,
local_path: str,
):
"""
Wrapper around `cas authenticate`
:param local_path: path to a local Git repo
(should be started from `git://`)
or to a single local file
:return: true if a commit is trusted, vice versa - false
:rtype: bool
"""
command = self._cas[
'authenticate',
local_path,
'-o',
'json',
]
try:
result_of_execution = command()
except ProcessExecutionError: