almalinux/cas_wrapper
13
0
Fork 2
Code Issues Pull Requests Releases Activity

ALBS-443: Integrate CodeNotary with git updater tool #1

Merged
soksanichenko merged 10 commits from ALBS-443 into master 2022-06-22 11:07:24 +00:00
Conversation 0 Commits 10 Files Changed 2 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 037aa1ad5e - Show all commits

2
cas_wrapper.py
View File

@ -27,7 +27,7 @@ class CasWrapper:
SIGNER_ID=self._cas_signer_id SIGNER_ID=self._cas_signer_id
): ):
self._cas = local['cas'] self._cas = local['cas']
self._cas('login') self._cas['login']()
soksanichenko marked this conversation as resolved
AvoidMe commented 2022-06-21 08:38:24 +00:00
Review
Copy Link

I feel uncomfortable with login() in __init__, can't we do it in __enter__ and __exit__?

I feel uncomfortable with `login()` in `__init__`, can't we do it in `__enter__` and `__exit__`?
soksanichenko commented 2022-06-21 10:46:18 +00:00
Review
Copy Link

Do you suggest convert it to context manager?

Do you suggest convert it to context manager?
AvoidMe commented 2022-06-21 11:14:18 +00:00
Review
Copy Link

yes

yes
def notarize(self, local_git_repo_path: str) -> str: def notarize(self, local_git_repo_path: str) -> str:
""" """